Static optimization #17614
Open
Static optimization #17614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nser77 <104022475+nser77@users.noreply.github.com>
|
What problem are you trying to solve here? |
|
Hello, thanks for your answer. My curiosity here was whats the utility of |
|
The 3 is more than likely RFC defined. Have you read the rfc? In any event the patch is dead in the water the way it is presented. Please read workflow.rst for instructions on how to properly setup a patch for submission |
ton31337
reviewed
Dec 12, 2024
| @@ -91,7 +91,7 @@ static void vrrp_recalculate_timers(struct vrrp_router *r) | |||
| uint16_t skm = (r->vr->version == 3) ? r->master_adver_interval : 100; | |||
|
|
|||
| r->skew_time = ((256 - r->vr->priority) * skm) / 256; | |||
| r->master_down_interval = 3 * mdiadv; | |||
There was a problem hiding this comment.
This is defined in https://datatracker.ietf.org/doc/html/rfc5798.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this static optimization is intended to speed-up the election algorithm.
Making it configurable might be a great alternative.
Looking forward for your comments.
Regards,