Miscellaneous checkpatch fixes & improvements #1793

qlyoung · 2018-02-23T15:24:36Z

Unlike Linux we do require the GPL file header
When checking for spaces between function names and parentheses,
ignore all-uppercase function names as these are likely to be macros,
and function-like macros may have that space
Better exit codes; 2 for errors, 1 for warnings
Skip displaying report text for clean files

Signed-off-by: Quentin Young qlyoung@cumulusnetworks.com

* Unlike Linux we do require the GPL file header * When checking for spaces between function names and parentheses, ignore all-uppercase function names as these are likely to be macros, and function-like macros may have that space Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

* 2 for errors * 1 for warnings * 0 for clean * Suppress all report text for a clean result * Remove check for const structs from perl script * Remove grep suppression for that check from shell script Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

LabN-CI · 2018-02-23T16:23:38Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/1793 `6f38358`
Date	02/23/2018
Start	11:00:51
Finish	11:23:36
Run-Time	22:45
Total	1805
Pass	1805
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2018-02-23-11:00:51.txt
Log	autoscript-2018-02-23-11:01:27.log.bz2

For details, please contact louberger

qlyoung · 2018-02-23T16:25:38Z

Deleting Netdef CI comments since they are failures for l3vpn topotests which have nothing to do with the PR

NetDEF-CI · 2018-02-23T16:35:37Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2654/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source and apply patch from patchwork: Successful

Building Stage: Failed

FreeBSD11 amd64 build: Successful
Debian8 amd64 build: Successful
NetBSD6 amd64 build: Successful
CentOS7 amd64 build: Successful
OpenBSD60 amd64 build: Successful
FreeBSD10 amd64 build: Successful
Ubuntu1604 amd64 build: Successful
Fedora24 amd64 build: Successful
CentOS6 amd64 build: Successful
FreeBSD9 amd64 build: Successful
OmniOS amd64 build: Successful
Ubuntu1204 amd64 build: Successful
Debian9 amd64 build: Successful
NetBSD7 amd64 build: Successful

Ubuntu1404 amd64 build: Failed

Ubuntu1404 amd64 build: No useful log found

LabN-CI · 2018-02-23T17:10:43Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/1793 `6b1ebf3`
Date	02/23/2018
Start	11:48:04
Finish	12:10:41
Run-Time	22:37
Total	1808
Pass	1808
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2018-02-23-11:48:04.txt
Log	autoscript-2018-02-23-11:48:39.log.bz2

For details, please contact louberger

NetDEF-CI · 2018-02-23T17:18:44Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2655/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source and apply patch from patchwork: Successful

Building Stage: Successful

Basic Tests: Failed

CentOS 6 rpm pkg check: Successful
Static analyzer (clang): Successful
Ubuntu 12.04 deb pkg check: Successful
IPv6 protocols on Ubuntu 14.04: Successful
Ubuntu 16.04 deb pkg check: Successful
IPv4 ldp protocol on Ubuntu 16.04: Successful
Ubuntu 14.04 deb pkg check: Successful
CentOS 7 rpm pkg check: Successful
Addresssanitizer topotest: Successful
Debian 8 deb pkg check: Successful
IPv4 protocols on Ubuntu 14.04: Successful
Fedora 24 rpm pkg check: Successful
Debian 9 deb pkg check: Successful

Topology tests on Ubuntu 16.04 amd64: Failed

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-2655/test

Topology Tests failed for Topology tests on Ubuntu 16.04 amd64:

2018-02-23 17:55:38,657 ERROR: ******************************************************************************
2018-02-23 17:55:38,657 ERROR: Test Target Summary                                                  Pass Fail
2018-02-23 17:55:38,657 ERROR: ******************************************************************************
2018-02-23 17:55:38,657 ERROR: FILE: scripts/adjacencies.py
2018-02-23 17:55:38,657 ERROR: FILE: scripts/check_routes.py
2018-02-23 17:55:38,657 ERROR: 30   r1     Core VPN SAFI clean                                      0    1
2018-02-23 17:55:38,657 ERROR: 31   r2     Core VPN SAFI clean                                      0    1
2018-02-23 17:55:38,658 ERROR: 32   r3     Core VPN SAFI clean                                      0    1
2018-02-23 17:55:38,658 ERROR: 33   r4     Core VPN SAFI clean                                      0    1
2018-02-23 17:55:38,658 ERROR: See /tmp/topotests/bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/output.log for details of errors
2018-02-23 17:55:38,660 ERROR: assert failed at "bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/test_check_routes": 4 tests failed

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2655/artifact/TOPOU1604/ErrorLog/log_topotests.txt

Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2655/artifact/TOPOU1604/MemoryLeaks/

CLANG Static Analyzer Summary

Github Pull Request 1793, comparing to Git base SHA fb444ef
Base image data for Git fb444ef does not exist - compare skipped

21 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2655/artifact/shared/static_analysis/index.html

NetDEF-CI · 2018-02-23T17:20:01Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2653/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source and apply patch from patchwork: Successful

Building Stage: Successful

Basic Tests: Failed

Static analyzer (clang): Successful
IPv6 protocols on Ubuntu 14.04: Successful
CentOS 6 rpm pkg check: Successful
Ubuntu 16.04 deb pkg check: Successful
Ubuntu 12.04 deb pkg check: Successful
Fedora 24 rpm pkg check: Successful
Addresssanitizer topotest: Successful
Debian 8 deb pkg check: Successful
CentOS 7 rpm pkg check: Successful
Debian 9 deb pkg check: Successful
IPv4 protocols on Ubuntu 14.04: Successful
IPv4 ldp protocol on Ubuntu 16.04: Successful
Ubuntu 14.04 deb pkg check: Successful

Topology tests on Ubuntu 16.04 amd64: Failed

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-2653/test

Topology Tests failed for Topology tests on Ubuntu 16.04 amd64:

2018-02-23 08:58:08,360 ERROR: ******************************************************************************
2018-02-23 08:58:08,361 ERROR: Test Target Summary                                                  Pass Fail
2018-02-23 08:58:08,361 ERROR: ******************************************************************************
2018-02-23 08:58:08,361 ERROR: FILE: scripts/adjacencies.py
2018-02-23 08:58:08,362 ERROR: FILE: scripts/check_routes.py
2018-02-23 08:58:08,362 ERROR: 30   r1     Core VPN SAFI clean                                      0    1
2018-02-23 08:58:08,362 ERROR: 31   r2     Core VPN SAFI clean                                      0    1
2018-02-23 08:58:08,362 ERROR: 32   r3     Core VPN SAFI clean                                      0    1
2018-02-23 08:58:08,362 ERROR: 33   r4     Core VPN SAFI clean                                      0    1
2018-02-23 08:58:08,363 ERROR: See /tmp/topotests/bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/output.log for details of errors
2018-02-23 08:58:08,368 ERROR: assert failed at "bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/test_check_routes": 4 tests failed

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2653/artifact/TOPOU1604/ErrorLog/log_topotests.txt

Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2653/artifact/TOPOU1604/MemoryLeaks/

CLANG Static Analyzer Summary

Github Pull Request 1793, comparing to Git base SHA fb444ef
Base image data for Git fb444ef does not exist - compare skipped

21 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2653/artifact/shared/static_analysis/index.html

NetDEF-CI · 2018-02-23T17:33:30Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2656/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

CLANG Static Analyzer Summary

Github Pull Request 1793, comparing to Git base SHA fb444ef
Base image data for Git fb444ef does not exist - compare skipped

19 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2656/artifact/shared/static_analysis/index.html

pguibert6WIND · 2018-02-26T08:10:28Z

#1790 has been tested ok. thanks

qlyoung force-pushed the stylechecker branch from f2a010f to 6f38358 Compare February 23, 2018 15:25

qlyoung added 2 commits February 23, 2018 10:25

qlyoung changed the title ~~tools: ignore FSF warning, fn macros in checkpatch~~ Miscellaneous checkpatch fixes & improvements Feb 23, 2018

Merge branch 'master' into stylechecker

6b1ebf3

FRRouting deleted a comment from NetDEF-CI Feb 23, 2018

pguibert6WIND merged commit 8d056ac into FRRouting:master Feb 24, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Miscellaneous checkpatch fixes & improvements #1793

Miscellaneous checkpatch fixes & improvements #1793

qlyoung commented Feb 23, 2018 •

edited

Loading

LabN-CI commented Feb 23, 2018

qlyoung commented Feb 23, 2018

NetDEF-CI commented Feb 23, 2018

LabN-CI commented Feb 23, 2018

NetDEF-CI commented Feb 23, 2018

NetDEF-CI commented Feb 23, 2018

NetDEF-CI commented Feb 23, 2018

pguibert6WIND commented Feb 26, 2018

Miscellaneous checkpatch fixes & improvements #1793

Miscellaneous checkpatch fixes & improvements #1793

Conversation

qlyoung commented Feb 23, 2018 • edited Loading

LabN-CI commented Feb 23, 2018

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

qlyoung commented Feb 23, 2018

NetDEF-CI commented Feb 23, 2018

Continuous Integration Result: FAILED

Get source and apply patch from patchwork: Successful

Building Stage: Failed

Ubuntu1404 amd64 build: Failed

LabN-CI commented Feb 23, 2018

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Feb 23, 2018

Continuous Integration Result: FAILED

Get source and apply patch from patchwork: Successful

Building Stage: Successful

Basic Tests: Failed

Topology tests on Ubuntu 16.04 amd64: Failed

Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2655/artifact/TOPOU1604/MemoryLeaks/

CLANG Static Analyzer Summary

21 Static Analyzer issues remaining.

NetDEF-CI commented Feb 23, 2018

Continuous Integration Result: FAILED

Get source and apply patch from patchwork: Successful

Building Stage: Successful

Basic Tests: Failed

Topology tests on Ubuntu 16.04 amd64: Failed

Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2653/artifact/TOPOU1604/MemoryLeaks/

CLANG Static Analyzer Summary

21 Static Analyzer issues remaining.

NetDEF-CI commented Feb 23, 2018

Continuous Integration Result: SUCCESSFUL

CLANG Static Analyzer Summary

19 Static Analyzer issues remaining.

pguibert6WIND commented Feb 26, 2018

qlyoung commented Feb 23, 2018 •

edited

Loading