Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vtysh: remove deprecated HAVE_EVPN flag #363

Closed
wants to merge 1 commit into from
Closed

vtysh: remove deprecated HAVE_EVPN flag #363

wants to merge 1 commit into from

Conversation

pguibert6WIND
Copy link
Member

This flag prevents from entering into evpn address-family node, when
calling command from vtysh.

Signed-off-by: Philippe Guibert philippe.guibert@6wind.com

@pguibert6WIND pguibert6WIND mentioned this pull request Apr 12, 2017
Closed
@pguibert6WIND
vtysh: remove deprecated HAVE_EVPN flag
6ac23e4 
This flag prevents from entering into evpn address-family node, when
calling command from vtysh.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
@NetDEF-CI
Copy link
Collaborator

Continous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-462/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

rwestphal
rwestphal approved these changes Apr 12, 2017
View reviewed changes
Copy link
Member

@rwestphal rwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest in peace HAVE_EVPN :)

@rwestphal
Copy link
Member

But shouldn't this PR be for stable/3.0 instead? (I assume someone will periodically merge stable/3.0 into master)

@donaldsharp
Copy link
Member

I agree, please spin this against stable/3.0

@NetDEF-CI
Copy link
Collaborator

Continous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-465/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

@pguibert6WIND
Copy link
Member Author

closing it.
replacing it with
#379

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwestphal rwestphal rwestphal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pguibert6WIND @NetDEF-CI @rwestphal @donaldsharp