staticd: Make blackhole keyword errors more straightforward #5303

taspelund · 2019-11-08T22:02:21Z

Previous error was misleading and made it seem like Null0,
reject, or blackhole nexthops on static routes are invalid.
This commit makes it more clear as to why the error is seen.

Signed-off-by: Trey Aspelund taspelund@cumulusnetworks.com

NetDEF-CI · 2019-11-09T00:15:40Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9635/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topology tests on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-9635/test

Topology Tests failed for Topology tests on Ubuntu 18.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2019-11-08 23:11:06,476 ERROR: ******************************************************************************
2019-11-08 23:11:06,478 ERROR: Test Target Summary                                                  Pass Fail
2019-11-08 23:11:06,478 ERROR: ******************************************************************************
2019-11-08 23:11:06,478 ERROR: FILE: scripts/check_linux_vrf.py
2019-11-08 23:11:06,478 ERROR: FILE: scripts/adjacencies.py
2019-11-08 23:11:06,478 ERROR: FILE: scripts/check_routes.py
2019-11-08 23:11:06,478 ERROR: FILE: scripts/check_linux_mpls.py
2019-11-08 23:11:06,478 ERROR: FILE: scripts/scale_up.py
2019-11-08 23:11:06,478 ERROR: FILE: scripts/scale_down.py
2019-11-08 23:11:06,479 ERROR: 146  ce1    BGP routes removed +13.30 secs                           0    1
2019-11-08 23:11:06,479 ERROR: See /tmp/topotests/bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/output.log for details of errors
2019-11-08 23:11:06,483 ERROR: assert failed at "bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/test_check_scale_down": 1 tests failed
2019-11-08 23:12:35,834 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 1505, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 235, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 380, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:-1 



2019-11-08 23:12:35,953 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 1505, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 235, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 380, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:65536 



2019-11-08 23:12:36,069 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 1505, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 235, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 380, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:4294967296 



2019-11-08 23:12:36,184 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 1505, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 235, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 380, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:-1:1 



2019-11-08 23:14:37,750 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 1505, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 235, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 380, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 2: % Command incomplete[4]: bgp large-community-list standard Test1 permit

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9635/artifact/TOPOU1804/ErrorLog/log_topotests.txt

Successful on other platforms

Topology tests on Ubuntu 16.04 amd64
IPv4 protocols on Ubuntu 14.04
Debian 9 deb pkg check
Fedora 29 rpm pkg check
IPv4 ldp protocol on Ubuntu 16.04
Ubuntu 14.04 deb pkg check
Ubuntu 12.04 deb pkg check
Static analyzer (clang)
IPv6 protocols on Ubuntu 14.04
Ubuntu 16.04 deb pkg check
Topotest tests on Ubuntu 16.04 i386
Debian 10 deb pkg check
CentOS 7 rpm pkg check
Addresssanitizer topotest
Debian 8 deb pkg check

Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9635/artifact/TOPOU1804/MemoryLeaks/

CLANG Static Analyzer Summary

Github Pull Request 5303, comparing to Git base SHA 26109a7

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9635/artifact/shared/static_analysis/index.html

ton31337 · 2019-11-09T14:44:28Z

ci:rerun

NetDEF-CI · 2019-11-09T17:39:46Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9636/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

CLANG Static Analyzer Summary

Github Pull Request 5303, comparing to Git base SHA 26109a7

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9636/artifact/shared/static_analysis/index.html

staticd/static_vty.c

LabN-CI · 2019-11-14T21:15:46Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/5303 `9034e48`
Date	11/14/2019
Start	15:49:54
Finish	16:15:44
Run-Time	25:50
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-11-14-15:49:54.txt
Log	autoscript-2019-11-14-15:50:47.log.bz2
Memory	422 437 359

For details, please contact louberger

ton31337 · 2019-11-14T21:25:12Z

staticd/static_vty.c

 else
 zlog_warn(
- "%s: Nexthop interface cannot be Null0, reject or blackhole for %s",
+ "%s: %s: Nexthop interface name can not be from reserved keywords (Null0, reject, blackhole)\n",


I think \n is not needed here

srimohans

Fix the \n from zlog. Otherwise, this is good to go.

Previous error was misleading and made it seem like Null0, reject, or blackhole nexthops on static routes are invalid. This commit makes it more clear as to why the error is seen. Signed-off-by: Trey Aspelund <taspelund@cumulusnetworks.com>

NetDEF-CI · 2019-11-14T22:52:24Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9714/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

<TITLE>clang_check</TITLE>

clang_check

LabN-CI · 2019-11-14T23:31:57Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/5303 `a88be39`
Date	11/14/2019
Start	18:06:09
Finish	18:31:55
Run-Time	25:46
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-11-14-18:06:09.txt
Log	autoscript-2019-11-14-18:07:03.log.bz2
Memory	409 425 360

For details, please contact louberger

NetDEF-CI · 2019-11-15T02:39:18Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9722/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

<TITLE>clang_check</TITLE>

clang_check

polychaeta added the staticd label Nov 8, 2019

ton31337 approved these changes Nov 9, 2019

View reviewed changes

qlyoung approved these changes Nov 11, 2019

View reviewed changes

srimohans reviewed Nov 11, 2019

View reviewed changes

staticd/static_vty.c Outdated Show resolved Hide resolved

taspelund force-pushed the special_interface_error branch from fb42b3e to 9034e48 Compare November 14, 2019 20:18

taspelund requested a review from srimohans November 14, 2019 20:19

ton31337 reviewed Nov 14, 2019

View reviewed changes

srimohans approved these changes Nov 14, 2019

View reviewed changes

taspelund force-pushed the special_interface_error branch from 9034e48 to a88be39 Compare November 14, 2019 22:39

bisdhdh approved these changes Nov 15, 2019

View reviewed changes

rzalamena merged commit 1e5fe0e into FRRouting:master Nov 15, 2019

taspelund mentioned this pull request Nov 20, 2019

staticd: remove unneeded newline from zlog call #5398

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

staticd: Make blackhole keyword errors more straightforward #5303

staticd: Make blackhole keyword errors more straightforward #5303

taspelund commented Nov 8, 2019

NetDEF-CI commented Nov 9, 2019

ton31337 commented Nov 9, 2019

NetDEF-CI commented Nov 9, 2019

LabN-CI commented Nov 14, 2019

ton31337 Nov 14, 2019

srimohans left a comment

NetDEF-CI commented Nov 14, 2019

LabN-CI commented Nov 14, 2019

NetDEF-CI commented Nov 15, 2019

staticd: Make blackhole keyword errors more straightforward #5303

staticd: Make blackhole keyword errors more straightforward #5303

Conversation

taspelund commented Nov 8, 2019

NetDEF-CI commented Nov 9, 2019

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9635/artifact/TOPOU1804/MemoryLeaks/

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

ton31337 commented Nov 9, 2019

NetDEF-CI commented Nov 9, 2019

Continuous Integration Result: SUCCESSFUL

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

LabN-CI commented Nov 14, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

ton31337 Nov 14, 2019

Choose a reason for hiding this comment

srimohans left a comment

Choose a reason for hiding this comment

NetDEF-CI commented Nov 14, 2019

Continuous Integration Result: SUCCESSFUL

clang_check

LabN-CI commented Nov 14, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Nov 15, 2019

Continuous Integration Result: SUCCESSFUL

clang_check