lib: yang defination for basic routing frr-routing #5530

vishaldhingra · 2019-12-12T05:13:58Z

Yang files for basic frr-routing used by other
daemons like staticd and pim

Co-authored-by: Santosh P K sapk@vmware.com
Co-authored-by: vishaldhingra vdhingra@vmware.com
Signed-off-by: vishaldhingra vdhingra@vmware.com

polychaeta

Thanks for your contribution to FRR!

One of your commits has a missing or badly formatted Signed-off-by line; we can't accept your contribution until all of your commits have one

If you are a new contributor to FRR, please see our contributing guidelines.

NetDEF-CI · 2019-12-12T07:57:33Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10085/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10085/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: pkg-js-tools-test-is-missing
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20191211-00-geec5d7b12-0 (missing) -> 7.3-dev-20191211-00-geec5d7b12-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20191211-00-geec5d7b12-0 (missing) -> 7.3-dev-20191211-00-geec5d7b12-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20191211-00-geec5d7b12-0 (missing) -> 7.3-dev-20191211-00-geec5d7b12-0~deb10u1
W: frr: spelling-error-in-readme-debian explecitly explicitly
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20191211-00-geec5d7b12-0 (missing) -> 7.3-dev-20191211-00-geec5d7b12-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20191211-00-geec5d7b12-0 (missing) -> 7.3-dev-20191211-00-geec5d7b12-0~deb10u1

CLANG Static Analyzer Summary

Github Pull Request 5530, comparing to Git base SHA a5f271c

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10085/artifact/shared/static_analysis/index.html

qlyoung · 2019-12-19T16:27:46Z

This is going nowhere until the signoff line is fixed.

polychaeta

Thanks for your contribution to FRR!

One of your commits has a missing or badly formatted Signed-off-by line; we can't accept your contribution until all of your commits have one

If you are a new contributor to FRR, please see our contributing guidelines.

polychaeta

Thanks for your contribution to FRR!

One of your commits has a missing or badly formatted Signed-off-by line; we can't accept your contribution until all of your commits have one

If you are a new contributor to FRR, please see our contributing guidelines.

polychaeta

Thanks for your contribution to FRR!

One of your commits has a missing or badly formatted Signed-off-by line; we can't accept your contribution until all of your commits have one

If you are a new contributor to FRR, please see our contributing guidelines.

NetDEF-CI · 2019-12-20T06:50:54Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10173/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10173/artifact/CI009BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo
  CC       lib/md5.lo

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10173/artifact/CI009BUILD/config.status/config.status

Successful on other platforms

Debian 8 amd64 build
Debian 10 amd64 build
NetBSD 6 amd64 build
CentOS 7 amd64 build
OpenBSD 6 amd64 build
Ubuntu 16.04 amd64 build
Ubuntu 18.04 amd64 build
FreeBSD 12 amd64 build
Ubuntu 18.04 ppc64le build
NetBSD 8 amd64 build
Debian 9 amd64 build
Ubuntu 14.04 amd64 build
Ubuntu 12.04 amd64 build
Fedora 29 amd64 build
Ubuntu 16.04 i386 build

blocking comments addressed

NetDEF-CI · 2019-12-20T07:24:56Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10178/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10178/artifact/CI009BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo
  CC       lib/md5.lo

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10178/artifact/CI009BUILD/config.status/config.status

Successful on other platforms

Ubuntu 18.04 amd64 build
CentOS 7 amd64 build
FreeBSD 12 amd64 build
Ubuntu 14.04 amd64 build
Debian 8 amd64 build
Ubuntu 18.04 ppc64le build
Debian 9 amd64 build
OpenBSD 6 amd64 build
NetBSD 8 amd64 build
Ubuntu 16.04 amd64 build
NetBSD 6 amd64 build
Ubuntu 12.04 amd64 build
Ubuntu 16.04 i386 build
Fedora 29 amd64 build
Debian 10 amd64 build

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10178/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: pkg-js-tools-test-is-missing
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20191220-00-g942443e73-0 (missing) -> 7.3-dev-20191220-00-g942443e73-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20191220-00-g942443e73-0 (missing) -> 7.3-dev-20191220-00-g942443e73-0~deb10u1
W: frr: spelling-error-in-readme-debian explecitly explicitly
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20191220-00-g942443e73-0 (missing) -> 7.3-dev-20191220-00-g942443e73-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20191220-00-g942443e73-0 (missing) -> 7.3-dev-20191220-00-g942443e73-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20191220-00-g942443e73-0 (missing) -> 7.3-dev-20191220-00-g942443e73-0~deb10u1

NetDEF-CI · 2019-12-20T08:44:44Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10172/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

CLANG Static Analyzer Summary

Github Pull Request 5530, comparing to Git base SHA 7d75ef8

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10172/artifact/shared/static_analysis/index.html

NetDEF-CI · 2019-12-20T09:26:16Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10177/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

CLANG Static Analyzer Summary

Github Pull Request 5530, comparing to Git base SHA 7d75ef8

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10177/artifact/shared/static_analysis/index.html

Spantik · 2020-01-24T07:46:02Z

ci:rerun

NetDEF-CI · 2020-01-24T08:11:00Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10532/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10532/artifact/CI009BUILD/ErrorLog/log_make.txt)

 9595 |    CPP_NOTICE(
ospfd/ospf_neighbor.c: In function 'ospf_nbr_lookup':
ospfd/ospf_neighbor.c:410:45: error: taking address of packed member of 'struct ip' may result in an unaligned pointer value [-Werror=address-of-packed-member]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:7476: ospfd/ospf_neighbor.o] Error 1
In file included from ./lib/yang_wrappers.h:23,
eigrpd/eigrp_packet.c: In function 'eigrp_read':
eigrpd/eigrp_packet.c:552:25: error: taking address of packed member of 'struct ip' may result in an unaligned pointer value [-Werror=address-of-packed-member]
./lib/prefix.h:344:46: note: in definition of macro 'IPV4_ADDR_SAME'

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10532/artifact/CI009BUILD/config.status/config.status

Successful on other platforms

Ubuntu 14.04 amd64 build
Ubuntu 18.04 amd64 build
FreeBSD 12 amd64 build
Ubuntu 16.04 i386 build
Debian 9 amd64 build
Debian 8 amd64 build
Ubuntu 18.04 ppc64le build
OpenBSD 6 amd64 build
NetBSD 8 amd64 build
NetBSD 6 amd64 build
Ubuntu 16.04 amd64 build
CentOS 7 amd64 build
Ubuntu 12.04 amd64 build
Debian 10 amd64 build
Fedora 29 amd64 build

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10532/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: pkg-js-tools-test-is-missing
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20191220-00-g942443e73-0 (missing) -> 7.3-dev-20191220-00-g942443e73-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20191220-00-g942443e73-0 (missing) -> 7.3-dev-20191220-00-g942443e73-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20191220-00-g942443e73-0 (missing) -> 7.3-dev-20191220-00-g942443e73-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20191220-00-g942443e73-0 (missing) -> 7.3-dev-20191220-00-g942443e73-0~deb10u1
W: frr: spelling-error-in-readme-debian explecitly explicitly
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20191220-00-g942443e73-0 (missing) -> 7.3-dev-20191220-00-g942443e73-0~deb10u1

NetDEF-CI · 2020-01-24T11:32:12Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10534/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10534/artifact/CI009BUILD/ErrorLog/log_make.txt)

 9595 |    CPP_NOTICE(
ospfd/ospf_neighbor.c: In function 'ospf_nbr_lookup':
ospfd/ospf_neighbor.c:410:45: error: taking address of packed member of 'struct ip' may result in an unaligned pointer value [-Werror=address-of-packed-member]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:7476: ospfd/ospf_neighbor.o] Error 1
In file included from ./lib/yang_wrappers.h:23,
eigrpd/eigrp_packet.c: In function 'eigrp_read':
eigrpd/eigrp_packet.c:552:25: error: taking address of packed member of 'struct ip' may result in an unaligned pointer value [-Werror=address-of-packed-member]
./lib/prefix.h:344:46: note: in definition of macro 'IPV4_ADDR_SAME'

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10534/artifact/CI009BUILD/config.status/config.status

Successful on other platforms

Ubuntu 16.04 amd64 build
Ubuntu 14.04 amd64 build
Ubuntu 16.04 i386 build
Ubuntu 18.04 amd64 build
Debian 8 amd64 build
NetBSD 6 amd64 build
Ubuntu 18.04 ppc64le build
CentOS 7 amd64 build
Debian 9 amd64 build
OpenBSD 6 amd64 build
Ubuntu 12.04 amd64 build
NetBSD 8 amd64 build
Fedora 29 amd64 build
FreeBSD 12 amd64 build
Debian 10 amd64 build

vishaldhingra · 2020-01-24T12:26:28Z

vishaldhingra · 2020-01-24T12:30:15Z

I am getting below error after running below commands:

git clone https://github.com/vishaldhingra/frr.git
git remote add upstream https://github.com/FRRouting/frr.git
git fetch upstream
git checkout nb_conversions

I feel it's a rights issue. Please find the logs

Logs :

root@dev:~/nb/frr# git remote add upstream https://github.com/FRRouting/frr.git
root@dev:~/nb/frr# git fetch upstream
remote: Enumerating objects: 3764, done.
remote: Counting objects: 100% (3764/3764), done.
remote: Compressing objects: 100% (27/27), done.
remote: Total 6836 (delta 3739), reused 3753 (delta 3737), pack-reused 3072
Receiving objects: 100% (6836/6836), 3.26 MiB | 1017.00 KiB/s, done.
Resolving deltas: 100% (4906/4906), completed with 1098 local objects.
From https://github.com/FRRouting/frr
 * [new branch]      bgp_ls     -> upstream/bgp_ls
 * [new branch]      debian/buster -> upstream/debian/buster
 * [new branch]      debian/master -> upstream/debian/master
 * [new branch]      dev/7.3    -> upstream/dev/7.3
 * [new branch]      dev_isis_sr -> upstream/dev_isis_sr
 * [new branch]      master     -> upstream/master
 * [new branch]      nb_conversions -> upstream/nb_conversions
 * [new branch]      stable/2.0 -> upstream/stable/2.0
 * [new branch]      stable/3.0 -> upstream/stable/3.0
 * [new branch]      stable/4.0 -> upstream/stable/4.0
 * [new branch]      stable/5.0 -> upstream/stable/5.0
 * [new branch]      stable/6.0 -> upstream/stable/6.0
 * [new branch]      stable/7.0 -> upstream/stable/7.0
 * [new branch]      stable/7.1 -> upstream/stable/7.1
 * [new branch]      stable/7.2 -> upstream/stable/7.2
 * [new branch]      support_bundle -> upstream/support_bundle
 * [new tag]         base_7.2   -> base_7.2
 * [new tag]         debian/frr-6.0.3-1 -> debian/frr-6.0.3-1
 * [new tag]         frr-3.0.4  -> frr-3.0.4
 * [new tag]         frr-4.0.1  -> frr-4.0.1
 * [new tag]         frr-6.1-dev -> frr-6.1-dev
 * [new tag]         frr-7.1-dev -> frr-7.1-dev
 * [new tag]         frr-7.2-dev -> frr-7.2-dev
 * [new tag]         frr-7.2.1  -> frr-7.2.1
 * [new tag]         frr-7.3-dev -> frr-7.3-dev
 * [new tag]         base_7.3   -> base_7.3
 * [new tag]         debian/frr-6.0.2-1 -> debian/frr-6.0.2-1
 * [new tag]         debian/frr-6.0.2-2 -> debian/frr-6.0.2-2
 * [new tag]         frr-5.0.2  -> frr-5.0.2
 * [new tag]         frr-6.0    -> frr-6.0
 * [new tag]         frr-6.0.1  -> frr-6.0.1
 * [new tag]         frr-6.0.2  -> frr-6.0.2
 * [new tag]         frr-6.0.3  -> frr-6.0.3
 * [new tag]         frr-7.0    -> frr-7.0
 * [new tag]         frr-7.0.1  -> frr-7.0.1
 * [new tag]         frr-7.1    -> frr-7.1
 * [new tag]         frr-7.2    -> frr-7.2
 * [new tag]         frr-7.4-dev -> frr-7.4-dev
root@dev:~/nb/frr# git checkout nb_conversions
error: pathspec 'nb_conversions' did not match any file(s) known to git.

NetDEF-CI · 2020-01-28T11:35:06Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10543/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10543/artifact/CI009BUILD/ErrorLog/log_make.txt)

 9595 |    CPP_NOTICE(
ospfd/ospf_neighbor.c: In function 'ospf_nbr_lookup':
ospfd/ospf_neighbor.c:410:45: error: taking address of packed member of 'struct ip' may result in an unaligned pointer value [-Werror=address-of-packed-member]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:7476: ospfd/ospf_neighbor.o] Error 1
In file included from ./lib/yang_wrappers.h:23,
eigrpd/eigrp_packet.c: In function 'eigrp_read':
eigrpd/eigrp_packet.c:552:25: error: taking address of packed member of 'struct ip' may result in an unaligned pointer value [-Werror=address-of-packed-member]
./lib/prefix.h:344:46: note: in definition of macro 'IPV4_ADDR_SAME'

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10543/artifact/CI009BUILD/config.status/config.status

Successful on other platforms

Ubuntu 18.04 ppc64le build
Debian 9 amd64 build
Ubuntu 12.04 amd64 build
Ubuntu 16.04 i386 build
Fedora 29 amd64 build
NetBSD 6 amd64 build
CentOS 7 amd64 build
Debian 8 amd64 build
FreeBSD 12 amd64 build
Ubuntu 14.04 amd64 build
Debian 10 amd64 build
OpenBSD 6 amd64 build
NetBSD 8 amd64 build
Ubuntu 16.04 amd64 build
Ubuntu 18.04 amd64 build

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10543/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: pkg-js-tools-test-is-missing
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200128-00-gdbb89003e-0 (missing) -> 7.3-dev-20200128-00-gdbb89003e-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200128-00-gdbb89003e-0 (missing) -> 7.3-dev-20200128-00-gdbb89003e-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200128-00-gdbb89003e-0 (missing) -> 7.3-dev-20200128-00-gdbb89003e-0~deb10u1
W: frr: spelling-error-in-readme-debian explecitly explicitly
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200128-00-gdbb89003e-0 (missing) -> 7.3-dev-20200128-00-gdbb89003e-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200128-00-gdbb89003e-0 (missing) -> 7.3-dev-20200128-00-gdbb89003e-0~deb10u1

NetDEF-CI · 2020-01-28T18:50:37Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10543/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10543/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: pkg-js-tools-test-is-missing
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200128-00-gdbb89003e-0 (missing) -> 7.3-dev-20200128-00-gdbb89003e-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200128-00-gdbb89003e-0 (missing) -> 7.3-dev-20200128-00-gdbb89003e-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200128-00-gdbb89003e-0 (missing) -> 7.3-dev-20200128-00-gdbb89003e-0~deb10u1
W: frr: spelling-error-in-readme-debian explecitly explicitly
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200128-00-gdbb89003e-0 (missing) -> 7.3-dev-20200128-00-gdbb89003e-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200128-00-gdbb89003e-0 (missing) -> 7.3-dev-20200128-00-gdbb89003e-0~deb10u1

CLANG Static Analyzer Summary

Github Pull Request 5530, comparing to Git base SHA 7d75ef8

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10543/artifact/shared/static_analysis/index.html

qlyoung

Just a few comments. IMO our YANG descriptions should describe the objects being modeled, not the model itself.

yang/frr-routing.yang

qlyoung · 2020-01-31T17:41:50Z

yang/frr-routing.yang

+          }
+          description
+            "Type of the control-plane protocol -- an identity
+             derived from the 'control-plane-protocol'


Let's not be too detailed in the descriptions; they are used to add information that isn't immediately obvious from the model itself. Plus if the name of the base ever changes the description will be out of date and the model will still validate.

qlyoung · 2020-01-31T17:42:20Z

yang/frr-routing.yang

+        leaf vrf {
+          type frr-vrf:vrf-ref;
+          description
+            "routing instance";


VRF of routing instance?

rwestphal · 2020-02-04T02:16:09Z

yang/frr-routing.yang

+  }
+
+  identity static {
+    base routing-protocol;


I believe this identity could be defined in the staticd module instead (which should augment this one).

done, It's part of static yang now.

rwestphal · 2020-02-04T02:18:34Z

yang/frr-routing.yang

+  }
+
+  identity direct {
+    base routing-protocol;


We should also have identities to the other base route types: kernel and system (?). And maybe we could name this connected instead since this is the term most people are used to.

I have removed this identity, as it's a route type. For route type frr-route-types.yang is already there.

rwestphal · 2020-02-04T02:22:34Z

yang/frr-routing.yang

+  /* Type Definitions */
+
+  typedef route-preference {
+    type uint32;


Rename to administrative-distance? Or at least make it clear what this means in the description (I wouldn't be shy to reuse the original description from the IETF module).

Also, this needs to be uint8 for FRR.

NetDEF-CI · 2020-02-07T09:48:42Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10659/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10659/artifact/CI009BUILD/ErrorLog/log_make.txt)

 9595 |    CPP_NOTICE(
ospfd/ospf_neighbor.c: In function 'ospf_nbr_lookup':
ospfd/ospf_neighbor.c:410:45: error: taking address of packed member of 'struct ip' may result in an unaligned pointer value [-Werror=address-of-packed-member]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:7476: ospfd/ospf_neighbor.o] Error 1
In file included from ./lib/yang_wrappers.h:23,
eigrpd/eigrp_packet.c: In function 'eigrp_read':
eigrpd/eigrp_packet.c:552:25: error: taking address of packed member of 'struct ip' may result in an unaligned pointer value [-Werror=address-of-packed-member]
./lib/prefix.h:344:46: note: in definition of macro 'IPV4_ADDR_SAME'

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10659/artifact/CI009BUILD/config.status/config.status

Successful on other platforms

Ubuntu 18.04 amd64 build
FreeBSD 12 amd64 build
Ubuntu 14.04 amd64 build
Debian 8 amd64 build
Ubuntu 18.04 ppc64le build
Debian 9 amd64 build
OpenBSD 6 amd64 build
NetBSD 8 amd64 build
NetBSD 6 amd64 build
CentOS 7 amd64 build
Ubuntu 16.04 amd64 build
Ubuntu 12.04 amd64 build
Ubuntu 16.04 i386 build
Fedora 29 amd64 build
Debian 10 amd64 build

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10659/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: pkg-js-tools-test-is-missing
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200207-00-ge7860ed39-0 (missing) -> 7.3-dev-20200207-00-ge7860ed39-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200207-00-ge7860ed39-0 (missing) -> 7.3-dev-20200207-00-ge7860ed39-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200207-00-ge7860ed39-0 (missing) -> 7.3-dev-20200207-00-ge7860ed39-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200207-00-ge7860ed39-0 (missing) -> 7.3-dev-20200207-00-ge7860ed39-0~deb10u1
W: frr: spelling-error-in-readme-debian explecitly explicitly
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200207-00-ge7860ed39-0 (missing) -> 7.3-dev-20200207-00-ge7860ed39-0~deb10u1

vishaldhingra · 2020-02-07T10:01:32Z

@rwestphal and @qlyoung thanks for your review.

NetDEF-CI · 2020-02-07T12:53:11Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10660/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10660/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: pkg-js-tools-test-is-missing
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200207-00-gc16f9f508-0 (missing) -> 7.4-dev-20200207-00-gc16f9f508-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200207-00-gc16f9f508-0 (missing) -> 7.4-dev-20200207-00-gc16f9f508-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200207-00-gc16f9f508-0 (missing) -> 7.4-dev-20200207-00-gc16f9f508-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200207-00-gc16f9f508-0 (missing) -> 7.4-dev-20200207-00-gc16f9f508-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200207-00-gc16f9f508-0 (missing) -> 7.4-dev-20200207-00-gc16f9f508-0~deb10u1

qlyoung · 2020-02-07T17:15:45Z

lib/subdir.am

@@ -106,6 +106,7 @@ nodist_lib_libfrr_la_SOURCES = \
 	yang/frr-interface.yang.c \
 	yang/frr-route-types.yang.c \
 	yang/frr-vrf.yang.c \
+        yang/frr-routing.yang.c \


Please fix the formatting here; use tabs

Yang files for basic frr-routing used by other daemons like staticd and pim Co-authored-by: Santosh P K <sapk@vmware.com> Co-authored-by: vishaldhingra <vdhingra@vmware.com> Signed-off-by: vishaldhingra <vdhingra@vmware.com>

NetDEF-CI · 2020-02-10T08:31:13Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10671/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

polychaeta added the libfrr label Dec 12, 2019

polychaeta previously requested changes Dec 12, 2019

View reviewed changes

vishaldhingra force-pushed the common_nb branch from eec5d7b to 6b3bd6f Compare December 20, 2019 06:17

polychaeta previously requested changes Dec 20, 2019

View reviewed changes

vishaldhingra force-pushed the common_nb branch from 6b3bd6f to 3ccf8c1 Compare December 20, 2019 06:25

polychaeta previously requested changes Dec 20, 2019

View reviewed changes

vishaldhingra changed the title ~~lib: yang defination for ietf:interfaces, vrf, ietf-routing~~ lib: yang defination for basic routing frr-routing Dec 20, 2019

vishaldhingra requested a review from polychaeta December 20, 2019 06:39

vishaldhingra force-pushed the common_nb branch from 3ccf8c1 to 2518f56 Compare December 20, 2019 06:47

polychaeta previously requested changes Dec 20, 2019

View reviewed changes

vishaldhingra force-pushed the common_nb branch from 2518f56 to 942443e Compare December 20, 2019 06:56

qlyoung added the yang label Jan 14, 2020

Spantik requested a review from polychaeta January 24, 2020 09:36

vishaldhingra force-pushed the common_nb branch from 942443e to a32359a Compare January 24, 2020 11:08

vishaldhingra force-pushed the common_nb branch from a32359a to dbb8900 Compare January 28, 2020 11:09

Spantik requested a review from qlyoung January 31, 2020 16:03

qlyoung reviewed Jan 31, 2020

View reviewed changes

rwestphal reviewed Feb 4, 2020

View reviewed changes

vishaldhingra force-pushed the common_nb branch 2 times, most recently from e7860ed to c16f9f5 Compare February 7, 2020 09:29

qlyoung added the review & merge me look at me! label Feb 7, 2020

qlyoung reviewed Feb 7, 2020

View reviewed changes

lib: yang defination for basic frr-routing

f5319ff

Yang files for basic frr-routing used by other daemons like staticd and pim Co-authored-by: Santosh P K <sapk@vmware.com> Co-authored-by: vishaldhingra <vdhingra@vmware.com> Signed-off-by: vishaldhingra <vdhingra@vmware.com>

vishaldhingra force-pushed the common_nb branch from c16f9f5 to f5319ff Compare February 10, 2020 05:04

qlyoung approved these changes Feb 14, 2020

View reviewed changes

qlyoung merged commit aa9935c into FRRouting:nb_conversions Feb 14, 2020

vishaldhingra deleted the common_nb branch February 18, 2021 12:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lib: yang defination for basic routing frr-routing #5530

lib: yang defination for basic routing frr-routing #5530

vishaldhingra commented Dec 12, 2019 •

edited

Loading

polychaeta left a comment

NetDEF-CI commented Dec 12, 2019

qlyoung commented Dec 19, 2019

polychaeta left a comment

polychaeta left a comment

polychaeta left a comment

NetDEF-CI commented Dec 20, 2019

NetDEF-CI commented Dec 20, 2019

NetDEF-CI commented Dec 20, 2019

NetDEF-CI commented Dec 20, 2019

Spantik commented Jan 24, 2020

NetDEF-CI commented Jan 24, 2020

NetDEF-CI commented Jan 24, 2020

vishaldhingra commented Jan 24, 2020

vishaldhingra commented Jan 24, 2020

NetDEF-CI commented Jan 28, 2020

NetDEF-CI commented Jan 28, 2020

qlyoung left a comment

qlyoung Jan 31, 2020

vishaldhingra Feb 7, 2020

qlyoung Jan 31, 2020

vishaldhingra Feb 7, 2020

rwestphal Feb 4, 2020

vishaldhingra Feb 7, 2020

rwestphal Feb 4, 2020

vishaldhingra Feb 7, 2020

rwestphal Feb 4, 2020

vishaldhingra Feb 7, 2020

NetDEF-CI commented Feb 7, 2020

vishaldhingra commented Feb 7, 2020

NetDEF-CI commented Feb 7, 2020

qlyoung Feb 7, 2020

vishaldhingra Feb 10, 2020

NetDEF-CI commented Feb 10, 2020

lib: yang defination for basic routing frr-routing #5530

lib: yang defination for basic routing frr-routing #5530

Conversation

vishaldhingra commented Dec 12, 2019 • edited Loading

polychaeta left a comment

Choose a reason for hiding this comment

NetDEF-CI commented Dec 12, 2019

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

qlyoung commented Dec 19, 2019

polychaeta left a comment

Choose a reason for hiding this comment

polychaeta left a comment

Choose a reason for hiding this comment

polychaeta left a comment

Choose a reason for hiding this comment

NetDEF-CI commented Dec 20, 2019

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

NetDEF-CI commented Dec 20, 2019

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

NetDEF-CI commented Dec 20, 2019

Continuous Integration Result: SUCCESSFUL

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

NetDEF-CI commented Dec 20, 2019

Continuous Integration Result: SUCCESSFUL

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

Spantik commented Jan 24, 2020

NetDEF-CI commented Jan 24, 2020

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

NetDEF-CI commented Jan 24, 2020

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

vishaldhingra commented Jan 24, 2020

vishaldhingra commented Jan 24, 2020

NetDEF-CI commented Jan 28, 2020

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

NetDEF-CI commented Jan 28, 2020

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

qlyoung left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NetDEF-CI commented Feb 7, 2020

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

vishaldhingra commented Feb 7, 2020

NetDEF-CI commented Feb 7, 2020

vishaldhingra commented Dec 12, 2019 •

edited

Loading