bgpd : bgp yang definition #5702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polychaeta
previously requested changes
Jan 17, 2020
There was a problem hiding this comment.
Thanks for your contribution to FRR!
- One of your commits has a missing or badly formatted
Signed-off-byline; we can't accept your contribution until all of your commits have one
If you are a new contributor to FRR, please see our contributing guidelines.
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: FailedFreeBSD 11 amd64 build: Failed (click for details)Make failed for FreeBSD 11 amd64 build: FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10480/artifact/CI009BUILD/config.status/config.status Successful on other platforms
|
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10481/ This is a comment from an automated CI system. CLANG Static Analyzer Summary
No Changes in Static Analysis warnings compared to base1 Static Analyzer issues remaining.See details at |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: FailedFreeBSD 11 amd64 build: Failed (click for details)Make failed for FreeBSD 11 amd64 build: FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10502/artifact/CI009BUILD/config.status/config.status Successful on other platforms
Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: |
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10528/ This is a comment from an automated CI system. Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: CLANG Static Analyzer Summary
No Changes in Static Analysis warnings compared to base1 Static Analyzer issues remaining.See details at |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: FailedFreeBSD 11 amd64 build: Failed (click for details)Make failed for FreeBSD 11 amd64 build: FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10533/artifact/CI009BUILD/config.status/config.status Successful on other platforms
|
riw777
reviewed
Jan 28, 2020
yang/frr-bgp-common-structure.yang
Outdated
| type boolean; | ||
| default "false"; | ||
| description | ||
| "When set to 'TRUE' Only accept my AS in the as-path |
yang/frr-bgp-common-structure.yang
Outdated
| description | ||
| "Replace occurrences of the peer's AS in the AS_PATH with | ||
| the local autonomous system number. This is same as override | ||
| ASN cli."; |
yang/frr-bgp-common-structure.yang
Outdated
| default "false"; | ||
| description | ||
| "Strict capability negotiation match. When set to 'TRUE' it | ||
| strictly compares remote capabilities and local capabilities. |
There was a problem hiding this comment.
another nit, but maybe When set to 'TRUE' remote and local capabilities are strictly compared.
yang/frr-bgp-common-structure.yang
Outdated
| type boolean; | ||
| default "false"; | ||
| description | ||
| "When set to 'TRUE' it advertises dynamic capability to this |
There was a problem hiding this comment.
For all of these where "it" is used, it might be better to reverse the sentence... ??
When set to 'TRUE,' dynamic capability is advertise to this neighbor
yang/frr-bgp-common-structure.yang
Outdated
| default "false"; | ||
| description | ||
| "When set to 'TRUE' it advertises extended next-hop capability | ||
| to the peer."; |
There was a problem hiding this comment.
When set to 'TRUE,' the extended next-hop capability is advertised to this peer
yang/frr-bgp-common.yang
Outdated
| default "false"; | ||
| description | ||
| "When set to 'true', this allow RR to modify the attributes of the | ||
| reflected IBGP routes as per the out route-map. It is set 'False' |
There was a problem hiding this comment.
'False'/'FALSE' -- just to be consistent?
yang/frr-bgp-common.yang
Outdated
| type boolean; | ||
| default "false"; | ||
| description | ||
| "When set to 'true' it will deactive the ipv4-unicast address family |
There was a problem hiding this comment.
When set to 'TRUE," the ipv4-unicast address family, which is activated by default, is deactivated.
yang/frr-bgp-common.yang
Outdated
| default "false"; | ||
| description | ||
| "When set to 'true' it will deactive the ipv4-unicast address family | ||
| which is activated by default. When set to 'false' it will activate |
There was a problem hiding this comment.
When set to 'FALSE,' the ipv4-unicast family is activated
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: FailedFreeBSD 11 amd64 build: Failed (click for details)Make failed for FreeBSD 11 amd64 build: FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10576/artifact/CI009BUILD/config.status/config.status Successful on other platforms
Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: FailedFreeBSD 11 amd64 build: Failed (click for details)Make failed for FreeBSD 11 amd64 build: FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10578/artifact/CI009BUILD/config.status/config.status Successful on other platforms
Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: |
vishaldhingra
force-pushed
the
bgp_nb
branch
2 times, most recently
from
bf67d92 to
d776460
Compare
At present Policy yangs are in progress, for the time being I have placed all the hooks that required for policy interfacing in BGP. We will update the BGP yang files once policy yang finalised. |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: FailedFreeBSD 11 amd64 build: Failed (click for details)Make failed for FreeBSD 11 amd64 build: FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10581/artifact/CI009BUILD/config.status/config.status Successful on other platforms
Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: FailedFreeBSD 11 amd64 build: Failed (click for details)Make failed for FreeBSD 11 amd64 build: FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10582/artifact/CI009BUILD/config.status/config.status Successful on other platforms
|
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: FailedFreeBSD 11 amd64 build: Failed (click for details)Make failed for FreeBSD 11 amd64 build: FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10584/artifact/CI009BUILD/config.status/config.status Successful on other platforms
Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: |
riw777
reviewed
Feb 4, 2020
yang/frr-bgp-types.yang
Outdated
| enum "externel" { | ||
| value 3; | ||
| description | ||
| "Externel BGP peer"; |
There was a problem hiding this comment.
"External" -- seriously small nit :-)
riw777
approved these changes
Feb 4, 2020
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
🚧 Basic BGPD CI results: Partial FAILURE, 3 tests failedResults table
For details, please contact louberger |
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedIPv6 protocols on Ubuntu 18.04: Failed (click for details)CentOS 7 rpm pkg check: Failed (click for details)CentOS 7 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13301/artifact/CENTOS7RPM/ErrorLog/log_restart.txt CentOS 7 rpm pkg check: No useful log foundTopo tests part 1 on Ubuntu 16.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604AMD64-13301/test Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 amd64: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13301/artifact/TP1U1604AMD64/ErrorLog/log_topotests.txt Fedora 29 rpm pkg check: Failed (click for details)Fedora 29 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13301/artifact/F29RPMCHECK/ErrorLog/log_package_start.txt Fedora 29 rpm pkg check: No useful log foundTopo tests part 0 on Ubuntu 16.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-13301/test Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 amd64 IPv4 protocols on Ubuntu 18.04: Failed (click for details)Topo tests part 2 on Ubuntu 16.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP0U1604AMD64-13301/test Topology Tests failed for Topo tests part 2 on Ubuntu 16.04 amd64: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13301/artifact/TP0U1604AMD64/ErrorLog/log_topotests.txt Topo tests part 2 on Ubuntu 16.04 i386: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP2U1604I386-13301/test Topology Tests failed for Topo tests part 2 on Ubuntu 16.04 i386: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13301/artifact/TP2U1604I386/ErrorLog/log_topotests.txt Topo tests part 0 on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-13301/test Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 amd64 Ubuntu 16.04 deb pkg check: Failed (click for details)Ubuntu 16.04 deb pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13301/artifact/U1604DEBTEST/ErrorLog/log_package_start.txt Ubuntu 16.04 deb pkg check: No useful log foundTopo tests part 2 on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP2U1804AMD64-13301/test Topology Tests failed for Topo tests part 2 on Ubuntu 18.04 amd64: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13301/artifact/TP2U1804AMD64/ErrorLog/log_topotests.txt Topo tests part 0 on Ubuntu 16.04 i386: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-13301/test Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 i386 Topo tests part 0 un Ubuntu 16.04 arm8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO0U16ARM8-13301/test Topology Tests failed for Topo tests part 0 un Ubuntu 16.04 arm8 Topo tests part 1 on Ubuntu 16.04 i386: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604I386-13301/test Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 i386: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13301/artifact/TP1U1604I386/ErrorLog/log_topotests.txt Ubuntu 18.04 deb pkg check: Failed (click for details)Ubuntu 18.04 deb pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13301/artifact/U18DEBPKG/ErrorLog/log_package_start.txt Ubuntu 18.04 deb pkg check: No useful log foundIPv4 ldp protocol on Ubuntu 18.04: Failed (click for details)Debian 9 deb pkg check: Failed (click for details)Debian 9 deb pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13301/artifact/D9DEBCHECK/ErrorLog/log_package_start.txt Debian 9 deb pkg check: No useful log foundTopo tests part 1 on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1804AMD64-13301/test Topology Tests failed for Topo tests part 1 on Ubuntu 18.04 amd64: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13301/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt Successful on other platforms/tests
Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13307/ This is a comment from an automated CI system. Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: |
Continuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedCentOS 7 rpm pkg check: Failed (click for details)CentOS 7 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13303/artifact/CENTOS7RPM/ErrorLog/log_restart.txt CentOS 7 rpm pkg check: No useful log foundIPv6 protocols on Ubuntu 18.04: Failed (click for details)Topo tests part 1 on Ubuntu 16.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604AMD64-13303/test Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 amd64: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13303/artifact/TP1U1604AMD64/ErrorLog/log_topotests.txt IPv4 protocols on Ubuntu 18.04: Failed (click for details)Topo tests part 0 on Ubuntu 16.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-13303/test Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 amd64 Topo tests part 2 on Ubuntu 16.04 i386: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP2U1604I386-13303/test Topology Tests failed for Topo tests part 2 on Ubuntu 16.04 i386: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13303/artifact/TP2U1604I386/ErrorLog/log_topotests.txt Topo tests part 2 on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP2U1804AMD64-13303/test Topology Tests failed for Topo tests part 2 on Ubuntu 18.04 amd64: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13303/artifact/TP2U1804AMD64/ErrorLog/log_topotests.txt Topo tests part 0 on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-13303/test Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 amd64 Topo tests part 2 on Ubuntu 16.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP0U1604AMD64-13303/test Topology Tests failed for Topo tests part 2 on Ubuntu 16.04 amd64: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13303/artifact/TP0U1604AMD64/ErrorLog/log_topotests.txt Ubuntu 16.04 deb pkg check: Failed (click for details)Ubuntu 16.04 deb pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13303/artifact/U1604DEBTEST/ErrorLog/log_package_start.txt Ubuntu 16.04 deb pkg check: No useful log foundTopo tests part 0 un Ubuntu 16.04 arm8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO0U16ARM8-13303/test Topology Tests failed for Topo tests part 0 un Ubuntu 16.04 arm8 Topo tests part 1 on Ubuntu 16.04 i386: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604I386-13303/test Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 i386: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13303/artifact/TP1U1604I386/ErrorLog/log_topotests.txt IPv4 ldp protocol on Ubuntu 18.04: Failed (click for details)Topo tests part 0 on Ubuntu 16.04 i386: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-13303/test Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 i386 Topo tests part 1 on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1804AMD64-13303/test Topology Tests failed for Topo tests part 1 on Ubuntu 18.04 amd64: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13303/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt Successful on other platforms/tests
Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: |
chiragshah6
reviewed
Jul 30, 2020
| grouping med-config { | ||
| description | ||
| "Configuration relating to MED."; | ||
| container med-config { |
There was a problem hiding this comment.
This container should have presence statement.
There was a problem hiding this comment.
As discussed, I will check other places too.
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13398/ This is a comment from an automated CI system. Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: |
|
BGP_yang_cli_data_struct_mapping.xlsx |
qlyoung
reviewed
Aug 3, 2020
chiragshah6
reviewed
Aug 6, 2020
|
@chiragshah6 and @qlyoung Thanks a lot for your review comments. |
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13576/ This is a comment from an automated CI system. Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: |
rwestphal
reviewed
Aug 12, 2020
There was a problem hiding this comment.
Great work. I couldn't review node by node but the overall structure of the module looks pretty good to me. I think it was a wise decision to split the main module into smaller submodules, given how big BGP is.
I've left a couple of review comments but nothing hard to address.
Yang files for bgpd to use northbound APIs Co-authored-by: Santosh P K <sapk@vmware.com> Co-authored-by: vishaldhingra <vdhingra@vmware.com> Signed-off-by: vishaldhingra <vdhingra@vmware.com>
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13623/ This is a comment from an automated CI system. Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: |
pguibert6WIND
approved these changes
Aug 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Santosh P K sapk@vmware.com
Co-authored-by: vishaldhingra vdhingra@vmware.com
Signed-off-by: vishaldhingra vdhingra@vmware.com