*: vrf northbound callbacks #5989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polychaeta
reviewed
Mar 12, 2020
There was a problem hiding this comment.
Thanks for your contribution to FRR!
Click for style suggestions
To apply these suggestions:
curl -s https://gist.githubusercontent.com/polychaeta/8222139957b358e964f582e2a8df7c99/raw/0d98ae21e9ee39e4034330de7f2f96aafc726e57/cr_5989_1583975409.diff | git apply
diff --git a/lib/yang.c b/lib/yang.c
index a0d1695c3..ce3a50b66 100644
--- a/lib/yang.c
+++ b/lib/yang.c
@@ -73,12 +73,8 @@ static const char *yang_module_imp_clb(const char *mod_name,
}
static const char *const frr_native_modules[] = {
- "frr-interface",
- "frr-vrf",
- "frr-ripd",
- "frr-ripngd",
- "frr-isisd",
- "frr-vrrpd",
+ "frr-interface", "frr-vrf", "frr-ripd",
+ "frr-ripngd", "frr-isisd", "frr-vrrpd",
};
/* Generate the yang_modules tree. */
If you are a new contributor to FRR, please see our contributing guidelines.
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDTest incomplete. See below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: IncompleteTopology tests on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-11096/test Topology Tests failed for Topology tests on Ubuntu 18.04 amd64: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11096/artifact/TOPOU1804/ErrorLog/log_topotests.txt IPv6 protocols on Ubuntu 14.04: Failed (click for details)IPv4 ldp protocol on Ubuntu 16.04: Failed (click for details)Topology tests on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-11096/test Topology Tests failed for Topology tests on Ubuntu 18.04 amd64: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11096/artifact/TOPOU1804/ErrorLog/log_topotests.txt IPv6 protocols on Ubuntu 14.04: Failed (click for details)IPv4 ldp protocol on Ubuntu 16.04: Failed (click for details)Addresssanitizer topotest: Incomplete(check logs for details)IPv4 protocols on Ubuntu 14.04: Failed (click for details)Topology tests on Ubuntu 16.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-11096/test Topology Tests failed for Topology tests on Ubuntu 16.04 amd64: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11096/artifact/TOPOU1604/ErrorLog/log_topotests.txt Topotest tests on Ubuntu 16.04 i386: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-11096/test Topology Tests failed for Topotest tests on Ubuntu 16.04 i386: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11096/artifact/TOPOI386/ErrorLog/log_topotests.txt CentOS 7 rpm pkg check: Failed (click for details)CentOS 7 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11096/artifact/CENTOS7RPM/ErrorLog/log_package_start.txt CentOS 7 rpm pkg check: No useful log foundSuccessful on other platforms/tests
|
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDTest incomplete. See below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: IncompleteTopology tests on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-11096/test Topology Tests failed for Topology tests on Ubuntu 18.04 amd64: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11096/artifact/TOPOU1804/ErrorLog/log_topotests.txt IPv6 protocols on Ubuntu 14.04: Failed (click for details)IPv4 ldp protocol on Ubuntu 16.04: Failed (click for details)Topology tests on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-11096/test Topology Tests failed for Topology tests on Ubuntu 18.04 amd64: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11096/artifact/TOPOU1804/ErrorLog/log_topotests.txt IPv6 protocols on Ubuntu 14.04: Failed (click for details)IPv4 ldp protocol on Ubuntu 16.04: Failed (click for details)Addresssanitizer topotest: Incomplete(check logs for details)IPv4 protocols on Ubuntu 14.04: Failed (click for details)Topology tests on Ubuntu 16.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-11096/test Topology Tests failed for Topology tests on Ubuntu 16.04 amd64: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11096/artifact/TOPOU1604/ErrorLog/log_topotests.txt Topotest tests on Ubuntu 16.04 i386: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-11096/test Topology Tests failed for Topotest tests on Ubuntu 16.04 i386: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11096/artifact/TOPOI386/ErrorLog/log_topotests.txt CentOS 7 rpm pkg check: Failed (click for details)CentOS 7 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11096/artifact/CENTOS7RPM/ErrorLog/log_package_start.txt CentOS 7 rpm pkg check: No useful log foundSuccessful on other platforms/tests
|
polychaeta
reviewed
Mar 18, 2020
There was a problem hiding this comment.
Thanks for your contribution to FRR!
Click for style suggestions
To apply these suggestions:
curl -s https://gist.githubusercontent.com/polychaeta/906976f4a58c5c9640cdfecd00bb3d70/raw/0d98ae21e9ee39e4034330de7f2f96aafc726e57/cr_5989_1584568614.diff | git apply
diff --git a/lib/yang.c b/lib/yang.c
index a0d1695c3..ce3a50b66 100644
--- a/lib/yang.c
+++ b/lib/yang.c
@@ -73,12 +73,8 @@ static const char *yang_module_imp_clb(const char *mod_name,
}
static const char *const frr_native_modules[] = {
- "frr-interface",
- "frr-vrf",
- "frr-ripd",
- "frr-ripngd",
- "frr-isisd",
- "frr-vrrpd",
+ "frr-interface", "frr-vrf", "frr-ripd",
+ "frr-ripngd", "frr-isisd", "frr-vrrpd",
};
/* Generate the yang_modules tree. */
If you are a new contributor to FRR, please see our contributing guidelines.
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDTest incomplete. See below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: IncompleteTopotest tests on Ubuntu 16.04 i386: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-11281/test Topology Tests failed for Topotest tests on Ubuntu 16.04 i386: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11281/artifact/TOPOI386/ErrorLog/log_topotests.txt CentOS 7 rpm pkg check: Failed (click for details)CentOS 7 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11281/artifact/CENTOS7RPM/ErrorLog/log_package_start.txt CentOS 7 rpm pkg check: No useful log foundIPv4 ldp protocol on Ubuntu 16.04: Failed (click for details)Topotest tests on Ubuntu 16.04 i386: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-11281/test Topology Tests failed for Topotest tests on Ubuntu 16.04 i386: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11281/artifact/TOPOI386/ErrorLog/log_topotests.txt CentOS 7 rpm pkg check: Failed (click for details)CentOS 7 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11281/artifact/CENTOS7RPM/ErrorLog/log_package_start.txt CentOS 7 rpm pkg check: No useful log foundIPv4 ldp protocol on Ubuntu 16.04: Failed (click for details)Addresssanitizer topotest: Incomplete(check logs for details)Topology tests on Ubuntu 16.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-11281/test Topology Tests failed for Topology tests on Ubuntu 16.04 amd64: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11281/artifact/TOPOU1604/ErrorLog/log_topotests.txt IPv4 protocols on Ubuntu 14.04: Failed (click for details)IPv6 protocols on Ubuntu 14.04: Failed (click for details)Topology tests on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-11281/test Topology Tests failed for Topology tests on Ubuntu 18.04 amd64: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11281/artifact/TOPOU1804/ErrorLog/log_topotests.txt Successful on other platforms/tests
|
polychaeta
reviewed
Mar 19, 2020
There was a problem hiding this comment.
Thanks for your contribution to FRR!
Click for style suggestions
To apply these suggestions:
curl -s https://gist.githubusercontent.com/polychaeta/1dcdf9531596f9a5d222c577e2f0352c/raw/5cebc1f1548702045046bdfe22e7bb56fc9bb33b/cr_5989_1584584430.diff | git apply
diff --git a/lib/yang.c b/lib/yang.c
index 535aa2da5..40f5aedec 100644
--- a/lib/yang.c
+++ b/lib/yang.c
@@ -66,23 +66,18 @@ static const char *yang_module_imp_clb(const char *mod_name,
return e->data;
}
- /*NOTE: Daemon starts seeing errors for in built yang types.
- * Commenting out for now. Need to figure out the error reason.
- */
+ /*NOTE: Daemon starts seeing errors for in built yang types.
+ * Commenting out for now. Need to figure out the error reason.
+ */
/*flog_warn(EC_LIB_YANG_MODULE_LOAD,*/
- zlog_debug(
- "YANG model \"%s@%s\" not embedded, trying external file",
- mod_name, mod_rev ? mod_rev : "*");
+ zlog_debug("YANG model \"%s@%s\" not embedded, trying external file",
+ mod_name, mod_rev ? mod_rev : "*");
return NULL;
}
static const char *const frr_native_modules[] = {
- "frr-interface",
- "frr-vrf",
- "frr-ripd",
- "frr-ripngd",
- "frr-isisd",
- "frr-vrrpd",
+ "frr-interface", "frr-vrf", "frr-ripd",
+ "frr-ripngd", "frr-isisd", "frr-vrrpd",
};
/* Generate the yang_modules tree. */
If you are a new contributor to FRR, please see our contributing guidelines.
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDTest incomplete. See below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: IncompleteIPv6 protocols on Ubuntu 14.04: Failed (click for details)Topotest tests on Ubuntu 16.04 i386: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-11283/test Topology Tests failed for Topotest tests on Ubuntu 16.04 i386: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11283/artifact/TOPOI386/ErrorLog/log_topotests.txt CentOS 7 rpm pkg check: Failed (click for details)CentOS 7 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11283/artifact/CENTOS7RPM/ErrorLog/log_package_start.txt CentOS 7 rpm pkg check: No useful log foundIPv6 protocols on Ubuntu 14.04: Failed (click for details)Topotest tests on Ubuntu 16.04 i386: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-11283/test Topology Tests failed for Topotest tests on Ubuntu 16.04 i386: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11283/artifact/TOPOI386/ErrorLog/log_topotests.txt CentOS 7 rpm pkg check: Failed (click for details)CentOS 7 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11283/artifact/CENTOS7RPM/ErrorLog/log_package_start.txt CentOS 7 rpm pkg check: No useful log foundAddresssanitizer topotest: Incomplete(check logs for details)Topology tests on Ubuntu 16.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-11283/test Topology Tests failed for Topology tests on Ubuntu 16.04 amd64: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11283/artifact/TOPOU1604/ErrorLog/log_topotests.txt IPv4 protocols on Ubuntu 14.04: Failed (click for details)IPv4 ldp protocol on Ubuntu 16.04: Failed (click for details)Topology tests on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-11283/test Topology Tests failed for Topology tests on Ubuntu 18.04 amd64: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11283/artifact/TOPOU1804/ErrorLog/log_topotests.txt Successful on other platforms/tests
|
polychaeta
reviewed
Mar 21, 2020
There was a problem hiding this comment.
Thanks for your contribution to FRR!
Click for style suggestions
To apply these suggestions:
curl -s https://gist.githubusercontent.com/polychaeta/694f6694b06604c0dc1ae47af337db8c/raw/0d98ae21e9ee39e4034330de7f2f96aafc726e57/cr_5989_1584754602.diff | git apply
diff --git a/lib/yang.c b/lib/yang.c
index a0d1695c3..ce3a50b66 100644
--- a/lib/yang.c
+++ b/lib/yang.c
@@ -73,12 +73,8 @@ static const char *yang_module_imp_clb(const char *mod_name,
}
static const char *const frr_native_modules[] = {
- "frr-interface",
- "frr-vrf",
- "frr-ripd",
- "frr-ripngd",
- "frr-isisd",
- "frr-vrrpd",
+ "frr-interface", "frr-vrf", "frr-ripd",
+ "frr-ripngd", "frr-isisd", "frr-vrrpd",
};
/* Generate the yang_modules tree. */
If you are a new contributor to FRR, please see our contributing guidelines.
rwestphal
requested changes
Mar 21, 2020
There was a problem hiding this comment.
Looks good in general, but please see my inline comments (minor nits).
One additional thing is that you need to convert the "[no] vrf NAME" commands into wrappers around the new VRF callbacks.
Regarding the EC_LIB_YANG_MODULE_LOAD warning problem (which you just removed while I was reviewing this =)), I think we might need to embed IETF modules in addition to our native modules to solve that problem.
yang/frr-vrf.yang
Outdated
| leaf id { | ||
| type uint32 { | ||
| range "0..4294967295"; | ||
| container netns { |
There was a problem hiding this comment.
The VRF netns can be configured on zebra only, so this container probably belongs to frr-zebra.yang (which should augment /frr-vrf:lib/vrf).
There was a problem hiding this comment.
Sure will exclude this from here and submit in a new PR.
yang/frr-vrf.yang
Outdated
| range "0..4294967295"; | ||
| container netns { | ||
| /* FIXME: libyang support is required */ | ||
| /* if-feature "netns"; */ |
There was a problem hiding this comment.
nit: to be precise, it's the FRR NB that needs some additional work to support YANG features (libyang is fine). For now, not using if-feature shouldn't be a problem (we can reject netns config changes in the appropriate northbound callbacks).
yang/frr-vrf.yang
Outdated
| @@ -3,6 +3,10 @@ module frr-vrf { | |||
| namespace "http://frrouting.org/yang/vrf"; | |||
| prefix frr-vrf; | |||
|
|
|||
| import ietf-yang-types { | |||
| prefix yang; | |||
There was a problem hiding this comment.
@rwestphal I added this to see if module load errors can be resolved. I will remove it while handling other review comments.
lib/vrf.c
Outdated
| /* TODO: implement me. */ | ||
| break; | ||
| } | ||
| #endif |
rwestphal
reviewed
Mar 21, 2020
yang/frr-vrf.yang
Outdated
| leaf active { | ||
| type boolean; | ||
| default "false"; | ||
| config false; |
There was a problem hiding this comment.
This is unnecessary. When not specified, the "config" setting is inherited from the parent node (which is "state" in this case).
There was a problem hiding this comment.
Sure will remove it.
|
@rwestphal The CI is failing when it attempts to configure an interface in default vrf. It appears to be interface module complaining of vrf data tree not present. In my latest commit I moved Any thoughts on how to solve if the above attempt fails? |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDTest incomplete. See below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: IncompleteTopology tests on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-11358/test Topology Tests failed for Topology tests on Ubuntu 18.04 amd64: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11358/artifact/TOPOU1804/ErrorLog/log_topotests.txt IPv6 protocols on Ubuntu 14.04: Failed (click for details)Topotest tests on Ubuntu 16.04 i386: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-11358/test Topology Tests failed for Topotest tests on Ubuntu 16.04 i386: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11358/artifact/TOPOI386/ErrorLog/log_topotests.txt CentOS 7 rpm pkg check: Failed (click for details)CentOS 7 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11358/artifact/CENTOS7RPM/ErrorLog/log_package_start.txt CentOS 7 rpm pkg check: No useful log foundTopology tests on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-11358/test Topology Tests failed for Topology tests on Ubuntu 18.04 amd64: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11358/artifact/TOPOU1804/ErrorLog/log_topotests.txt IPv6 protocols on Ubuntu 14.04: Failed (click for details)Topotest tests on Ubuntu 16.04 i386: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-11358/test Topology Tests failed for Topotest tests on Ubuntu 16.04 i386: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11358/artifact/TOPOI386/ErrorLog/log_topotests.txt CentOS 7 rpm pkg check: Failed (click for details)CentOS 7 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11358/artifact/CENTOS7RPM/ErrorLog/log_package_start.txt CentOS 7 rpm pkg check: No useful log foundAddresssanitizer topotest: Incomplete(check logs for details)Topology tests on Ubuntu 16.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-11358/test Topology Tests failed for Topology tests on Ubuntu 16.04 amd64: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11358/artifact/TOPOU1604/ErrorLog/log_topotests.txt IPv4 protocols on Ubuntu 14.04: Failed (click for details)IPv4 ldp protocol on Ubuntu 16.04: Failed (click for details)Successful on other platforms/tests
|
polychaeta
reviewed
Mar 21, 2020
There was a problem hiding this comment.
Thanks for your contribution to FRR!
Click for style suggestions
To apply these suggestions:
curl -s https://gist.githubusercontent.com/polychaeta/299178138e73f6af01f707cf72bb83ca/raw/75535febfa1b57046688ad6001f2470c7a4a463f/cr_5989_1584769277.diff | git apply
diff --git a/lib/yang.c b/lib/yang.c
index caf0668ad..40f5aedec 100644
--- a/lib/yang.c
+++ b/lib/yang.c
@@ -76,12 +76,8 @@ static const char *yang_module_imp_clb(const char *mod_name,
}
static const char *const frr_native_modules[] = {
- "frr-interface",
- "frr-vrf",
- "frr-ripd",
- "frr-ripngd",
- "frr-isisd",
- "frr-vrrpd",
+ "frr-interface", "frr-vrf", "frr-ripd",
+ "frr-ripngd", "frr-isisd", "frr-vrrpd",
};
/* Generate the yang_modules tree. */
If you are a new contributor to FRR, please see our contributing guidelines.
Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDTest incomplete. See below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: IncompleteTopology tests on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-11359/test Topology Tests failed for Topology tests on Ubuntu 18.04 amd64: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11359/artifact/TOPOU1804/ErrorLog/log_topotests.txt IPv6 protocols on Ubuntu 14.04: Failed (click for details)Topotest tests on Ubuntu 16.04 i386: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-11359/test Topology Tests failed for Topotest tests on Ubuntu 16.04 i386: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11359/artifact/TOPOI386/ErrorLog/log_topotests.txt IPv4 ldp protocol on Ubuntu 16.04: Failed (click for details)CentOS 7 rpm pkg check: Failed (click for details)CentOS 7 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11359/artifact/CENTOS7RPM/ErrorLog/log_package_start.txt CentOS 7 rpm pkg check: No useful log foundTopology tests on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-11359/test Topology Tests failed for Topology tests on Ubuntu 18.04 amd64: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11359/artifact/TOPOU1804/ErrorLog/log_topotests.txt IPv6 protocols on Ubuntu 14.04: Failed (click for details)Topotest tests on Ubuntu 16.04 i386: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-11359/test Topology Tests failed for Topotest tests on Ubuntu 16.04 i386: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11359/artifact/TOPOI386/ErrorLog/log_topotests.txt IPv4 ldp protocol on Ubuntu 16.04: Failed (click for details)CentOS 7 rpm pkg check: Failed (click for details)CentOS 7 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11359/artifact/CENTOS7RPM/ErrorLog/log_package_start.txt CentOS 7 rpm pkg check: No useful log foundAddresssanitizer topotest: Incomplete(check logs for details)Topology tests on Ubuntu 16.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-11359/test Topology Tests failed for Topology tests on Ubuntu 16.04 amd64: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11359/artifact/TOPOU1604/ErrorLog/log_topotests.txt IPv4 protocols on Ubuntu 14.04: Failed (click for details)Successful on other platforms/tests
|
polychaeta
reviewed
Mar 21, 2020
There was a problem hiding this comment.
Thanks for your contribution to FRR!
Click for style suggestions
To apply these suggestions:
curl -s https://gist.githubusercontent.com/polychaeta/596f506ed66592b1fb3a99558a3ec68d/raw/75535febfa1b57046688ad6001f2470c7a4a463f/cr_5989_1584834840.diff | git apply
diff --git a/lib/yang.c b/lib/yang.c
index caf0668ad..40f5aedec 100644
--- a/lib/yang.c
+++ b/lib/yang.c
@@ -76,12 +76,8 @@ static const char *yang_module_imp_clb(const char *mod_name,
}
static const char *const frr_native_modules[] = {
- "frr-interface",
- "frr-vrf",
- "frr-ripd",
- "frr-ripngd",
- "frr-isisd",
- "frr-vrrpd",
+ "frr-interface", "frr-vrf", "frr-ripd",
+ "frr-ripngd", "frr-isisd", "frr-vrrpd",
};
/* Generate the yang_modules tree. */
If you are a new contributor to FRR, please see our contributing guidelines.
|
@rwestphal |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDTest incomplete. See below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: IncompleteAddresssanitizer topotest: Incomplete(check logs for details)CentOS 7 rpm pkg check: Failed (click for details)CentOS 7 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11367/artifact/CENTOS7RPM/ErrorLog/log_package_start.txt CentOS 7 rpm pkg check: No useful log foundSuccessful on other platforms/tests
|
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedCentOS 7 rpm pkg check: Failed (click for details)CentOS 7 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11367/artifact/CENTOS7RPM/ErrorLog/log_package_start.txt CentOS 7 rpm pkg check: No useful log foundSuccessful on other platforms/tests
Warnings Generated during build:Checkout code: Successful with additional warningsCentOS 7 rpm pkg check: Failed (click for details)CentOS 7 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11367/artifact/CENTOS7RPM/ErrorLog/log_package_start.txt CentOS 7 rpm pkg check: No useful log found |
This is probably because you're not loading the frr-vrf module in some daemons, especially staticd (which implements the "vrf" command). |
rwestphal
reviewed
Mar 23, 2020
| length "1..16"; | ||
| } | ||
| /* yang version 0.16 having issue accessing leafref. */ | ||
| /* type frr-vrf:vrf-ref;*/ |
There was a problem hiding this comment.
This commit shouldn't be necessary if all daemons implement "frr-vrf" (as they should).
polychaeta
reviewed
Mar 23, 2020
There was a problem hiding this comment.
Thanks for your contribution to FRR!
Click for style suggestions
To apply these suggestions:
curl -s https://gist.githubusercontent.com/polychaeta/f30e3b09d969ae2137039906442f166a/raw/0d98ae21e9ee39e4034330de7f2f96aafc726e57/cr_5989_1584983098.diff | git apply
diff --git a/lib/yang.c b/lib/yang.c
index a0d1695c3..ce3a50b66 100644
--- a/lib/yang.c
+++ b/lib/yang.c
@@ -73,12 +73,8 @@ static const char *yang_module_imp_clb(const char *mod_name,
}
static const char *const frr_native_modules[] = {
- "frr-interface",
- "frr-vrf",
- "frr-ripd",
- "frr-ripngd",
- "frr-isisd",
- "frr-vrrpd",
+ "frr-interface", "frr-vrf", "frr-ripd",
+ "frr-ripngd", "frr-isisd", "frr-vrrpd",
};
/* Generate the yang_modules tree. */
If you are a new contributor to FRR, please see our contributing guidelines.
Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDTest incomplete. See below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: IncompleteTopology tests on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-11386/test Topology Tests failed for Topology tests on Ubuntu 18.04 amd64: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11386/artifact/TOPOU1804/ErrorLog/log_topotests.txt IPv6 protocols on Ubuntu 14.04: Failed (click for details)IPv4 ldp protocol on Ubuntu 16.04: Failed (click for details)Topology tests on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-11386/test Topology Tests failed for Topology tests on Ubuntu 18.04 amd64: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11386/artifact/TOPOU1804/ErrorLog/log_topotests.txt IPv6 protocols on Ubuntu 14.04: Failed (click for details)IPv4 ldp protocol on Ubuntu 16.04: Failed (click for details)Addresssanitizer topotest: Incomplete(check logs for details)Topology tests on Ubuntu 16.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-11386/test Topology Tests failed for Topology tests on Ubuntu 16.04 amd64: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11386/artifact/TOPOU1604/ErrorLog/log_topotests.txt IPv4 protocols on Ubuntu 14.04: Failed (click for details)CentOS 7 rpm pkg check: Failed (click for details)CentOS 7 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11386/artifact/CENTOS7RPM/ErrorLog/log_package_start.txt CentOS 7 rpm pkg check: No useful log foundTopotest tests on Ubuntu 16.04 i386: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-11386/test Topology Tests failed for Topotest tests on Ubuntu 16.04 i386: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11386/artifact/TOPOI386/ErrorLog/log_topotests.txt Successful on other platforms/tests
|
Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
Unable to access interface command: root@bharat:~/stash/libyang/build# dpkg-query -W | grep libyang libyang-dev 0.16.105-3~ubuntu18.04.1 libyang0.16 0.16.105-3~ubuntu18.04.1 root@bharat:~/stash/libyang/build# vtysh bharat# config t bharat(config)# interface lo % Configuration failed: validation error. Please check the logs for more details. Logfile: 2020/03/21 16:48:55 ZEBRA: libyang: Leafref "/frr-vrf:lib/frr-vrf:vrf/frr-vrf:name" of value "default" points to a non-existing leaf. (/frr-interface:lib/interface[name='lo'][vrf='default']/vrf) 2020/03/21 16:48:55 ZEBRA: [EC 100663337] nb_candidate_commit_prepare: failed to validate candidate configuration CI system failure: 2020/03/21 18:53:18 ZEBRA: libyang: Leafref "/frr-vrf:lib/frr-vrf:vrf/frr-vrf:name" of value "default" points to a non-existing leaf. (/frr-interface:lib/interface[name='r1-eth0'][vrf='default']/vrf) 2020/03/21 18:53:18 ZEBRA: [EC 100663337] nb_candidate_commit_prepare: failed to validate candidate configuration 2020/03/21 18:53:18 ZEBRA: libyang: Leafref "/frr-vrf:lib/frr-vrf:vrf/frr-vrf:name" of value "default" points to a non-existing leaf. (/frr-interface:lib/interface[name='r1-eth1'][vrf='default']/vrf) Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
polychaeta
reviewed
Mar 23, 2020
There was a problem hiding this comment.
Thanks for your contribution to FRR!
Click for style suggestions
To apply these suggestions:
curl -s https://gist.githubusercontent.com/polychaeta/783e660cc21916bdc79ca401c0f18cd9/raw/0d98ae21e9ee39e4034330de7f2f96aafc726e57/cr_5989_1585002522.diff | git apply
diff --git a/lib/yang.c b/lib/yang.c
index a0d1695c3..ce3a50b66 100644
--- a/lib/yang.c
+++ b/lib/yang.c
@@ -73,12 +73,8 @@ static const char *yang_module_imp_clb(const char *mod_name,
}
static const char *const frr_native_modules[] = {
- "frr-interface",
- "frr-vrf",
- "frr-ripd",
- "frr-ripngd",
- "frr-isisd",
- "frr-vrrpd",
+ "frr-interface", "frr-vrf", "frr-ripd",
+ "frr-ripngd", "frr-isisd", "frr-vrrpd",
};
/* Generate the yang_modules tree. */
If you are a new contributor to FRR, please see our contributing guidelines.
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedCentOS 7 rpm pkg check: Failed (click for details)CentOS 7 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11392/artifact/CENTOS7RPM/ErrorLog/log_package_start.txt CentOS 7 rpm pkg check: No useful log foundSuccessful on other platforms/tests
Warnings Generated during build:Checkout code: Successful with additional warningsCentOS 7 rpm pkg check: Failed (click for details)CentOS 7 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11392/artifact/CENTOS7RPM/ErrorLog/log_package_start.txt CentOS 7 rpm pkg check: No useful log foundWarnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedCentOS 7 rpm pkg check: Failed (click for details)CentOS 7 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11392/artifact/CENTOS7RPM/ErrorLog/log_package_start.txt CentOS 7 rpm pkg check: No useful log foundSuccessful on other platforms/tests
Warnings Generated during build:Checkout code: Successful with additional warningsCentOS 7 rpm pkg check: Failed (click for details)CentOS 7 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11392/artifact/CENTOS7RPM/ErrorLog/log_package_start.txt CentOS 7 rpm pkg check: No useful log foundWarnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: |
gcc 4 variable size array is not calcualated properely As an example, on Centos 7, yang module fails to load upon daemon start. Signed-off-by: chirag shah <chirag@cumulusnetworks.com>
polychaeta
reviewed
Mar 24, 2020
There was a problem hiding this comment.
Thanks for your contribution to FRR!
Click for style suggestions
To apply these suggestions:
curl -s https://gist.githubusercontent.com/polychaeta/3bed8e5136b45a8d9e0af63b150bb0c7/raw/0d98ae21e9ee39e4034330de7f2f96aafc726e57/cr_5989_1585082951.diff | git apply
diff --git a/lib/yang.c b/lib/yang.c
index a0d1695c3..ce3a50b66 100644
--- a/lib/yang.c
+++ b/lib/yang.c
@@ -73,12 +73,8 @@ static const char *yang_module_imp_clb(const char *mod_name,
}
static const char *const frr_native_modules[] = {
- "frr-interface",
- "frr-vrf",
- "frr-ripd",
- "frr-ripngd",
- "frr-isisd",
- "frr-vrrpd",
+ "frr-interface", "frr-vrf", "frr-ripd",
+ "frr-ripngd", "frr-isisd", "frr-vrrpd",
};
/* Generate the yang_modules tree. */
If you are a new contributor to FRR, please see our contributing guidelines.
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDTest incomplete. See below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: IncompleteTopology tests on Ubuntu 18.04 amd64: Incomplete(check logs for details)Successful on other platforms/tests
|
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11425/ This is a comment from an automated CI system. Warnings Generated during build:Checkout code: Successful with additional warningsWarnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: |
rwestphal
approved these changes
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains northbound callbacks for yang/frr-vrf.yang module.
{
"frr-vrf:lib": {
"vrf": [
{
"name": "default",
"id": 0,
"active": true
}
]
}
}
Signed-off-by: Chirag Shah chirag@cumulusnetworks.com