*: RIB operational northbound callbacks implementation #6250

chiragshah6 · 2020-04-17T06:17:48Z

e set of changes contain the RIB operational model northbound callbacks implementation.

Added zebra container to rib model and respective changes in northbound conversion callbacks.
Add macros to extract `first` and `next` route_entry from a given route node.
zebra northbound callbacks implementation

Signed-off-by: Chirag Shah chirag@cumulusnetworks.com

LabN-CI · 2020-04-17T06:46:38Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/6250 `14e8b7d`
Date	04/17/2020
Start	02:20:32
Finish	02:46:33
Run-Time	26:01
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-04-17-02:20:32.txt
Log	autoscript-2020-04-17-02:21:34.log.bz2
Memory	493 490 425

For details, please contact louberger

NetDEF-CI · 2020-04-17T07:49:04Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11925/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for zebra_nb.c | 8 issues
===============================================
< WARNING: line over 80 characters
< #631: FILE: /tmp/f1-24828/zebra_nb.c:631:
< WARNING: line over 80 characters
< #635: FILE: /tmp/f1-24828/zebra_nb.c:635:
< WARNING: line over 80 characters
< #637: FILE: /tmp/f1-24828/zebra_nb.c:637:
< WARNING: line over 80 characters
< #641: FILE: /tmp/f1-24828/zebra_nb.c:641:
Report for zebra_nb.h | 2 issues
===============================================
< WARNING: line over 80 characters
< #411: FILE: /tmp/f1-24828/zebra_nb.h:411:
Report for zebra_nb_state.c | 4 issues
===============================================
< WARNING: line over 80 characters
< #994: FILE: /tmp/f1-24828/zebra_nb_state.c:994:
< WARNING: line over 80 characters
< #997: FILE: /tmp/f1-24828/zebra_nb_state.c:997:

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11925/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200417-05-g14e8b7d61-0 (missing) -> 7.4-dev-20200417-05-g14e8b7d61-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200417-05-g14e8b7d61-0 (missing) -> 7.4-dev-20200417-05-g14e8b7d61-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200417-05-g14e8b7d61-0 (missing) -> 7.4-dev-20200417-05-g14e8b7d61-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200417-05-g14e8b7d61-0 (missing) -> 7.4-dev-20200417-05-g14e8b7d61-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200417-05-g14e8b7d61-0 (missing) -> 7.4-dev-20200417-05-g14e8b7d61-0~deb10u1

riw777

these look fine to me... would be good to have a second set of eyes here

zebra/zebra_nb_state.c

zebra/zebra_nb_config.c

zebra/zebra_nb_state.c

rwestphal · 2020-04-24T02:45:59Z

zebra/zebra_router.c

+	finder.ns_id = zvrf->zns->ns_id;
+	zrt = RB_FIND(zebra_router_table_head, &zrouter.tables, &finder);
+
+	return zrt;


nit: it would be nice if zebra_router_find_table() could use this function internally to avoid code duplication (they are both very similar).

LabN-CI · 2020-04-29T00:03:27Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/6250 `83ff831`
Date	04/28/2020
Start	19:37:30
Finish	20:03:21
Run-Time	25:51
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-04-28-19:37:30.txt
Log	autoscript-2020-04-28-19:38:27.log.bz2
Memory	445 461 425

For details, please contact louberger

NetDEF-CI · 2020-04-29T00:43:05Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12073/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for zebra_nb.c | 8 issues
===============================================
< WARNING: line over 80 characters
< #631: FILE: /tmp/f1-21775/zebra_nb.c:631:
< WARNING: line over 80 characters
< #635: FILE: /tmp/f1-21775/zebra_nb.c:635:
< WARNING: line over 80 characters
< #637: FILE: /tmp/f1-21775/zebra_nb.c:637:
< WARNING: line over 80 characters
< #641: FILE: /tmp/f1-21775/zebra_nb.c:641:
Report for zebra_nb.h | 2 issues
===============================================
< WARNING: line over 80 characters
< #323: FILE: /tmp/f1-21775/zebra_nb.h:323:
Report for zebra_nb_state.c | 18 issues
===============================================
< WARNING: Missing a blank line after declarations
< #267: FILE: /tmp/f1-21775/zebra_nb_state.c:267:
< WARNING: break is not useful after a goto or return
< #655: FILE: /tmp/f1-21775/zebra_nb_state.c:655:
< WARNING: break is not useful after a goto or return
< #658: FILE: /tmp/f1-21775/zebra_nb_state.c:658:
< WARNING: break is not useful after a goto or return
< #661: FILE: /tmp/f1-21775/zebra_nb_state.c:661:
< WARNING: break is not useful after a goto or return
< #664: FILE: /tmp/f1-21775/zebra_nb_state.c:664:
< WARNING: break is not useful after a goto or return
< #667: FILE: /tmp/f1-21775/zebra_nb_state.c:667:
< WARNING: line over 80 characters
< #691: FILE: /tmp/f1-21775/zebra_nb_state.c:691:
< WARNING: line over 80 characters
< #694: FILE: /tmp/f1-21775/zebra_nb_state.c:694:
< WARNING: break is not useful after a goto or return
< #717: FILE: /tmp/f1-21775/zebra_nb_state.c:717:

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12073/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200428-14-g83ff8316c-0 (missing) -> 7.4-dev-20200428-14-g83ff8316c-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200428-14-g83ff8316c-0 (missing) -> 7.4-dev-20200428-14-g83ff8316c-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200428-14-g83ff8316c-0 (missing) -> 7.4-dev-20200428-14-g83ff8316c-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200428-14-g83ff8316c-0 (missing) -> 7.4-dev-20200428-14-g83ff8316c-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200428-14-g83ff8316c-0 (missing) -> 7.4-dev-20200428-14-g83ff8316c-0~deb10u1

CLANG Static Analyzer Summary

Github Pull Request 6250, comparing to Git base SHA 4a6cd98
Base image data for Git 4a6cd98 does not exist - compare skipped

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12073/artifact/shared/static_analysis/index.html

LabN-CI · 2020-04-29T05:31:25Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/6250 `a3d311c`
Date	04/29/2020
Start	01:05:31
Finish	01:31:19
Run-Time	25:48
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-04-29-01:05:31.txt
Log	autoscript-2020-04-29-01:06:28.log.bz2
Memory	487 500 425

For details, please contact louberger

NetDEF-CI · 2020-04-29T06:36:55Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12075/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for zebra_nb.c | 8 issues
===============================================
< WARNING: line over 80 characters
< #631: FILE: /tmp/f1-16320/zebra_nb.c:631:
< WARNING: line over 80 characters
< #635: FILE: /tmp/f1-16320/zebra_nb.c:635:
< WARNING: line over 80 characters
< #637: FILE: /tmp/f1-16320/zebra_nb.c:637:
< WARNING: line over 80 characters
< #641: FILE: /tmp/f1-16320/zebra_nb.c:641:
Report for zebra_nb.h | 2 issues
===============================================
< WARNING: line over 80 characters
< #323: FILE: /tmp/f1-16320/zebra_nb.h:323:
Report for zebra_nb_state.c | 18 issues
===============================================
< WARNING: Missing a blank line after declarations
< #264: FILE: /tmp/f1-16320/zebra_nb_state.c:264:
< WARNING: break is not useful after a goto or return
< #652: FILE: /tmp/f1-16320/zebra_nb_state.c:652:
< WARNING: break is not useful after a goto or return
< #655: FILE: /tmp/f1-16320/zebra_nb_state.c:655:
< WARNING: break is not useful after a goto or return
< #658: FILE: /tmp/f1-16320/zebra_nb_state.c:658:
< WARNING: break is not useful after a goto or return
< #661: FILE: /tmp/f1-16320/zebra_nb_state.c:661:
< WARNING: break is not useful after a goto or return
< #664: FILE: /tmp/f1-16320/zebra_nb_state.c:664:
< WARNING: line over 80 characters
< #688: FILE: /tmp/f1-16320/zebra_nb_state.c:688:
< WARNING: line over 80 characters
< #691: FILE: /tmp/f1-16320/zebra_nb_state.c:691:
< WARNING: break is not useful after a goto or return
< #714: FILE: /tmp/f1-16320/zebra_nb_state.c:714:

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12075/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200429-03-ga3d311cee-0 (missing) -> 7.4-dev-20200429-03-ga3d311cee-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200429-03-ga3d311cee-0 (missing) -> 7.4-dev-20200429-03-ga3d311cee-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200429-03-ga3d311cee-0 (missing) -> 7.4-dev-20200429-03-ga3d311cee-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200429-03-ga3d311cee-0 (missing) -> 7.4-dev-20200429-03-ga3d311cee-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200429-03-ga3d311cee-0 (missing) -> 7.4-dev-20200429-03-ga3d311cee-0~deb10u1

CLANG Static Analyzer Summary

Github Pull Request 6250, comparing to Git base SHA 4a6cd98
Base image data for Git 4a6cd98 does not exist - compare skipped

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12075/artifact/shared/static_analysis/index.html

LabN-CI · 2020-05-11T16:56:26Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/6250 `9dc4502`
Date	05/11/2020
Start	12:30:30
Finish	12:56:20
Run-Time	25:50
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-05-11-12:30:30.txt
Log	autoscript-2020-05-11-12:31:27.log.bz2
Memory	498 495 424

For details, please contact louberger

NetDEF-CI · 2020-05-11T18:00:34Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12248/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for zebra_nb.c | 8 issues
===============================================
< WARNING: line over 80 characters
< #631: FILE: /tmp/f1-11778/zebra_nb.c:631:
< WARNING: line over 80 characters
< #635: FILE: /tmp/f1-11778/zebra_nb.c:635:
< WARNING: line over 80 characters
< #637: FILE: /tmp/f1-11778/zebra_nb.c:637:
< WARNING: line over 80 characters
< #641: FILE: /tmp/f1-11778/zebra_nb.c:641:
Report for zebra_nb.h | 2 issues
===============================================
< WARNING: line over 80 characters
< #323: FILE: /tmp/f1-11778/zebra_nb.h:323:
Report for zebra_nb_state.c | 18 issues
===============================================
< WARNING: Missing a blank line after declarations
< #264: FILE: /tmp/f1-11778/zebra_nb_state.c:264:
< WARNING: break is not useful after a goto or return
< #652: FILE: /tmp/f1-11778/zebra_nb_state.c:652:
< WARNING: break is not useful after a goto or return
< #655: FILE: /tmp/f1-11778/zebra_nb_state.c:655:
< WARNING: break is not useful after a goto or return
< #658: FILE: /tmp/f1-11778/zebra_nb_state.c:658:
< WARNING: break is not useful after a goto or return
< #661: FILE: /tmp/f1-11778/zebra_nb_state.c:661:
< WARNING: break is not useful after a goto or return
< #664: FILE: /tmp/f1-11778/zebra_nb_state.c:664:
< WARNING: line over 80 characters
< #688: FILE: /tmp/f1-11778/zebra_nb_state.c:688:
< WARNING: line over 80 characters
< #691: FILE: /tmp/f1-11778/zebra_nb_state.c:691:
< WARNING: break is not useful after a goto or return
< #714: FILE: /tmp/f1-11778/zebra_nb_state.c:714:

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12248/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200511-10-g9dc450238-0 (missing) -> 7.5-dev-20200511-10-g9dc450238-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200511-10-g9dc450238-0 (missing) -> 7.5-dev-20200511-10-g9dc450238-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200511-10-g9dc450238-0 (missing) -> 7.5-dev-20200511-10-g9dc450238-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200511-10-g9dc450238-0 (missing) -> 7.5-dev-20200511-10-g9dc450238-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200511-10-g9dc450238-0 (missing) -> 7.5-dev-20200511-10-g9dc450238-0~deb10u1

CLANG Static Analyzer Summary

Github Pull Request 6250, comparing to Git base SHA 420752a
Base image data for Git 420752a does not exist - compare skipped

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12248/artifact/shared/static_analysis/index.html

rwestphal

Thanks for the updates @chiragshah6! This is looking good now, I only have a few final review comments below.

zebra/zebra_nb_config.c

rwestphal · 2020-05-12T03:09:35Z

zebra/zebra_nb_state.c

+	struct vrf *vrf = (struct vrf *)args->parent_list_entry;
+	struct zebra_vrf *zvrf;
+	afi_t afi = AFI_IP;
+	safi_t safi = SAFI_UNICAST;


afi and safi must be taken from args->keys. Due to this bug I'm seeing some weird multicast routes when entering show yang operational-data /frr-vrf:lib :)

multicast routes are seen from table afi * safi multicast having connected routes.

zebra/zebra_nb_state.c

LabN-CI · 2020-05-12T07:36:25Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/6250 `0e5668f`
Date	05/12/2020
Start	03:10:30
Finish	03:36:19
Run-Time	25:49
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-05-12-03:10:30.txt
Log	autoscript-2020-05-12-03:11:26.log.bz2
Memory	500 482 426

For details, please contact louberger

NetDEF-CI · 2020-05-12T08:40:46Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12256/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for zebra_nb.c | 8 issues
===============================================
< WARNING: line over 80 characters
< #631: FILE: /tmp/f1-8003/zebra_nb.c:631:
< WARNING: line over 80 characters
< #635: FILE: /tmp/f1-8003/zebra_nb.c:635:
< WARNING: line over 80 characters
< #637: FILE: /tmp/f1-8003/zebra_nb.c:637:
< WARNING: line over 80 characters
< #641: FILE: /tmp/f1-8003/zebra_nb.c:641:
Report for zebra_nb.h | 2 issues
===============================================
< WARNING: line over 80 characters
< #323: FILE: /tmp/f1-8003/zebra_nb.h:323:
Report for zebra_nb_state.c | 16 issues
===============================================
< WARNING: break is not useful after a goto or return
< #664: FILE: /tmp/f1-8003/zebra_nb_state.c:664:
< WARNING: break is not useful after a goto or return
< #667: FILE: /tmp/f1-8003/zebra_nb_state.c:667:
< WARNING: break is not useful after a goto or return
< #670: FILE: /tmp/f1-8003/zebra_nb_state.c:670:
< WARNING: break is not useful after a goto or return
< #673: FILE: /tmp/f1-8003/zebra_nb_state.c:673:
< WARNING: break is not useful after a goto or return
< #676: FILE: /tmp/f1-8003/zebra_nb_state.c:676:
< WARNING: line over 80 characters
< #700: FILE: /tmp/f1-8003/zebra_nb_state.c:700:
< WARNING: line over 80 characters
< #703: FILE: /tmp/f1-8003/zebra_nb_state.c:703:
< WARNING: break is not useful after a goto or return
< #726: FILE: /tmp/f1-8003/zebra_nb_state.c:726:

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12256/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200512-06-g0e5668fe6-0 (missing) -> 7.5-dev-20200512-06-g0e5668fe6-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200512-06-g0e5668fe6-0 (missing) -> 7.5-dev-20200512-06-g0e5668fe6-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200512-06-g0e5668fe6-0 (missing) -> 7.5-dev-20200512-06-g0e5668fe6-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200512-06-g0e5668fe6-0 (missing) -> 7.5-dev-20200512-06-g0e5668fe6-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200512-06-g0e5668fe6-0 (missing) -> 7.5-dev-20200512-06-g0e5668fe6-0~deb10u1

CLANG Static Analyzer Summary

Github Pull Request 6250, comparing to Git base SHA 029ef88
Base image data for Git 029ef88 does not exist - compare skipped

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12256/artifact/shared/static_analysis/index.html

LabN-CI · 2020-05-12T19:26:28Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/6250 `92081ac`
Date	05/12/2020
Start	15:00:34
Finish	15:26:22
Run-Time	25:48
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-05-12-15:00:34.txt
Log	autoscript-2020-05-12-15:01:31.log.bz2
Memory	474 470 425

For details, please contact louberger

NetDEF-CI · 2020-05-12T20:05:55Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12265/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for zebra_nb.c | 8 issues
===============================================
< WARNING: line over 80 characters
< #631: FILE: /tmp/f1-15890/zebra_nb.c:631:
< WARNING: line over 80 characters
< #635: FILE: /tmp/f1-15890/zebra_nb.c:635:
< WARNING: line over 80 characters
< #637: FILE: /tmp/f1-15890/zebra_nb.c:637:
< WARNING: line over 80 characters
< #641: FILE: /tmp/f1-15890/zebra_nb.c:641:
Report for zebra_nb.h | 2 issues
===============================================
< WARNING: line over 80 characters
< #323: FILE: /tmp/f1-15890/zebra_nb.h:323:
Report for zebra_nb_state.c | 16 issues
===============================================
< WARNING: break is not useful after a goto or return
< #664: FILE: /tmp/f1-15890/zebra_nb_state.c:664:
< WARNING: break is not useful after a goto or return
< #667: FILE: /tmp/f1-15890/zebra_nb_state.c:667:
< WARNING: break is not useful after a goto or return
< #670: FILE: /tmp/f1-15890/zebra_nb_state.c:670:
< WARNING: break is not useful after a goto or return
< #673: FILE: /tmp/f1-15890/zebra_nb_state.c:673:
< WARNING: break is not useful after a goto or return
< #676: FILE: /tmp/f1-15890/zebra_nb_state.c:676:
< WARNING: line over 80 characters
< #700: FILE: /tmp/f1-15890/zebra_nb_state.c:700:
< WARNING: line over 80 characters
< #703: FILE: /tmp/f1-15890/zebra_nb_state.c:703:
< WARNING: break is not useful after a goto or return
< #726: FILE: /tmp/f1-15890/zebra_nb_state.c:726:

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12265/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200512-08-g92081acd1-0 (missing) -> 7.5-dev-20200512-08-g92081acd1-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200512-08-g92081acd1-0 (missing) -> 7.5-dev-20200512-08-g92081acd1-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200512-08-g92081acd1-0 (missing) -> 7.5-dev-20200512-08-g92081acd1-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200512-08-g92081acd1-0 (missing) -> 7.5-dev-20200512-08-g92081acd1-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200512-08-g92081acd1-0 (missing) -> 7.5-dev-20200512-08-g92081acd1-0~deb10u1

CLANG Static Analyzer Summary

Github Pull Request 6250, comparing to Git base SHA 02b89bd
Base image data for Git 02b89bd does not exist - compare skipped

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12265/artifact/shared/static_analysis/index.html

This commit implements: RIB operational list create/destroy. Walk over RIB tables using keys. The first RIB table will be IPV4/unicast (table-id 254) will be fetched. Create a new api to fetch RIB table based on afi-safi and table id as the keys. remove mandatory true statement from the leaf which is part of the list key. Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>

Add zebra container in rib tree. When displaying RIB under vrf, it displays zebra module name. Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>

Add macros for route entry first and next node walk. Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>

Helper APIs to convert afi-safi identity to values. Signed-off-by: Renato Westphal <renato@opensourcerouting.org> Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>

rwestphal

LGTM. I'll merge once CI finishes.

- add RIB's northbound list create/destory callback changes. - add RIB's northbound callbacks implementation. - add RIB's nexthop callbacks implementation. - add RIB's nexthop weight field callback changes. Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>

Add v4/v6 unified protocol list to rib operational model. Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>

Align leafs according to keys order. Fix some of the nits seen in yanglint -f yang format. Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>

LabN-CI · 2020-05-12T21:56:39Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/6250 `482692f`
Date	05/12/2020
Start	17:30:32
Finish	17:56:33
Run-Time	26:01
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-05-12-17:30:32.txt
Log	autoscript-2020-05-12-17:31:31.log.bz2
Memory	496 498 425

For details, please contact louberger

LabN-CI · 2020-05-12T22:26:39Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/6250 `00ebe5b`
Date	05/12/2020
Start	18:00:34
Finish	18:26:33
Run-Time	25:59
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-05-12-18:00:34.txt
Log	autoscript-2020-05-12-18:01:31.log.bz2
Memory	492 500 429

For details, please contact louberger

NetDEF-CI · 2020-05-13T00:08:52Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12271/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for zebra_nb.c | 8 issues
===============================================
< WARNING: line over 80 characters
< #665: FILE: /tmp/f1-10964/zebra_nb.c:665:
< WARNING: line over 80 characters
< #669: FILE: /tmp/f1-10964/zebra_nb.c:669:
< WARNING: line over 80 characters
< #671: FILE: /tmp/f1-10964/zebra_nb.c:671:
< WARNING: line over 80 characters
< #675: FILE: /tmp/f1-10964/zebra_nb.c:675:
Report for zebra_nb.h | 2 issues
===============================================
< WARNING: line over 80 characters
< #327: FILE: /tmp/f1-10964/zebra_nb.h:327:
Report for zebra_nb_state.c | 16 issues
===============================================
< WARNING: break is not useful after a goto or return
< #637: FILE: /tmp/f1-10964/zebra_nb_state.c:637:
< WARNING: break is not useful after a goto or return
< #640: FILE: /tmp/f1-10964/zebra_nb_state.c:640:
< WARNING: break is not useful after a goto or return
< #643: FILE: /tmp/f1-10964/zebra_nb_state.c:643:
< WARNING: break is not useful after a goto or return
< #646: FILE: /tmp/f1-10964/zebra_nb_state.c:646:
< WARNING: break is not useful after a goto or return
< #649: FILE: /tmp/f1-10964/zebra_nb_state.c:649:
< WARNING: line over 80 characters
< #673: FILE: /tmp/f1-10964/zebra_nb_state.c:673:
< WARNING: line over 80 characters
< #676: FILE: /tmp/f1-10964/zebra_nb_state.c:676:
< WARNING: break is not useful after a goto or return
< #699: FILE: /tmp/f1-10964/zebra_nb_state.c:699:

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12271/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200512-09-g00ebe5b5f-0 (missing) -> 7.5-dev-20200512-09-g00ebe5b5f-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200512-09-g00ebe5b5f-0 (missing) -> 7.5-dev-20200512-09-g00ebe5b5f-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200512-09-g00ebe5b5f-0 (missing) -> 7.5-dev-20200512-09-g00ebe5b5f-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200512-09-g00ebe5b5f-0 (missing) -> 7.5-dev-20200512-09-g00ebe5b5f-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200512-09-g00ebe5b5f-0 (missing) -> 7.5-dev-20200512-09-g00ebe5b5f-0~deb10u1

CLANG Static Analyzer Summary

Github Pull Request 6250, comparing to Git base SHA 02b89bd
Base image data for Git 02b89bd does not exist - compare skipped

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12271/artifact/shared/static_analysis/index.html

polychaeta added the zebra label Apr 17, 2020

Spantik self-requested a review April 20, 2020 15:07

riw777 self-requested a review April 21, 2020 14:52

riw777 approved these changes Apr 21, 2020

View reviewed changes

chiragshah6 mentioned this pull request Apr 22, 2020

*: RIB operational northbound callbacks implementation #6172

Closed

rwestphal requested changes Apr 24, 2020

View reviewed changes

chiragshah6 force-pushed the yang_nb6 branch from 14e8b7d to 83ff831 Compare April 28, 2020 23:12

polychaeta added the yang label Apr 28, 2020

chiragshah6 requested a review from rwestphal April 28, 2020 23:13

chiragshah6 force-pushed the yang_nb6 branch from 83ff831 to a3d311c Compare April 29, 2020 05:00

chiragshah6 force-pushed the yang_nb6 branch from a3d311c to 9dc4502 Compare May 11, 2020 16:28

rwestphal reviewed May 12, 2020

View reviewed changes

chiragshah6 force-pushed the yang_nb6 branch from 9dc4502 to 0e5668f Compare May 12, 2020 07:08

chiragshah6 force-pushed the yang_nb6 branch from 0e5668f to 92081ac Compare May 12, 2020 18:32

chiragshah6 force-pushed the yang_nb6 branch from 92081ac to 482692f Compare May 12, 2020 21:29

chiragshah6 added 2 commits May 12, 2020 14:31

zebra: add zebra container to rib model

56a88b9

Add zebra container in rib tree. When displaying RIB under vrf, it displays zebra module name. Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>

zebra: route node first next node

db85668

Add macros for route entry first and next node walk. Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>

zebra: afi-safi identity to value apis

77f4028

Helper APIs to convert afi-safi identity to values. Signed-off-by: Renato Westphal <renato@opensourcerouting.org> Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>

chiragshah6 force-pushed the yang_nb6 branch from 482692f to 54a2eb6 Compare May 12, 2020 21:36

rwestphal approved these changes May 12, 2020

View reviewed changes

chiragshah6 added 3 commits May 12, 2020 14:51

yang: add unified protocol types in rib model

748a972

Add v4/v6 unified protocol list to rib operational model. Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>

yang: align keys and leafs

00ebe5b

Align leafs according to keys order. Fix some of the nits seen in yanglint -f yang format. Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>

chiragshah6 force-pushed the yang_nb6 branch from 54a2eb6 to 00ebe5b Compare May 12, 2020 21:53

rwestphal merged commit a10f92e into FRRouting:master May 13, 2020

*: RIB operational northbound callbacks implementation #6250

*: RIB operational northbound callbacks implementation #6250

Conversation

chiragshah6 commented Apr 17, 2020

LabN-CI commented Apr 17, 2020 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Apr 17, 2020 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

Warnings Generated during build:

riw777 left a comment

Choose a reason for hiding this comment

rwestphal Apr 24, 2020

Choose a reason for hiding this comment

LabN-CI commented Apr 29, 2020 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Apr 29, 2020 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

Warnings Generated during build:

CLANG Static Analyzer Summary

1 Static Analyzer issues remaining.

LabN-CI commented Apr 29, 2020 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Apr 29, 2020 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

Warnings Generated during build:

CLANG Static Analyzer Summary

1 Static Analyzer issues remaining.

LabN-CI commented May 11, 2020 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented May 11, 2020 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

Warnings Generated during build:

CLANG Static Analyzer Summary

1 Static Analyzer issues remaining.

rwestphal left a comment

Choose a reason for hiding this comment

rwestphal May 12, 2020

Choose a reason for hiding this comment

chiragshah6 May 12, 2020

Choose a reason for hiding this comment

LabN-CI commented May 12, 2020 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented May 12, 2020 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

Warnings Generated during build:

CLANG Static Analyzer Summary

1 Static Analyzer issues remaining.

LabN-CI commented May 12, 2020 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented May 12, 2020 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

Warnings Generated during build:

CLANG Static Analyzer Summary

1 Static Analyzer issues remaining.

rwestphal left a comment

Choose a reason for hiding this comment

LabN-CI commented May 12, 2020 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

LabN-CI commented May 12, 2020

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented May 13, 2020

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

Warnings Generated during build:

CLANG Static Analyzer Summary

1 Static Analyzer issues remaining.

LabN-CI commented Apr 17, 2020 •

edited

Loading

NetDEF-CI commented Apr 17, 2020 •

edited

Loading

LabN-CI commented Apr 29, 2020 •

edited

Loading

NetDEF-CI commented Apr 29, 2020 •

edited

Loading

LabN-CI commented Apr 29, 2020 •

edited

Loading

NetDEF-CI commented Apr 29, 2020 •

edited

Loading

LabN-CI commented May 11, 2020 •

edited

Loading

NetDEF-CI commented May 11, 2020 •

edited

Loading

LabN-CI commented May 12, 2020 •

edited

Loading

NetDEF-CI commented May 12, 2020 •

edited

Loading

LabN-CI commented May 12, 2020 •

edited

Loading

NetDEF-CI commented May 12, 2020 •

edited

Loading

LabN-CI commented May 12, 2020 •

edited

Loading