tests: iproute2 VRF capability check for topotests #8253

davischw · 2021-03-15T12:05:37Z

On older releases of certain distributions (i.e. Ubuntu 16.04 LTS) the iproute2 utility does not have support for VRFs. This can lead to test failures on systems with backported kernels (Ubuntu HWE, Debian backports, etc.), since the tests are skipped solely based on kernel versions. This PR introduces a check for VRF handling capabilities on the iproute2 utility present in the PATH and example applications in the bgp_multi_vrf_topo1 and bgp_multi_vrf_topo2 topotests.

Signed-off-by: David Schweizer <dschweizer@opensourcerouting.org>

Example usage of iproute2_is_vrf_capable check in bgp_multi_vrf_topo1 and bgp_multi_vrf_topo2 topotests. Signed-off-by: David Schweizer <dschweizer@opensourcerouting.org>

polychaeta

Thanks for your contribution to FRR!

Pylint found errors in source files changed by this PR:

Pylint report for my_frr/tests/topotests/bgp_multi_vrf_topo1/test_bgp_multi_vrf_topo1.py:
************* Module test_bgp_multi_vrf_topo1
my_frr/tests/topotests/bgp_multi_vrf_topo1/test_bgp_multi_vrf_topo1.py:2677:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_multi_vrf_topo1/test_bgp_multi_vrf_topo1.py:2683:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_multi_vrf_topo1/test_bgp_multi_vrf_topo1.py:4958:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_multi_vrf_topo1/test_bgp_multi_vrf_topo1.py:5170:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_multi_vrf_topo1/test_bgp_multi_vrf_topo1.py:5449:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_multi_vrf_topo1/test_bgp_multi_vrf_topo1.py:5853:8: E1305: Too many arguments for format string (too-many-format-args)

-----------------------------------
Your code has been rated at 9.73/10



Pylint report for my_frr/tests/topotests/bgp_multi_vrf_topo2/test_bgp_multi_vrf_topo2.py:
************* Module test_bgp_multi_vrf_topo2
my_frr/tests/topotests/bgp_multi_vrf_topo2/test_bgp_multi_vrf_topo2.py:1572:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_multi_vrf_topo2/test_bgp_multi_vrf_topo2.py:1617:12: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_multi_vrf_topo2/test_bgp_multi_vrf_topo2.py:1622:12: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_multi_vrf_topo2/test_bgp_multi_vrf_topo2.py:1862:12: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_multi_vrf_topo2/test_bgp_multi_vrf_topo2.py:2179:27: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_multi_vrf_topo2/test_bgp_multi_vrf_topo2.py:3388:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_multi_vrf_topo2/test_bgp_multi_vrf_topo2.py:3394:8: E1305: Too many arguments for format string (too-many-format-args)

-----------------------------------
Your code has been rated at 9.58/10



Pylint report for my_frr/tests/topotests/lib/topotest.py:
************* Module lib.topotest
my_frr/tests/topotests/lib/topotest.py:1889:15: E0602: Undefined variable 'unicode' (undefined-variable)

-----------------------------------
Your code has been rated at 9.95/10

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

NetDEF-CI · 2021-03-15T15:26:46Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17658/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 arm8 part 7: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 7: No useful log found

Successful on other platforms/tests

Topotests Ubuntu 16.04 amd64 part 7
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 amd64 part 9
Topotests Ubuntu 18.04 arm8 part 3
Fedora 29 rpm pkg check
Topotests Ubuntu 16.04 amd64 part 4
Topotests Ubuntu 16.04 amd64 part 3
Addresssanitizer topotests part 7
Addresssanitizer topotests part 4
Topotests Ubuntu 16.04 i386 part 5
Addresssanitizer topotests part 5
Static analyzer (clang)
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 16.04 i386 part 9
Topotests Ubuntu 18.04 amd64 part 6
Ubuntu 16.04 deb pkg check
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 arm8 part 5
Topotests Ubuntu 18.04 amd64 part 1
Ubuntu 18.04 deb pkg check
Topotests Ubuntu 16.04 amd64 part 2
CentOS 7 rpm pkg check
Topotests Ubuntu 16.04 i386 part 7
Topotests Ubuntu 18.04 amd64 part 2
Addresssanitizer topotests part 0
IPv6 protocols on Ubuntu 18.04
Topotests Ubuntu 16.04 amd64 part 6
Topotests Ubuntu 16.04 i386 part 8
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 16.04 amd64 part 1
Topotests Ubuntu 16.04 amd64 part 8
Debian 8 deb pkg check
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 18.04 arm8 part 8
Topotests Ubuntu 16.04 amd64 part 0
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 arm8 part 6
IPv4 protocols on Ubuntu 18.04
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 16.04 i386 part 2
Topotests Ubuntu 16.04 i386 part 4
Topotests Ubuntu 16.04 i386 part 1
Addresssanitizer topotests part 6
Topotests Ubuntu 16.04 amd64 part 5
Topotests Ubuntu 16.04 i386 part 6
Topotests Ubuntu 18.04 arm8 part 4
IPv4 ldp protocol on Ubuntu 18.04
Ubuntu 20.04 deb pkg check
Addresssanitizer topotests part 2
Debian 9 deb pkg check
Topotests Ubuntu 18.04 arm8 part 9
Topotests Ubuntu 16.04 amd64 part 9
Debian 10 deb pkg check
Topotests Ubuntu 16.04 i386 part 0
Topotests Ubuntu 18.04 amd64 part 8
Topotests Ubuntu 16.04 i386 part 3

LabN-CI · 2021-03-15T17:18:43Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/8253 `2b2d1a9`
Date	03/15/2021
Start	12:39:08
Finish	13:18:40
Run-Time	39:32
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2021-03-15-12:39:08.txt
Log	autoscript-2021-03-15-12:40:16.log.bz2
Memory	492 486 430

For details, please contact louberger

Additional example usage of iproute2_is_vrf_capable check in isis-topo1-vrf topotest. Signed-off-by: David Schweizer <dschweizer@opensourcerouting.org>

polychaeta

Thanks for your contribution to FRR!

Pylint found errors in source files changed by this PR:

Pylint report for my_frr/tests/topotests/bgp_multi_vrf_topo1/test_bgp_multi_vrf_topo1.py:
************* Module test_bgp_multi_vrf_topo1
my_frr/tests/topotests/bgp_multi_vrf_topo1/test_bgp_multi_vrf_topo1.py:2677:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_multi_vrf_topo1/test_bgp_multi_vrf_topo1.py:2683:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_multi_vrf_topo1/test_bgp_multi_vrf_topo1.py:4958:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_multi_vrf_topo1/test_bgp_multi_vrf_topo1.py:5170:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_multi_vrf_topo1/test_bgp_multi_vrf_topo1.py:5449:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_multi_vrf_topo1/test_bgp_multi_vrf_topo1.py:5853:8: E1305: Too many arguments for format string (too-many-format-args)

-----------------------------------
Your code has been rated at 9.73/10



Pylint report for my_frr/tests/topotests/bgp_multi_vrf_topo2/test_bgp_multi_vrf_topo2.py:
************* Module test_bgp_multi_vrf_topo2
my_frr/tests/topotests/bgp_multi_vrf_topo2/test_bgp_multi_vrf_topo2.py:1572:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_multi_vrf_topo2/test_bgp_multi_vrf_topo2.py:1617:12: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_multi_vrf_topo2/test_bgp_multi_vrf_topo2.py:1622:12: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_multi_vrf_topo2/test_bgp_multi_vrf_topo2.py:1862:12: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_multi_vrf_topo2/test_bgp_multi_vrf_topo2.py:2179:27: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_multi_vrf_topo2/test_bgp_multi_vrf_topo2.py:3388:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_multi_vrf_topo2/test_bgp_multi_vrf_topo2.py:3394:8: E1305: Too many arguments for format string (too-many-format-args)

-----------------------------------
Your code has been rated at 9.58/10



Pylint report for my_frr/tests/topotests/lib/topotest.py:
************* Module lib.topotest
my_frr/tests/topotests/lib/topotest.py:1889:15: E0602: Undefined variable 'unicode' (undefined-variable)

-----------------------------------
Your code has been rated at 9.95/10

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

LabN-CI · 2021-03-16T11:09:47Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/8253 `0b04146`
Date	03/16/2021
Start	06:30:07
Finish	07:09:43
Run-Time	39:36
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2021-03-16-06:30:07.txt
Log	autoscript-2021-03-16-06:31:14.log.bz2
Memory	496 507 430

For details, please contact louberger

NetDEF-CI · 2021-03-16T12:26:36Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17693/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 arm8 part 4: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 4: No useful log found

Topotests Ubuntu 16.04 amd64 part 7: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO7U16AMD64-17693/test

Topology Tests failed for Topotests Ubuntu 16.04 amd64 part 7:

2021-03-16 10:14:01,960 ERROR: 'router_json_cmp' failed after 112.36 seconds
2021-03-16 10:14:01,962 ERROR: assert failed at "test_isis_snmp/test_isis_convergence": "r1" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->frr-interface:lib->interface: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "state": {
  	        "frr-isisd:isis": {
  	            "adjacencies": {
  	                "adjacency": [
  	                    {
  	                        "neighbor-extended-circuit-id": 2,
  	                        "neighbor-sys-type": "level-1",
  	                        "state": "up",
  	                        "neighbor-sysid": "0000.0000.0004"
  	                    }
  	                ]
  	            }
  	        }
  	    },
  	    "name": "r1-eth0",
  	    "vrf": "default"
  	}
  
  	Closest match in d1 is at index 4 with the following errors: 
  
  	> $->frr-interface:lib->interface[4]->state->frr-isisd:isis->adjacencies->adjacency: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "neighbor-extended-circuit-id": 2,
  		    "neighbor-sys-type": "level-1",
  		    "state": "up",
  		    "neighbor-sysid": "0000.0000.0004"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->frr-interface:lib->interface[4]->state->frr-isisd:isis->adjacencies->adjacency[0]->neighbor-extended-circuit-id: d1 has element with value '5' but in d2 it has value '2'
  	
  
2021-03-16 10:14:04,081 ERROR: assert failed at "test_isis_snmp/test_r1_isisCircTable": isisCircIfIndex should be ['2', '3', '1'] oids ['1', '2', '3'] full dict ({'1': '5', '3': '1', '2': '6'}, ['5', '6', '1']):
assert False
 +  where False = <bound method SnmpTester.test_oid_walk of <lib.snmptest.SnmpTester object at 0x7fbfb08e2890>>('isisCircIfIndex', ['2', '3', '1'], ['1', '2', '3'])
 +    where <bound method SnmpTester.test_oid_walk of <lib.snmptest.SnmpTester object at 0x7fbfb08e2890>> = <lib.snmptest.SnmpTester object at 0x7fbfb08e2890>.test_oid_walk
2021-03-16 10:14:04,995 ERROR: assert failed at "test_isis_snmp/test_r1_isislevelCircTable": isisCircLevelIDOctet should be ['2', '0', '0', '0'] oids ['1.area', '2.area', '3.area', '3.domain'] full dict ({'1.area': '5', '3.area': '0', '3.domain': '0', '2.area': '0'}, ['5', '0', '0', '0']):
assert False
 +  where False = <bound method SnmpTester.test_oid_walk of <lib.snmptest.SnmpTester object at 0x7fbfb097b190>>('isisCircLevelIDOctet', ['2', '0', '0', '0'], ['1.area', '2.area', '3.area', '3.domain'])
 +    where <bound method SnmpTester.test_oid_walk of <lib.snmptest.SnmpTester object at 0x7fbfb097b190>> = <lib.snmptest.SnmpTester object at 0x7fbfb097b190>.test_oid_walk
2021-03-16 10:23:13,954 WARNING: ['Area 1:', ' Interface: r1-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.1.1/24', ' IPv6 Link-Locals:', ' fe80::ccae:f4ff:fe8d:c002/64', '', ' Interface: r1-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.2.1/24', ' IPv6 Link-Locals:', ' fe80::d8b0:22ff:fe32:eefe/64']
2021-03-16 10:23:13,954 WARNING: {'1': {'r1-eth1': [{'metric': '10', 'level': 'Level-1'}], 'r1-eth2': [{'metric': '10', 'level': 'Level-1'}]}}
2021-03-16 10:23:14,134 WARNING: ['Area 1:', ' Interface: r2-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.1.2/24', ' IPv6 Link-Locals:', ' fe80::94fd:bfff:fec7:d8e4/64', '', ' Interface: r2-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.3.2/24', ' IPv6 Link-Locals:', ' fe80::40b4:9cff:fe63:8244/64']
2021-03-16 10:23:14,134 WARNING: {'1': {'r2-eth1': [{'metric': '10', 'level': 'Level-1'}], 'r2-eth2': [{'metric': '10', 'level': 'Level-1'}]}}
2021-03-16 10:23:14,294 WARNING: ['Area 1:', ' Interface: r3-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.2.3/24', ' IPv6 Link-Locals:', ' fe80::c889:7eff:fef4:298f/64', '', ' Interface: r3-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.3.3/24', ' IPv6 Link-Locals:', ' fe80::ac06:94ff:fec4:781b/64']
2021-03-16 10:23:14,295 WARNING: {'1': {'r3-eth2': [{'metric': '10', 'level': 'Level-1'}], 'r3-eth1': [{'metric': '10', 'level': 'Level-1'}]}}
2021-03-16 10:23:27,478 WARNING: ['Area 1:', ' Interface: r1-eth1, State: Config, Active, Circuit Id: 0x0', ' Type: Unknown, Level: L1', ' Level-1 Information:', ' Metric: 16777214, Active neighbors: 0', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', '', ' Interface: r1-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.2.1/24', ' IPv6 Link-Locals:', ' fe80::d8b0:22ff:fe32:eefe/64']
2021-03-16 10:23:27,478 WARNING: {'1': {'r1-eth1': [{'metric': '16777214', 'level': 'Level-1'}], 'r1-eth2': [{'metric': '10', 'level': 'Level-1'}]}}
2021-03-16 10:23:27,709 WARNING: ['Area 1:', ' Interface: r2-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 16777214, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.1.2/24', ' IPv6 Link-Locals:', ' fe80::94fd:bfff:fec7:d8e4/64', '', ' Interface: r2-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.3.2/24', ' IPv6 Link-Locals:', ' fe80::40b4:9cff:fe63:8244/64']
2021-03-16 10:23:27,709 WARNING: {'1': {'r2-eth1': [{'metric': '16777214', 'level': 'Level-1'}], 'r2-eth2': [{'metric': '10', 'level': 'Level-1'}]}}
2021-03-16 10:23:27,857 WARNING: ['Area 1:', ' Interface: r3-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.2.3/24', ' IPv6 Link-Locals:', ' fe80::c889:7eff:fef4:298f/64', '', ' Interface: r3-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.3.3/24', ' IPv6 Link-Locals:', ' fe80::ac06:94ff:fec4:781b/64']
2021-03-16 10:23:27,857 WARNING: {'1': {'r3-eth2': [{'metric': '10', 'level': 'Level-1'}], 'r3-eth1': [{'metric': '10', 'level': 'Level-1'}]}}
2021-03-16 10:23:43,508 WARNING: ['Area 1:', ' Interface: r1-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.1.1/24', ' IPv6 Link-Locals:', ' fe80::ccae:f4ff:fe8d:c002/64', '', ' Interface: r1-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.2.1/24', ' IPv6 Link-Locals:', ' fe80::d8b0:22ff:fe32:eefe/64']
2021-03-16 10:23:43,508 WARNING: {'1': {'r1-eth1': [{'metric': '10', 'level': 'Level-1'}], 'r1-eth2': [{'metric': '10', 'level': 'Level-1'}]}}
2021-03-16 10:23:43,655 WARNING: ['Area 1:', ' Interface: r2-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.1.2/24', ' IPv6 Link-Locals:', ' fe80::94fd:bfff:fec7:d8e4/64', '', ' Interface: r2-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.3.2/24', ' IPv6 Link-Locals:', ' fe80::40b4:9cff:fe63:8244/64']
2021-03-16 10:23:43,655 WARNING: {'1': {'r2-eth1': [{'metric': '10', 'level': 'Level-1'}], 'r2-eth2': [{'metric': '10', 'level': 'Level-1'}]}}
2021-03-16 10:23:43,795 WARNING: ['Area 1:', ' Interface: r3-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.2.3/24', ' IPv6 Link-Locals:', ' fe80::c889:7eff:fef4:298f/64', '', ' Interface: r3-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.3.3/24', ' IPv6 Link-Locals:', ' fe80::ac06:94ff:fec4:781b/64']
2021-03-16 10:23:43,795 WARNING: {'1': {'r3-eth2': [{'metric': '10', 'level': 'Level-1'}], 'r3-eth1': [{'metric': '10', 'level': 'Level-1'}]}}
2021-03-16 10:23:58,630 WARNING: ['Area 1:', ' Interface: r1-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 16777214, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.1.1/24', ' IPv6 Link-Locals:', ' fe80::ccae:f4ff:fe8d:c002/64', '', ' Interface: r1-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.2.1/24', ' IPv6 Link-Locals:', ' fe80::d8b0:22ff:fe32:eefe/64']
2021-03-16 10:23:58,631 WARNING: {'1': {'r1-eth1': [{'metric': '16777214', 'level': 'Level-1'}], 'r1-eth2': [{'metric': '10', 'level': 'Level-1'}]}}
2021-03-16 10:23:58,788 WARNING: ['Area 1:', ' Interface: r2-eth1, State: Config, Active, Circuit Id: 0x0', ' Type: Unknown, Level: L1', ' Level-1 Information:', ' Metric: 16777214, Active neighbors: 0', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', '', ' Interface: r2-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.3.2/24', ' IPv6 Link-Locals:', ' fe80::40b4:9cff:fe63:8244/64']
2021-03-16 10:23:58,788 WARNING: {'1': {'r2-eth1': [{'metric': '16777214', 'level': 'Level-1'}], 'r2-eth2': [{'metric': '10', 'level': 'Level-1'}]}}
2021-03-16 10:23:58,946 WARNING: ['Area 1:', ' Interface: r3-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.2.3/24', ' IPv6 Link-Locals:', ' fe80::c889:7eff:fef4:298f/64', '', ' Interface: r3-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.3.3/24', ' IPv6 Link-Locals:', ' fe80::ac06:94ff:fec4:781b/64']
2021-03-16 10:23:58,947 WARNING: {'1': {'r3-eth2': [{'metric': '10', 'level': 'Level-1'}], 'r3-eth1': [{'metric': '10', 'level': 'Level-1'}]}}
2021-03-16 10:24:15,384 WARNING: ['Area 1:', ' Interface: r1-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.1.1/24', ' IPv6 Link-Locals:', ' fe80::ccae:f4ff:fe8d:c002/64', '', ' Interface: r1-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.2.1/24', ' IPv6 Link-Locals:', ' fe80::d8b0:22ff:fe32:eefe/64']
2021-03-16 10:24:15,385 WARNING: {'1': {'r1-eth1': [{'metric': '10', 'level': 'Level-1'}], 'r1-eth2': [{'metric': '10', 'level': 'Level-1'}]}}
2021-03-16 10:24:15,648 WARNING: ['Area 1:', ' Interface: r2-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.1.2/24', ' IPv6 Link-Locals:', ' fe80::94fd:bfff:fec7:d8e4/64', '', ' Interface: r2-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.3.2/24', ' IPv6 Link-Locals:', ' fe80::40b4:9cff:fe63:8244/64']
2021-03-16 10:24:15,648 WARNING: {'1': {'r2-eth1': [{'metric': '10', 'level': 'Level-1'}], 'r2-eth2': [{'metric': '10', 'level': 'Level-1'}]}}
2021-03-16 10:24:15,788 WARNING: ['Area 1:', ' Interface: r3-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.2.3/24', ' IPv6 Link-Locals:', ' fe80::c889:7eff:fef4:298f/64', '', ' Interface: r3-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.3.3/24', ' IPv6 Link-Locals:', ' fe80::ac06:94ff:fec4:781b/64']
2021-03-16 10:24:15,788 WARNING: {'1': {'r3-eth2': [{'metric': '10', 'level': 'Level-1'}], 'r3-eth1': [{'metric': '10', 'level': 'Level-1'}]}}

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17693/artifact/TOPO7U16AMD64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 amd64 part 7: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO7U18AMD64-17693/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 7:

2021-03-16 09:15:12,874 ERROR: 'router_json_cmp' failed after 113.19 seconds
2021-03-16 09:15:12,878 ERROR: assert failed at "test_isis_snmp/test_isis_convergence": "r1" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->frr-interface:lib->interface: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "state": {
  	        "frr-isisd:isis": {
  	            "adjacencies": {
  	                "adjacency": [
  	                    {
  	                        "neighbor-extended-circuit-id": 2,
  	                        "neighbor-sys-type": "level-1",
  	                        "state": "up",
  	                        "neighbor-sysid": "0000.0000.0004"
  	                    }
  	                ]
  	            }
  	        }
  	    },
  	    "name": "r1-eth0",
  	    "vrf": "default"
  	}
  
  	Closest match in d1 is at index 4 with the following errors: 
  
  	> $->frr-interface:lib->interface[4]->state->frr-isisd:isis->adjacencies->adjacency: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "neighbor-extended-circuit-id": 2,
  		    "neighbor-sys-type": "level-1",
  		    "state": "up",
  		    "neighbor-sysid": "0000.0000.0004"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->frr-interface:lib->interface[4]->state->frr-isisd:isis->adjacencies->adjacency[0]->neighbor-extended-circuit-id: d1 has element with value '5' but in d2 it has value '2'
  	
  
2021-03-16 09:15:15,544 ERROR: assert failed at "test_isis_snmp/test_r1_isisCircTable": isisCircIfIndex should be ['2', '3', '1'] oids ['1', '2', '3'] full dict ({'1': '5', '3': '1', '2': '6'}, ['5', '6', '1']):
assert False
 +  where False = <bound method SnmpTester.test_oid_walk of <lib.snmptest.SnmpTester object at 0x7ff462909810>>('isisCircIfIndex', ['2', '3', '1'], ['1', '2', '3'])
 +    where <bound method SnmpTester.test_oid_walk of <lib.snmptest.SnmpTester object at 0x7ff462909810>> = <lib.snmptest.SnmpTester object at 0x7ff462909810>.test_oid_walk
2021-03-16 09:15:16,672 ERROR: assert failed at "test_isis_snmp/test_r1_isislevelCircTable": isisCircLevelIDOctet should be ['2', '0', '0', '0'] oids ['1.area', '2.area', '3.area', '3.domain'] full dict ({'1.area': '5', '3.area': '0', '3.domain': '0', '2.area': '0'}, ['5', '0', '0', '0']):
assert False
 +  where False = <bound method SnmpTester.test_oid_walk of <lib.snmptest.SnmpTester object at 0x7ff462da3390>>('isisCircLevelIDOctet', ['2', '0', '0', '0'], ['1.area', '2.area', '3.area', '3.domain'])
 +    where <bound method SnmpTester.test_oid_walk of <lib.snmptest.SnmpTester object at 0x7ff462da3390>> = <lib.snmptest.SnmpTester object at 0x7ff462da3390>.test_oid_walk
2021-03-16 09:15:25,326 ERROR: r3: isisd left a dead pidfile (pid=23139)
2021-03-16 09:19:37,516 ERROR: rt4: zebra left a dead pidfile (pid=28046)
2021-03-16 09:22:59,438 ERROR: r4: zebra left a dead pidfile (pid=4961)
2021-03-16 09:24:59,982 WARNING: ['Area 1:', ' Interface: r1-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.1.1/24', ' IPv6 Link-Locals:', ' fe80::3c75:34ff:fef7:81fd/64', '', ' Interface: r1-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.2.1/24', ' IPv6 Link-Locals:', ' fe80::40f3:35ff:feb0:b6b9/64']
2021-03-16 09:24:59,984 WARNING: {'1': {'r1-eth1': [{'metric': '10', 'level': 'Level-1'}], 'r1-eth2': [{'metric': '10', 'level': 'Level-1'}]}}
2021-03-16 09:25:00,185 WARNING: ['Area 1:', ' Interface: r2-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.1.2/24', ' IPv6 Link-Locals:', ' fe80::f87f:9eff:fe95:4335/64', '', ' Interface: r2-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.3.2/24', ' IPv6 Link-Locals:', ' fe80::e09c:e9ff:fe48:ba98/64']
2021-03-16 09:25:00,185 WARNING: {'1': {'r2-eth1': [{'metric': '10', 'level': 'Level-1'}], 'r2-eth2': [{'metric': '10', 'level': 'Level-1'}]}}
2021-03-16 09:25:00,382 WARNING: ['Area 1:', ' Interface: r3-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.2.3/24', ' IPv6 Link-Locals:', ' fe80::2c3a:95ff:feda:6e45/64', '', ' Interface: r3-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.3.3/24', ' IPv6 Link-Locals:', ' fe80::ac96:e3ff:fea7:47f2/64']
2021-03-16 09:25:00,382 WARNING: {'1': {'r3-eth2': [{'metric': '10', 'level': 'Level-1'}], 'r3-eth1': [{'metric': '10', 'level': 'Level-1'}]}}
2021-03-16 09:25:12,756 WARNING: ['Area 1:', ' Interface: r1-eth1, State: Config, Active, Circuit Id: 0x0', ' Type: Unknown, Level: L1', ' Level-1 Information:', ' Metric: 16777214, Active neighbors: 0', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', '', ' Interface: r1-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.2.1/24', ' IPv6 Link-Locals:', ' fe80::40f3:35ff:feb0:b6b9/64']
2021-03-16 09:25:12,756 WARNING: {'1': {'r1-eth1': [{'metric': '16777214', 'level': 'Level-1'}], 'r1-eth2': [{'metric': '10', 'level': 'Level-1'}]}}
2021-03-16 09:25:12,960 WARNING: ['Area 1:', ' Interface: r2-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 16777214, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.1.2/24', ' IPv6 Link-Locals:', ' fe80::f87f:9eff:fe95:4335/64', '', ' Interface: r2-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.3.2/24', ' IPv6 Link-Locals:', ' fe80::e09c:e9ff:fe48:ba98/64']
2021-03-16 09:25:12,960 WARNING: {'1': {'r2-eth1': [{'metric': '16777214', 'level': 'Level-1'}], 'r2-eth2': [{'metric': '10', 'level': 'Level-1'}]}}
2021-03-16 09:25:13,166 WARNING: ['Area 1:', ' Interface: r3-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.2.3/24', ' IPv6 Link-Locals:', ' fe80::2c3a:95ff:feda:6e45/64', '', ' Interface: r3-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.3.3/24', ' IPv6 Link-Locals:', ' fe80::ac96:e3ff:fea7:47f2/64']
2021-03-16 09:25:13,166 WARNING: {'1': {'r3-eth2': [{'metric': '10', 'level': 'Level-1'}], 'r3-eth1': [{'metric': '10', 'level': 'Level-1'}]}}
2021-03-16 09:25:29,248 WARNING: ['Area 1:', ' Interface: r1-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.1.1/24', ' IPv6 Link-Locals:', ' fe80::3c75:34ff:fef7:81fd/64', '', ' Interface: r1-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.2.1/24', ' IPv6 Link-Locals:', ' fe80::40f3:35ff:feb0:b6b9/64']
2021-03-16 09:25:29,249 WARNING: {'1': {'r1-eth1': [{'metric': '10', 'level': 'Level-1'}], 'r1-eth2': [{'metric': '10', 'level': 'Level-1'}]}}
2021-03-16 09:25:29,453 WARNING: ['Area 1:', ' Interface: r2-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.1.2/24', ' IPv6 Link-Locals:', ' fe80::f87f:9eff:fe95:4335/64', '', ' Interface: r2-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.3.2/24', ' IPv6 Link-Locals:', ' fe80::e09c:e9ff:fe48:ba98/64']
2021-03-16 09:25:29,453 WARNING: {'1': {'r2-eth1': [{'metric': '10', 'level': 'Level-1'}], 'r2-eth2': [{'metric': '10', 'level': 'Level-1'}]}}
2021-03-16 09:25:29,657 WARNING: ['Area 1:', ' Interface: r3-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.2.3/24', ' IPv6 Link-Locals:', ' fe80::2c3a:95ff:feda:6e45/64', '', ' Interface: r3-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.3.3/24', ' IPv6 Link-Locals:', ' fe80::ac96:e3ff:fea7:47f2/64']
2021-03-16 09:25:29,657 WARNING: {'1': {'r3-eth2': [{'metric': '10', 'level': 'Level-1'}], 'r3-eth1': [{'metric': '10', 'level': 'Level-1'}]}}
2021-03-16 09:25:44,163 WARNING: ['Area 1:', ' Interface: r1-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 16777214, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.1.1/24', ' IPv6 Link-Locals:', ' fe80::3c75:34ff:fef7:81fd/64', '', ' Interface: r1-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.2.1/24', ' IPv6 Link-Locals:', ' fe80::40f3:35ff:feb0:b6b9/64']
2021-03-16 09:25:44,164 WARNING: {'1': {'r1-eth1': [{'metric': '16777214', 'level': 'Level-1'}], 'r1-eth2': [{'metric': '10', 'level': 'Level-1'}]}}
2021-03-16 09:25:44,329 WARNING: ['Area 1:', ' Interface: r2-eth1, State: Config, Active, Circuit Id: 0x0', ' Type: Unknown, Level: L1', ' Level-1 Information:', ' Metric: 16777214, Active neighbors: 0', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', '', ' Interface: r2-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.3.2/24', ' IPv6 Link-Locals:', ' fe80::e09c:e9ff:fe48:ba98/64']
2021-03-16 09:25:44,329 WARNING: {'1': {'r2-eth1': [{'metric': '16777214', 'level': 'Level-1'}], 'r2-eth2': [{'metric': '10', 'level': 'Level-1'}]}}
2021-03-16 09:25:44,493 WARNING: ['Area 1:', ' Interface: r3-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.2.3/24', ' IPv6 Link-Locals:', ' fe80::2c3a:95ff:feda:6e45/64', '', ' Interface: r3-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.3.3/24', ' IPv6 Link-Locals:', ' fe80::ac96:e3ff:fea7:47f2/64']
2021-03-16 09:25:44,494 WARNING: {'1': {'r3-eth2': [{'metric': '10', 'level': 'Level-1'}], 'r3-eth1': [{'metric': '10', 'level': 'Level-1'}]}}
2021-03-16 09:26:00,405 WARNING: ['Area 1:', ' Interface: r1-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.1.1/24', ' IPv6 Link-Locals:', ' fe80::3c75:34ff:fef7:81fd/64', '', ' Interface: r1-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.2.1/24', ' IPv6 Link-Locals:', ' fe80::40f3:35ff:feb0:b6b9/64']
2021-03-16 09:26:00,405 WARNING: {'1': {'r1-eth1': [{'metric': '10', 'level': 'Level-1'}], 'r1-eth2': [{'metric': '10', 'level': 'Level-1'}]}}
2021-03-16 09:26:00,637 WARNING: ['Area 1:', ' Interface: r2-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.1.2/24', ' IPv6 Link-Locals:', ' fe80::f87f:9eff:fe95:4335/64', '', ' Interface: r2-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.3.2/24', ' IPv6 Link-Locals:', ' fe80::e09c:e9ff:fe48:ba98/64']
2021-03-16 09:26:00,638 WARNING: {'1': {'r2-eth1': [{'metric': '10', 'level': 'Level-1'}], 'r2-eth2': [{'metric': '10', 'level': 'Level-1'}]}}
2021-03-16 09:26:00,821 WARNING: ['Area 1:', ' Interface: r3-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.2.3/24', ' IPv6 Link-Locals:', ' fe80::2c3a:95ff:feda:6e45/64', '', ' Interface: r3-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.3.3/24', ' IPv6 Link-Locals:', ' fe80::ac96:e3ff:fea7:47f2/64']
2021-03-16 09:26:00,821 WARNING: {'1': {'r3-eth2': [{'metric': '10', 'level': 'Level-1'}], 'r3-eth1': [{'metric': '10', 'level': 'Level-1'}]}}

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17693/artifact/TOPO7U18AMD64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 arm8 part 7: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 7: No useful log found

Successful on other platforms/tests

Static analyzer (clang)
Topotests Ubuntu 16.04 i386 part 4
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 16.04 i386 part 2
Topotests Ubuntu 18.04 arm8 part 5
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 0
Addresssanitizer topotests part 5
Topotests Ubuntu 16.04 i386 part 6
Topotests Ubuntu 18.04 arm8 part 9
Topotests Ubuntu 16.04 i386 part 7
Addresssanitizer topotests part 0
IPv4 ldp protocol on Ubuntu 18.04
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 amd64 part 9
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 16.04 amd64 part 1
Fedora 29 rpm pkg check
IPv6 protocols on Ubuntu 18.04
Addresssanitizer topotests part 1
Topotests Ubuntu 16.04 i386 part 8
Topotests Ubuntu 16.04 amd64 part 4
Addresssanitizer topotests part 4
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 16.04 amd64 part 5
Topotests Ubuntu 16.04 i386 part 1
Topotests Ubuntu 16.04 i386 part 5
Addresssanitizer topotests part 6
Addresssanitizer topotests part 8
Topotests Ubuntu 16.04 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 16.04 amd64 part 3
IPv4 protocols on Ubuntu 18.04
Topotests Ubuntu 16.04 i386 part 9
Topotests Ubuntu 16.04 i386 part 3
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 2
Ubuntu 18.04 deb pkg check
Ubuntu 20.04 deb pkg check
Ubuntu 16.04 deb pkg check
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 amd64 part 1
Topotests Ubuntu 18.04 arm8 part 3
Topotests Ubuntu 16.04 amd64 part 9
Topotests Ubuntu 16.04 amd64 part 2
Debian 10 deb pkg check
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 8
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 16.04 i386 part 0
Debian 9 deb pkg check
Addresssanitizer topotests part 9
Topotests Ubuntu 16.04 amd64 part 6
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 arm8 part 8
Topotests Ubuntu 16.04 amd64 part 8
Debian 8 deb pkg check
Addresssanitizer topotests part 3

polychaeta

Thanks for your contribution to FRR!

Pylint found errors in source files changed by this PR:

Pylint report for my_frr/tests/topotests/bgp_multi_vrf_topo1/test_bgp_multi_vrf_topo1.py:
************* Module test_bgp_multi_vrf_topo1
my_frr/tests/topotests/bgp_multi_vrf_topo1/test_bgp_multi_vrf_topo1.py:2677:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_multi_vrf_topo1/test_bgp_multi_vrf_topo1.py:2683:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_multi_vrf_topo1/test_bgp_multi_vrf_topo1.py:4958:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_multi_vrf_topo1/test_bgp_multi_vrf_topo1.py:5170:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_multi_vrf_topo1/test_bgp_multi_vrf_topo1.py:5449:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_multi_vrf_topo1/test_bgp_multi_vrf_topo1.py:5853:8: E1305: Too many arguments for format string (too-many-format-args)

-----------------------------------
Your code has been rated at 9.73/10



Pylint report for my_frr/tests/topotests/bgp_multi_vrf_topo2/test_bgp_multi_vrf_topo2.py:
************* Module test_bgp_multi_vrf_topo2
my_frr/tests/topotests/bgp_multi_vrf_topo2/test_bgp_multi_vrf_topo2.py:1572:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_multi_vrf_topo2/test_bgp_multi_vrf_topo2.py:1617:12: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_multi_vrf_topo2/test_bgp_multi_vrf_topo2.py:1622:12: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_multi_vrf_topo2/test_bgp_multi_vrf_topo2.py:1862:12: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_multi_vrf_topo2/test_bgp_multi_vrf_topo2.py:2179:27: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_multi_vrf_topo2/test_bgp_multi_vrf_topo2.py:3388:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_multi_vrf_topo2/test_bgp_multi_vrf_topo2.py:3394:8: E1305: Too many arguments for format string (too-many-format-args)

-----------------------------------
Your code has been rated at 9.58/10



Pylint report for my_frr/tests/topotests/lib/topotest.py:
************* Module lib.topotest
my_frr/tests/topotests/lib/topotest.py:1889:15: E0602: Undefined variable 'unicode' (undefined-variable)

-----------------------------------
Your code has been rated at 9.95/10

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

LabN-CI · 2021-03-18T11:10:48Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/8253 `dd102f6`
Date	03/18/2021
Start	06:31:28
Finish	07:10:44
Run-Time	39:16
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2021-03-18-06:31:28.txt
Log	autoscript-2021-03-18-06:32:38.log.bz2
Memory	478 491 429

For details, please contact louberger

NetDEF-CI · 2021-03-18T12:53:38Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17785/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 16.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO9U16I386-17785/test

Topology Tests failed for Topotests Ubuntu 16.04 i386 part 9:

2021-03-18 11:26:11,501 ERROR: 'router_json_cmp' failed after 84.30 seconds
2021-03-18 11:26:11,507 ERROR: assert failed at "test_ospf_sr_topo1/test_rib_ipv4_step4": "rt6" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.7.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 110,
  	    "prefix": "10.0.7.0/24",
  	    "protocol": "ospf",
  	    "metric": 10,
  	    "nexthops": [
  	        {
  	            "active": true,
  	            "directlyConnected": true,
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.7.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "active": true,
  		    "directlyConnected": true,
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.7.0/24[0]->nexthops[0]: d2 has key 'active' which is not present in d1
  	
  
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
2021-03-18 11:33:01,550 WARNING: vtysh_cmd: failed to convert json output
2021-03-18 11:33:22,798 WARNING: vtysh_cmd: failed to convert json output
2021-03-18 11:43:04,768 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U16I386/topotests/lib/common_config.py", line 1693, in create_interfaces_cfg
    tgen, c_router, interface_data, "interface_config", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U16I386/topotests/lib/common_config.py", line 290, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U16I386/topotests/lib/common_config.py", line 575, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 3: % Unknown command[16]: ip ospf hello-interval 65536 


2021-03-18 11:43:36,175 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U16I386/topotests/lib/common_config.py", line 1693, in create_interfaces_cfg
    tgen, c_router, interface_data, "interface_config", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U16I386/topotests/lib/common_config.py", line 290, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U16I386/topotests/lib/common_config.py", line 575, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 3: % Unknown command[16]: ip ospf dead-interval 65536

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17785/artifact/TOPO9U16I386/ErrorLog/log_topotests.txt

Topotests Ubuntu 16.04 amd64 part 5: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO5U16AMD64-17785/test

Topology Tests failed for Topotests Ubuntu 16.04 amd64 part 5:

2021-03-18 11:26:03,673 ERROR: assert failed at "test_bgp_multiview_topo1/test_bgp_routingTable": Routing Table verification failed for router r1, view 1:
No template matched.
template /root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO5U16AMD64/topotests/bgp_multiview_topo1/r1/show_ip_bgp_view_1-post6.1.ref: r1 failed Routing Table Check for view 1:
--- actual BGP routing table
+++ expected BGP routing table
@@ -7,8 +7,8 @@
 
    Network          Next Hop            Metric LocPrf Weight Path
 *  10.0.1.0/24      172.16.1.5                             0 65005 i
+*                   172.16.1.2                             0 65002 i
 *>                  172.16.1.1                             0 65001 i
-*                   172.16.1.2                             0 65002 i
 *> 10.101.0.0/24    172.16.1.1             100              0 65001 i
 *> 10.101.1.0/24    172.16.1.1             100              0 65001 i
 *> 10.101.2.0/24    172.16.1.1             100              0 65001 i
template /root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO5U16AMD64/topotests/bgp_multiview_topo1/r1/show_ip_bgp_view_1.ref: r1 failed Routing Table Check for view 1:
--- actual BGP routing table
+++ expected BGP routing table
@@ -1,14 +1,12 @@
-BGP table version is XXX, local router ID is 172.30.1.1, vrf id -
-Default local pref 100, local AS 100
-Status codes:  s suppressed, d damped, h history, * valid, > best, = multipath,
-               i internal, r RIB-failure, S Stale, R Removed
-Nexthop codes: @NNN nexthop's vrf id, < announce-nh-self
-Origin codes:  i - IGP, e - EGP, ? - incomplete
+BGP table version is XXX, local router ID is 172.30.1.1
+Status codes: s suppressed, d damped, h history, * valid, > best, = multipath,
+              i internal, r RIB-failure, S Stale, R Removed
+Origin codes: i - IGP, e - EGP, ? - incomplete
 
    Network          Next Hop            Metric LocPrf Weight Path
 *  10.0.1.0/24      172.16.1.5                             0 65005 i
+*                   172.16.1.2                             0 65002 i
 *>                  172.16.1.1                             0 65001 i
-*                   172.16.1.2                             0 65002 i
 *> 10.101.0.0/24    172.16.1.1             100              0 65001 i
 *> 10.101.1.0/24    172.16.1.1             100              0 65001 i
 *> 10.101.2.0/24    172.16.1.1             100              0 65001 i
template /root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO5U16AMD64/topotests/bgp_multiview_topo1/r1/show_ip_bgp_view_1-post4.1.ref: r1 failed Routing Table Check for view 1:
--- actual BGP routing table
+++ expected BGP routing table
@@ -1,5 +1,4 @@
 BGP table version is XXX, local router ID is 172.30.1.1, vrf id -
-Default local pref 100, local AS 100
 Status codes:  s suppressed, d damped, h history, * valid, > best, = multipath,
                i internal, r RIB-failure, S Stale, R Removed
 Nexthop codes: @NNN nexthop's vrf id, < announce-nh-self
@@ -7,8 +6,8 @@
 
    Network          Next Hop            Metric LocPrf Weight Path
 *  10.0.1.0/24      172.16.1.5                             0 65005 i
+*                   172.16.1.2                             0 65002 i
 *>                  172.16.1.1                             0 65001 i
-*                   172.16.1.2                             0 65002 i
 *> 10.101.0.0/24    172.16.1.1             100              0 65001 i
 *> 10.101.1.0/24    172.16.1.1             100              0 65001 i
 *> 10.101.2.0/24    172.16.1.1             100              0 65001 i

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17785/artifact/TOPO5U16AMD64/ErrorLog/log_topotests.txt

Successful on other platforms/tests

Topotests Ubuntu 18.04 amd64 part 8
Topotests Ubuntu 16.04 amd64 part 7
Topotests Ubuntu 18.04 amd64 part 9
Addresssanitizer topotests part 9
Fedora 29 rpm pkg check
Topotests Ubuntu 18.04 arm8 part 3
Topotests Ubuntu 16.04 amd64 part 4
Topotests Ubuntu 16.04 amd64 part 3
Addresssanitizer topotests part 4
Addresssanitizer topotests part 7
Topotests Ubuntu 16.04 i386 part 5
Static analyzer (clang)
Topotests Ubuntu 18.04 amd64 part 2
Addresssanitizer topotests part 5
Topotests Ubuntu 16.04 amd64 part 2
Topotests Ubuntu 18.04 amd64 part 0
Ubuntu 16.04 deb pkg check
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 5
Topotests Ubuntu 18.04 arm8 part 0
Addresssanitizer topotests part 0
Ubuntu 18.04 deb pkg check
Topotests Ubuntu 18.04 amd64 part 1
Topotests Ubuntu 16.04 i386 part 7
CentOS 7 rpm pkg check
IPv6 protocols on Ubuntu 18.04
Topotests Ubuntu 16.04 i386 part 8
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 16.04 amd64 part 1
Topotests Ubuntu 16.04 amd64 part 6
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 arm8 part 8
Topotests Ubuntu 16.04 amd64 part 8
Debian 8 deb pkg check
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 16.04 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 6
IPv4 protocols on Ubuntu 18.04
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 arm8 part 1
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 16.04 i386 part 2
Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 16.04 i386 part 1
Topotests Ubuntu 16.04 i386 part 4
Addresssanitizer topotests part 6
Topotests Ubuntu 16.04 i386 part 6
IPv4 ldp protocol on Ubuntu 18.04
Addresssanitizer topotests part 2
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 arm8 part 9
Topotests Ubuntu 16.04 i386 part 0
Topotests Ubuntu 16.04 amd64 part 9
Debian 9 deb pkg check
Topotests Ubuntu 18.04 arm8 part 4
Debian 10 deb pkg check
Topotests Ubuntu 16.04 i386 part 3

pguibert6WIND · 2021-03-22T15:15:12Z

why don't we check the kernel version ?
In many tests, the krel permits to know what kind of vrf we have inside.

I understand kernel check is not enough, and iproute2 should be added ?

LabN-CI · 2021-03-23T09:45:13Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/8253 `83d2076`
Date	03/23/2021
Start	05:05:41
Finish	05:45:10
Run-Time	39:29
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2021-03-23-05:05:41.txt
Log	autoscript-2021-03-23-05:06:55.log.bz2
Memory	488 500 433

For details, please contact louberger

NetDEF-CI · 2021-03-23T12:17:07Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17906/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

riw777

looks good

davischw · 2021-03-23T15:28:30Z

@riw777 Thank you, Russ.

davischw added 2 commits March 15, 2021 12:48

tests: check for iproute2 VRF capability

0414a76

Signed-off-by: David Schweizer <dschweizer@opensourcerouting.org>

tests: iproute2 VRF capability check examples

ddbc1ad

Example usage of iproute2_is_vrf_capable check in bgp_multi_vrf_topo1 and bgp_multi_vrf_topo2 topotests. Signed-off-by: David Schweizer <dschweizer@opensourcerouting.org>

polychaeta added the tests Topotests, make check, etc label Mar 15, 2021

polychaeta reviewed Mar 15, 2021

View reviewed changes

tests: add. iproute2 VRF capability check example

83d2076

Additional example usage of iproute2_is_vrf_capable check in isis-topo1-vrf topotest. Signed-off-by: David Schweizer <dschweizer@opensourcerouting.org>

polychaeta reviewed Mar 16, 2021

View reviewed changes

rzalamena approved these changes Mar 16, 2021

View reviewed changes

davischw mentioned this pull request Mar 18, 2021

bgpd: BGP session not established for ipv6 link local address with vrf config #7434

Merged

davischw force-pushed the topotest-python3-backports branch from 0b04146 to dd102f6 Compare March 18, 2021 09:48

polychaeta reviewed Mar 18, 2021

View reviewed changes

rzalamena mentioned this pull request Mar 22, 2021

ospf6d, tests, doc : OSPFv3 vrf support #7734

Closed

davischw force-pushed the topotest-python3-backports branch from dd102f6 to 83d2076 Compare March 23, 2021 09:02

riw777 approved these changes Mar 23, 2021

View reviewed changes

riw777 merged commit 638fa8d into FRRouting:master Mar 23, 2021

eqvinox deleted the topotest-python3-backports branch April 18, 2021 07:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tests: iproute2 VRF capability check for topotests #8253

tests: iproute2 VRF capability check for topotests #8253

davischw commented Mar 15, 2021

polychaeta left a comment

NetDEF-CI commented Mar 15, 2021 •

edited

Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

LabN-CI commented Mar 15, 2021 •

edited

Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

polychaeta left a comment

LabN-CI commented Mar 16, 2021 •

edited

Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Mar 16, 2021 •

edited

Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

polychaeta left a comment

LabN-CI commented Mar 18, 2021 •

edited

Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Mar 18, 2021 •

edited

Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

pguibert6WIND commented Mar 22, 2021

LabN-CI commented Mar 23, 2021

NetDEF-CI commented Mar 23, 2021

riw777 left a comment

davischw commented Mar 23, 2021

tests: iproute2 VRF capability check for topotests #8253

tests: iproute2 VRF capability check for topotests #8253

Conversation

davischw commented Mar 15, 2021

polychaeta left a comment

Choose a reason for hiding this comment

NetDEF-CI commented Mar 15, 2021 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

LabN-CI commented Mar 15, 2021 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

polychaeta left a comment

Choose a reason for hiding this comment

LabN-CI commented Mar 16, 2021 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Mar 16, 2021 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

polychaeta left a comment

Choose a reason for hiding this comment

LabN-CI commented Mar 18, 2021 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Mar 18, 2021 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

pguibert6WIND commented Mar 22, 2021

LabN-CI commented Mar 23, 2021

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Mar 23, 2021

Continuous Integration Result: SUCCESSFUL

riw777 left a comment

Choose a reason for hiding this comment

davischw commented Mar 23, 2021

NetDEF-CI commented Mar 15, 2021 •

edited

Loading

LabN-CI commented Mar 15, 2021 •

edited

Loading

LabN-CI commented Mar 16, 2021 •

edited

Loading

NetDEF-CI commented Mar 16, 2021 •

edited

Loading

LabN-CI commented Mar 18, 2021 •

edited

Loading

NetDEF-CI commented Mar 18, 2021 •

edited

Loading