Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vehicle collides with invisible object and flies off #203

Closed
Plavit opened this issue Aug 1, 2020 · 9 comments · Fixed by #206
Closed

Vehicle collides with invisible object and flies off #203

Plavit opened this issue Aug 1, 2020 · 9 comments · Fixed by #206
Assignees
Labels
bug Something isn't working high-prio Things that should be worked on as soon

Comments

@Plavit
Copy link
Contributor

Plavit commented Aug 1, 2020

While testing around, we have encountered what is potentially a really nasty bug.

During driving, the vehicle appears to have crashed into some invisible ninja wall which sent it flying into a different direction - completely messing up all algorithms. See video for reference:
https://youtu.be/lBl9r7biYxE

Static picture of the incident:
image

This could be caused by a collision with a cone, we are not sure.

Is there a plan to make sure this does not repeat at comp? What is the expected FSO procedure if this happens and ruins a team's attempt?

@SijmenHuizenga
Copy link
Member

SijmenHuizenga commented Aug 1, 2020

Flying off already, amazing!

No but seriously, this must be fixed. I will look into it. Thanks a lot for the report and the video!!!

If this (or something similar) happens during competition a rerun will be issued. This is dictated by the following rule in the rulebook under section 3.1:

In case the simulator does not perform as expected during a run, a rerun can be requested by the officials.

@SijmenHuizenga SijmenHuizenga added the high-prio Things that should be worked on as soon label Aug 1, 2020
@SijmenHuizenga SijmenHuizenga self-assigned this Aug 1, 2020
@SijmenHuizenga SijmenHuizenga added the bug Something isn't working label Aug 1, 2020
@SijmenHuizenga
Copy link
Member

It looks like the track is not exactly straight:

image

@Plavit
Copy link
Contributor Author

Plavit commented Aug 1, 2020

@SijmenHuizenga Do you mean flat?

Yes, it is not flat when the formula comes from the light gray asphalt onto the dark gray asphalt - but this is not a big issue, we thought it was a feature tbh 😅

However the bug we described above seems to happen on a flat surface as well

@SijmenHuizenga
Copy link
Member

Yes I mean flat, sorry for my Dutchy English ;)

Yes, the pavement being raised a bit is a feature. However, the light gray asphalt within itself should be flat. Because the pavement is made up of individual pieces linked together. If they do so at an angle weird behavior happens:

image

However... After some more testing I can conclude that this does not solve the problem. Back to debugging 😅

@SijmenHuizenga
Copy link
Member

Soooo I havn't been able to find it. So far I have ruled out the following things:

  • It has nothing to do with cones because it also happens in spots without cones
  • It has nothing to do with the spectator trigger lines because it happens in spots far away from any spectator trigger
  • The track if as flat as it can be, so no problems there

Has anyone been able to replicate this on the dark gray asphalt? Maybe it has something to do with the light-gray asphalt?

@SijmenHuizenga SijmenHuizenga changed the title Extreme collisions with formulas flying Vehicle collides with invisible object and flies off Aug 1, 2020
@SijmenHuizenga
Copy link
Member

I have disabled collision on the light-gray pavement. This will be included in the next version.

@Plavit
Copy link
Contributor Author

Plavit commented Aug 2, 2020

@SijmenHuizenga Cool, thanks for the fix! Maybe it was invisible nijas after all...

If the colisions on the light-gray pavements are off, will this not interfere with cone hitting? And will the "pavement raise bump" be still there?

@SijmenHuizenga
Copy link
Member

If the collisions on the light-gray pavements are off, will this not interfere with cone hitting?

Cones work just like before. Nothing has changes. You will be able to test in version 1.2.0 that will be released in the next hour.

will the "pavement raise bump" be still there?

Unfortunately not. But I think keeping the bump is way less important then the invisible ninja so it's gone.

@Plavit
Copy link
Contributor Author

Plavit commented Aug 2, 2020

@SijmenHuizenga Yes agreed, thanks for the information and fix 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high-prio Things that should be worked on as soon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants