Skip to content

Cleanup codebase #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 21, 2020
Merged

Cleanup codebase #165

merged 9 commits into from
Jul 21, 2020

Conversation

SijmenHuizenga
Copy link
Member

I am getting more and more annoyed by the big pile of unused code and the many layers of useless abstractions. This pr is the first that will try to cleanup the codebase. The goal is to make the codebase better accessible for new engineers. In this pr:

  • remove in-game recording module. If people want to record the screen, use a screenrecorder. If you want to record thecamera views, use rosbag recordings
  • Remove debug reporter as it is unused, nobody knows how it works and it is undocumented.
  • Remove support for multiple gamemods. This simulation only does vehicle simulations so removed the computer vision simmode
  • Remove VehicleType setting because it is and always will be PhysXCar
  • Removed barometer and magnetometer sensors as they were all not used
  • Removed 'environment' state as it was only useful for barometer and magnetometer
  • Remove bitmap_image.hpp helper class and removed unused physics body classes
  • Remove safety evaluation code as it was commented out and nobody knows what it does or how it can be usefull
  • Remove unused drone physicsengine

@SijmenHuizenga SijmenHuizenga changed the title Cleanup physics Cleanup codebase Jul 20, 2020
@SijmenHuizenga
Copy link
Member Author

I've tested this, everything still works so lets #merge

@SijmenHuizenga SijmenHuizenga merged commit d8ca5d4 into master Jul 21, 2020
@SijmenHuizenga SijmenHuizenga deleted the cleanup-physics branch July 21, 2020 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant