Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added big orange cones to testing_only track #255

Merged
merged 2 commits into from
Nov 24, 2020

Conversation

wouter-heerwegh
Copy link
Member

This is a solution for issue #254.

Probably not the cleanest way to do this, but I don't know much about unreal engine. Wanted to the same thing in the referee blueprint as was done with 'Track', but for some reason my reference to the start finish line never became anything else than 'None'.

I added the positions of the big orange cones. I'm sorry if my solution is very ugly, I don't know anything about unreal engine. I still have to test if the location of the cones is correct
Copy link
Member

@SijmenHuizenga SijmenHuizenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just tested it and it works smoothly and correctly. Don't worry about having less experience with Unreal, code and blueprints look perfectly fine as they are!

For future reference, this is the addition in the StartFinishLine construction blueprint:

image

This is the addition in the Referee blueprint:

image

@SijmenHuizenga SijmenHuizenga linked an issue Nov 24, 2020 that may be closed by this pull request
@SijmenHuizenga
Copy link
Member

SijmenHuizenga commented Nov 24, 2020

Thanks a lot for this @wouter-heerwegh! Merging this now. (github builds is failing for a reason unrelated to this pr. So we can ignore it)

Do you need a new release right away? If that's the case feel free to comment and I will create one.

@SijmenHuizenga SijmenHuizenga merged commit a69c137 into FS-Driverless:master Nov 24, 2020
@wouter-heerwegh
Copy link
Member Author

I've recorded a rosbag with the change I applied, so it's not urgent. I do have a question about the lidar sensors though.

I was simulating one (32 layers) with a total of 32000+ points but there was a major distance between the pointcloud and the reference track. Is this solely due to the data being out of sync?

Also, is the pointcloud fully compensated for yaw, pitch and roll of the car?

@SijmenHuizenga
Copy link
Member

Can the major distance difference be cause the different coordinate systems of the lidar and reference track? The lidar points are relative to the car while the reference track is relative to the world (that is, relative to some arbitrary point close to where the car starts).

All points in the pointcloud are relative to the car's position (x, y, z) and orientation (rol, pitch, yaw). So if the car pitches, the pointcloud does as well.

@wouter-heerwegh
Copy link
Member Author

It's not due to the coordinate systems being different because they start equal and stay pretty accurate for a couple of meters. It's probably a combination of me not compensating for this yaw, pitch and roll, and everything taking too long to process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Track topic does not contain big orange cones
2 participants