-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build F* with dune
instead of ocamlbuild
#2815
Merged
Merged
Commits on Jan 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8a5e410 - Browse repository at this point
Copy the full SHA 8a5e410View commit details
Commits on Jan 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e0df548 - Browse repository at this point
Copy the full SHA e0df548View commit details -
Configuration menu - View commit details
-
Copy full SHA for 31182a0 - Browse repository at this point
Copy the full SHA 31182a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 840e677 - Browse repository at this point
Copy the full SHA 840e677View commit details -
Configuration menu - View commit details
-
Copy full SHA for 76b5fc2 - Browse repository at this point
Copy the full SHA 76b5fc2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1036be2 - Browse repository at this point
Copy the full SHA 1036be2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ac0fb8 - Browse repository at this point
Copy the full SHA 8ac0fb8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1291dfb - Browse repository at this point
Copy the full SHA 1291dfbView commit details -
Configuration menu - View commit details
-
Copy full SHA for b4f42ac - Browse repository at this point
Copy the full SHA b4f42acView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e61ddf - Browse repository at this point
Copy the full SHA 6e61ddfView commit details -
Configuration menu - View commit details
-
Copy full SHA for cad908a - Browse repository at this point
Copy the full SHA cad908aView commit details -
Configuration menu - View commit details
-
Copy full SHA for f46c04c - Browse repository at this point
Copy the full SHA f46c04cView commit details
Commits on Jan 26, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 988620f - Browse repository at this point
Copy the full SHA 988620fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f5f331 - Browse repository at this point
Copy the full SHA 3f5f331View commit details -
Configuration menu - View commit details
-
Copy full SHA for e92863c - Browse repository at this point
Copy the full SHA e92863cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 69cb66c - Browse repository at this point
Copy the full SHA 69cb66cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a1c44e - Browse repository at this point
Copy the full SHA 9a1c44eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7821bcd - Browse repository at this point
Copy the full SHA 7821bcdView commit details -
Configuration menu - View commit details
-
Copy full SHA for e9e39b0 - Browse repository at this point
Copy the full SHA e9e39b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c726c0 - Browse repository at this point
Copy the full SHA 3c726c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 301393b - Browse repository at this point
Copy the full SHA 301393bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 408c53d - Browse repository at this point
Copy the full SHA 408c53dView commit details -
Configuration menu - View commit details
-
Copy full SHA for cbcefb8 - Browse repository at this point
Copy the full SHA cbcefb8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a5859a - Browse repository at this point
Copy the full SHA 6a5859aView commit details -
Configuration menu - View commit details
-
Copy full SHA for f23810d - Browse repository at this point
Copy the full SHA f23810dView commit details
Commits on Jan 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for da9ce82 - Browse repository at this point
Copy the full SHA da9ce82View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c7f81f - Browse repository at this point
Copy the full SHA 2c7f81fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e748db - Browse repository at this point
Copy the full SHA 9e748dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 21bfa07 - Browse repository at this point
Copy the full SHA 21bfa07View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6dea28a - Browse repository at this point
Copy the full SHA 6dea28aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b4a0c9 - Browse repository at this point
Copy the full SHA 7b4a0c9View commit details
Commits on Jan 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0b02e48 - Browse repository at this point
Copy the full SHA 0b02e48View commit details -
Configuration menu - View commit details
-
Copy full SHA for 113f430 - Browse repository at this point
Copy the full SHA 113f430View commit details -
Configuration menu - View commit details
-
Copy full SHA for a1855b9 - Browse repository at this point
Copy the full SHA a1855b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for eb38a57 - Browse repository at this point
Copy the full SHA eb38a57View commit details -
Configuration menu - View commit details
-
Copy full SHA for 29b8519 - Browse repository at this point
Copy the full SHA 29b8519View commit details -
Configuration menu - View commit details
-
Copy full SHA for e75cf5b - Browse repository at this point
Copy the full SHA e75cf5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b70d53 - Browse repository at this point
Copy the full SHA 1b70d53View commit details
Commits on Jan 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 44301e8 - Browse repository at this point
Copy the full SHA 44301e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2219770 - Browse repository at this point
Copy the full SHA 2219770View commit details -
Configuration menu - View commit details
-
Copy full SHA for 98b4c9f - Browse repository at this point
Copy the full SHA 98b4c9fView commit details -
Configuration menu - View commit details
-
Copy full SHA for deed0c6 - Browse repository at this point
Copy the full SHA deed0c6View commit details -
you can find them in the ocaml/ directory, outside of the generated subdirectories.
Configuration menu - View commit details
-
Copy full SHA for c3914d5 - Browse repository at this point
Copy the full SHA c3914d5View commit details -
remove handwritten ml files in src/
you can now find them in the ocaml/ directory, outside of the generated/ subdirectories
Configuration menu - View commit details
-
Copy full SHA for 6224933 - Browse repository at this point
Copy the full SHA 6224933View commit details
Commits on Jan 31, 2023
-
Configuration menu - View commit details
-
Copy full SHA for acca4e3 - Browse repository at this point
Copy the full SHA acca4e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b39cd8 - Browse repository at this point
Copy the full SHA 0b39cd8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 52cf538 - Browse repository at this point
Copy the full SHA 52cf538View commit details -
Configuration menu - View commit details
-
Copy full SHA for 014314d - Browse repository at this point
Copy the full SHA 014314dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 23028be - Browse repository at this point
Copy the full SHA 23028beView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4825a2c - Browse repository at this point
Copy the full SHA 4825a2cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 603f2b6 - Browse repository at this point
Copy the full SHA 603f2b6View commit details -
It only contains binaries and generated files
Configuration menu - View commit details
-
Copy full SHA for 8607890 - Browse repository at this point
Copy the full SHA 8607890View commit details -
Configuration menu - View commit details
-
Copy full SHA for ba0ec5f - Browse repository at this point
Copy the full SHA ba0ec5fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ddfc73 - Browse repository at this point
Copy the full SHA 6ddfc73View commit details
Commits on Feb 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 3b910e4 - Browse repository at this point
Copy the full SHA 3b910e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf18af2 - Browse repository at this point
Copy the full SHA bf18af2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 61de305 - Browse repository at this point
Copy the full SHA 61de305View commit details -
Configuration menu - View commit details
-
Copy full SHA for 23b74b5 - Browse repository at this point
Copy the full SHA 23b74b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b1f0ec - Browse repository at this point
Copy the full SHA 4b1f0ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 02ba786 - Browse repository at this point
Copy the full SHA 02ba786View commit details -
Configuration menu - View commit details
-
Copy full SHA for 39179b8 - Browse repository at this point
Copy the full SHA 39179b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 164b354 - Browse repository at this point
Copy the full SHA 164b354View commit details -
Configuration menu - View commit details
-
Copy full SHA for 193716f - Browse repository at this point
Copy the full SHA 193716fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f9f2d4e - Browse repository at this point
Copy the full SHA f9f2d4eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 35e5a7c - Browse repository at this point
Copy the full SHA 35e5a7cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d323d7 - Browse repository at this point
Copy the full SHA 9d323d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 86819c6 - Browse repository at this point
Copy the full SHA 86819c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2dd9ab9 - Browse repository at this point
Copy the full SHA 2dd9ab9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 085483c - Browse repository at this point
Copy the full SHA 085483cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 87d073d - Browse repository at this point
Copy the full SHA 87d073dView commit details -
Configuration menu - View commit details
-
Copy full SHA for b02a50d - Browse repository at this point
Copy the full SHA b02a50dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 186f455 - Browse repository at this point
Copy the full SHA 186f455View commit details -
Configuration menu - View commit details
-
Copy full SHA for 59f9513 - Browse repository at this point
Copy the full SHA 59f9513View commit details -
Configuration menu - View commit details
-
Copy full SHA for dbb3bab - Browse repository at this point
Copy the full SHA dbb3babView commit details -
Configuration menu - View commit details
-
Copy full SHA for fc769a4 - Browse repository at this point
Copy the full SHA fc769a4View commit details
Commits on Feb 2, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7514956 - Browse repository at this point
Copy the full SHA 7514956View commit details -
Configuration menu - View commit details
-
Copy full SHA for 05314a3 - Browse repository at this point
Copy the full SHA 05314a3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 230e9d6 - Browse repository at this point
Copy the full SHA 230e9d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f42b18 - Browse repository at this point
Copy the full SHA 7f42b18View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2663ccb - Browse repository at this point
Copy the full SHA 2663ccbView commit details
Commits on Feb 3, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 400f371 - Browse repository at this point
Copy the full SHA 400f371View commit details -
Makefile.boot: take tests out of the library
Tests files (src/tests) make heavy use of top-level effects to initialize a typechecker environment and load some definitions, among other things. If they are linked with everything else into fstar-lib, then 1- the compiler will include them, which is a bit of bloat 2- the compiler will be side effected by them causing some error message tests to fail as Tahina noticed. 3- applications (which currently use this library) will also contain the tests and initialize them on program load, which is terrible. This patch then moves all of the generation of FStar_Test_* modules into ocaml/fstar-test instead of ocaml/fstar-lib. Dune takes care of the rest. It would be nice for this way of splitting modules to be standardized and somehow more easily configurable. The actual patch is twofold: a SED edit of the .depend file, and a change to the extraction rule to decide which directory a file goes to. It does not really make sense to have to edit both... but there are several limitations to our current Makefiles (see also #1978).
Configuration menu - View commit details
-
Copy full SHA for c3a71a5 - Browse repository at this point
Copy the full SHA c3a71a5View commit details -
dune: fstar-tests: add public name to obtain an executable
With @tahina-pro. This is suboptimal since it installs a fstar_tests.exe program in the user's /bin directory, which serves no purpose. However avoiding this and still being able to run tests in CI (or locally) takes some refactoring however, so we are postponing it.
Configuration menu - View commit details
-
Copy full SHA for 90b24c5 - Browse repository at this point
Copy the full SHA 90b24c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 12fd6f4 - Browse repository at this point
Copy the full SHA 12fd6f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for d64b62c - Browse repository at this point
Copy the full SHA d64b62cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1937ace - Browse repository at this point
Copy the full SHA 1937aceView commit details -
Configuration menu - View commit details
-
Copy full SHA for c0864c8 - Browse repository at this point
Copy the full SHA c0864c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for fc54eb0 - Browse repository at this point
Copy the full SHA fc54eb0View commit details -
Configuration menu - View commit details
-
Copy full SHA for e134f6a - Browse repository at this point
Copy the full SHA e134f6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f7e674 - Browse repository at this point
Copy the full SHA 8f7e674View commit details -
Configuration menu - View commit details
-
Copy full SHA for 55fa49f - Browse repository at this point
Copy the full SHA 55fa49fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7231315 - Browse repository at this point
Copy the full SHA 7231315View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d2500d - Browse repository at this point
Copy the full SHA 7d2500dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c8c760 - Browse repository at this point
Copy the full SHA 6c8c760View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1748089 - Browse repository at this point
Copy the full SHA 1748089View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a4b448 - Browse repository at this point
Copy the full SHA 2a4b448View commit details -
Configuration menu - View commit details
-
Copy full SHA for d4733bb - Browse repository at this point
Copy the full SHA d4733bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5aec95d - Browse repository at this point
Copy the full SHA 5aec95dView commit details
Commits on Feb 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 2031bcb - Browse repository at this point
Copy the full SHA 2031bcbView commit details -
Configuration menu - View commit details
-
Copy full SHA for b160b43 - Browse repository at this point
Copy the full SHA b160b43View commit details
Commits on Feb 6, 2023
-
include extracted ulib/fs into binary package
this is currently also building the ulibfs nuget package and including it into the binary package
Configuration menu - View commit details
-
Copy full SHA for e2f334a - Browse repository at this point
Copy the full SHA e2f334aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e90266a - Browse repository at this point
Copy the full SHA e90266aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7769171 - Browse repository at this point
Copy the full SHA 7769171View commit details
Commits on Feb 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4eade93 - Browse repository at this point
Copy the full SHA 4eade93View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9654a0d - Browse repository at this point
Copy the full SHA 9654a0dView commit details -
Configuration menu - View commit details
-
Copy full SHA for c7685de - Browse repository at this point
Copy the full SHA c7685deView commit details -
Configuration menu - View commit details
-
Copy full SHA for 079babf - Browse repository at this point
Copy the full SHA 079babfView commit details -
Makefiles: tidy up info messages
Make a function in .common.mk to reduce duplication. Take the chance to change the shape of messages. Some other small fixes throughout.
Configuration menu - View commit details
-
Copy full SHA for c75c3b1 - Browse repository at this point
Copy the full SHA c75c3b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b15d92 - Browse repository at this point
Copy the full SHA 0b15d92View commit details -
Configuration menu - View commit details
-
Copy full SHA for d24c786 - Browse repository at this point
Copy the full SHA d24c786View commit details -
Configuration menu - View commit details
-
Copy full SHA for e9813c0 - Browse repository at this point
Copy the full SHA e9813c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a5692d - Browse repository at this point
Copy the full SHA 5a5692dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 468f832 - Browse repository at this point
Copy the full SHA 468f832View commit details -
Configuration menu - View commit details
-
Copy full SHA for f37e300 - Browse repository at this point
Copy the full SHA f37e300View commit details -
Configuration menu - View commit details
-
Copy full SHA for f5b7eb5 - Browse repository at this point
Copy the full SHA f5b7eb5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 248ecda - Browse repository at this point
Copy the full SHA 248ecdaView commit details
Commits on Feb 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 5d10f12 - Browse repository at this point
Copy the full SHA 5d10f12View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b8a190 - Browse repository at this point
Copy the full SHA 6b8a190View commit details -
Configuration menu - View commit details
-
Copy full SHA for bc9bfa0 - Browse repository at this point
Copy the full SHA bc9bfa0View commit details
Commits on Feb 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1f0c342 - Browse repository at this point
Copy the full SHA 1f0c342View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ab6859 - Browse repository at this point
Copy the full SHA 0ab6859View commit details -
Configuration menu - View commit details
-
Copy full SHA for 225c59d - Browse repository at this point
Copy the full SHA 225c59dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d5cf43 - Browse repository at this point
Copy the full SHA 6d5cf43View commit details -
Configuration menu - View commit details
-
Copy full SHA for 82d2e26 - Browse repository at this point
Copy the full SHA 82d2e26View commit details -
Configuration menu - View commit details
-
Copy full SHA for e957f44 - Browse repository at this point
Copy the full SHA e957f44View commit details
Commits on Feb 13, 2023
-
Co-authored-by: Lucas Franceschino <lucas@franceschino.fr> Co-authored-by: Tahina Ramananandro <taramana@microsoft.com>
Configuration menu - View commit details
-
Copy full SHA for 7a54d99 - Browse repository at this point
Copy the full SHA 7a54d99View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2cc1a6f - Browse repository at this point
Copy the full SHA 2cc1a6fView commit details
Commits on Feb 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8d1edab - Browse repository at this point
Copy the full SHA 8d1edabView commit details -
Configuration menu - View commit details
-
Copy full SHA for 056150a - Browse repository at this point
Copy the full SHA 056150aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ea6196 - Browse repository at this point
Copy the full SHA 7ea6196View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0730555 - Browse repository at this point
Copy the full SHA 0730555View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0fb05c9 - Browse repository at this point
Copy the full SHA 0fb05c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for c222f0f - Browse repository at this point
Copy the full SHA c222f0fView commit details -
Configuration menu - View commit details
-
Copy full SHA for c596682 - Browse repository at this point
Copy the full SHA c596682View commit details -
Configuration menu - View commit details
-
Copy full SHA for 08d68a5 - Browse repository at this point
Copy the full SHA 08d68a5View commit details -
- extracting F* requires ulib to be typechecked - fix the bootstrap derivation - enable parallel building - minor updates
Configuration menu - View commit details
-
Copy full SHA for 8e35a31 - Browse repository at this point
Copy the full SHA 8e35a31View commit details -
- Messages, silence rule - Avoid extraction of prims - Mark a PHONY
Configuration menu - View commit details
-
Copy full SHA for 5865554 - Browse repository at this point
Copy the full SHA 5865554View commit details -
Configuration menu - View commit details
-
Copy full SHA for cd076c6 - Browse repository at this point
Copy the full SHA cd076c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 571a668 - Browse repository at this point
Copy the full SHA 571a668View commit details -
Configuration menu - View commit details
-
Copy full SHA for d883f05 - Browse repository at this point
Copy the full SHA d883f05View commit details -
ocaml/dune: ignore all warnings
The -warn-error +N option is used to turn warnings into errors, and -warn-error -N reverts that process, but still retains the warning. To ignore a warning, we need `-w -N`. cc @tahina-pro
Configuration menu - View commit details
-
Copy full SHA for 7f99f6d - Browse repository at this point
Copy the full SHA 7f99f6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a914d7 - Browse repository at this point
Copy the full SHA 7a914d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for f1ca638 - Browse repository at this point
Copy the full SHA f1ca638View commit details -
Configuration menu - View commit details
-
Copy full SHA for c0a7927 - Browse repository at this point
Copy the full SHA c0a7927View commit details -
Configuration menu - View commit details
-
Copy full SHA for a108445 - Browse repository at this point
Copy the full SHA a108445View commit details -
Configuration menu - View commit details
-
Copy full SHA for de65146 - Browse repository at this point
Copy the full SHA de65146View commit details -
Configuration menu - View commit details
-
Copy full SHA for a297ac5 - Browse repository at this point
Copy the full SHA a297ac5View commit details -
Configuration menu - View commit details
-
Copy full SHA for e9a951e - Browse repository at this point
Copy the full SHA e9a951eView commit details -
checkedfiles: suppress not found warning for --lax
If we call fstar.exe --cache_checked_modules --lax A.fst we now get a warning that A.fst.checked.lax does not exist. This does not really make sense as we are trying to build the file, but `should_verify` return false, as we are in lax mode. So, use the weaker `should_check` instead. This removes the flurry of warning we get when lax-building the libraries (though that process is about to disappear).
Configuration menu - View commit details
-
Copy full SHA for d3e0aef - Browse repository at this point
Copy the full SHA d3e0aefView commit details
Commits on Feb 15, 2023
-
because FStar_Version.ml depends on version.txt outside of the dune snapshot, cf. ocaml/dune#5572
Configuration menu - View commit details
-
Copy full SHA for a7feb41 - Browse repository at this point
Copy the full SHA a7feb41View commit details
Commits on Feb 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6a26ef0 - Browse repository at this point
Copy the full SHA 6a26ef0View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.