Supporting incremental parsing and additional features in the IDE protocol in support of fstar-vscode-assistant #2853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikswamy
commented
Mar 22, 2023
| limitations under the License. | ||
| *) | ||
|
|
||
| module FStar.Interactive.Ide.Types |
There was a problem hiding this comment.
Refactoring several existing modules to put the types in one place, so that we can easily refer to them in other modules without introducing dependency cycles
nikswamy
commented
Mar 22, 2023
| | GenericError _ | ProtocolViolation _ | FullBuffer _ | Callback _ | Format _ -> false | ||
| | Push _ | AutoComplete _ | Lookup _ | Compute _ | Search _ -> true | ||
|
|
||
| let interactive_protocol_vernum = 2 |
There was a problem hiding this comment.
I explicitly did not increment the protocol version number. I only added new messages and did not want to break existing clients that may be relying on this protocol version number. I confirmed that fstar-mode.el continues to work.
nikswamy
commented
Mar 22, 2023
| and repl_stack_entry_t = repl_depth_t * (repl_task * repl_state) | ||
|
|
||
| // Global repl_state, keeping state of different buffers | ||
| type grepl_state = { grepl_repls: U.psmap repl_state; grepl_stdin: stream_reader } |
There was a problem hiding this comment.
Moved to FStar.Interactive.Ide.Types
…n in fstar-vscode-assistant
… long-standing bug
…load the extension symbol table
…incremental parsing
…d when cached for the IDE; fix incremental parsing of pragmas; strengthen test-interactive.py
|
Merging, works with the fstar-vscode-assistant edcc96df402bb617b1421e5a89cf3267e95ed956 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.