Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the
resolve_implicits
loop remember the solutions of typeclass arguments and reuse when the type of the implicit and the environment exactly match. It's pretty conservative, but easy to argue for its soundness and simple to implement, without any type of global persistent state.It doesn't do a big difference in most cases, though, in a snippet like:
we cannot reuse the solution since the environment in the second line is different, it is extended with an extra unit binding.