Tc: Allow for #_ to solve instances #3165
Merged
+354
−358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using typeclasses and there is a need to disambiguate one implicit out of many, say the 3rd, we either have to provide the dictionaries of the preceding args explicitly: f #_ #d_int #bool or call `solve` like f #int #solve #bool Since just using `#_` for the dictionary will fail, as it will try to be solved only by unification. This PR makes it so that using `#_` for an implicit that has a meta (tactic or attr) retains the meta, and is then solved exactly as if nothing was provided. Then we can disambiguate the function above as f #_ #_ #bool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using typeclasses and there is a need to disambiguate one implicit
out of many, say the 3rd, we either have to provide the dictionaries of
the preceding args explicitly:
or call
solvelikeSince just using
#_for the dictionary will fail, as it will try to besolved only by unification. This PR makes it so that using
#_for animplicit that has a meta (tactic or attr) retains the meta, and is then
solved exactly as if nothing was provided. Then we can disambiguate the
function above as