Fixing a normalizer inefficiency #3222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using physical equality is too strict/brittle, as a recent example of normalization time blowup reveals. Instead, attempt using physical equality but if that fails, compare the *steps* of both configs along with delta_level and the normalize_pure_lets field. These 3 are the only fields that can change and actually affect reduction, with the steps being the more important one.
|
Got a local green. merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #3072 fixed issue #2155 by adding a check
to make sure that, when trying to reuse a memoized value,
we check the current normalizer configuration matches the one used when the value was memoized.
Using physical equality is too strict/brittle, as a recent example of
normalization time blowup reveals. Instead, attempt using physical
equality but if that fails, compare the steps of both configs along
with delta_level and the normalize_pure_lets field. These 3 are
the only fields that can change and actually affect reduction, with
the steps being the more important one.
As a bonus I added more instances for deq, so
=?can be used on ids, lidents, delta_depth, and steps.I'll run a local everest build to see if this breaks anything.