Misc fixes (typeclasses, printing) #3294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mtzguido
commented
May 17, 2024
mtzguido
commented
- Make tcresolve solve trivial unit goals, which can show up
- Improve the fix for No resugaring of projections #3227 to consider nested applications, which should up pervasively in Pulse.
They may show up if instances happened to add a unit argument, like:
instance val has_range_syntax #a : unit -> Tot (hasRange (syntax a))
while it is really there for no reason (it's a pure definition anyway),
the resolution tactic should not be broken by such things.
Related to FStarLang#3227. Without this, this rule does not kick in for Pulse for any parametrized type, as the applications are nested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.