Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(syntax): any terms in meta arguments #3430

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

W95Psp
Copy link
Contributor

@W95Psp W95Psp commented Sep 3, 2024

This PR makes the following code typecheck. Before we had to add parenthesis. That's a super simple change and that's causing no regression in the parser! :)

let this_is_now_accepted
    (#[let _ = 1 in FStar.Tactics.exact ()]arg: unit)
    = ()

let before_you_had_to_write
    (#[(let _ = 1 in FStar.Tactics.exact ())]arg: unit)
    = ()

This PR makes the following code typecheck. Before we had to add
parenthesis. That's causing no regression in the parser!

```
let this_is_now_accepted
    (#[let _ = 1 in FStar.Tactics.exact ()]arg: unit)
    = ()

let before_you_had_to_write
    (#[(let _ = 1 in FStar.Tactics.exact ())]arg: unit)
    = ()
```
@mtzguido mtzguido force-pushed the allow-any-term-meta-argument branch from 5bbf68e to 8bf3b3d Compare September 3, 2024 16:30
@mtzguido
Copy link
Member

mtzguido commented Sep 3, 2024

Nice, thanks Lucas!

@mtzguido mtzguido merged commit 695b9ae into FStarLang:master Sep 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants