Util: fix mkdir for trailing slashes #3514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling F* as in ``` $ fstar.exe --cache_dir a/b/ wrong argument given to option `cache_dir` ``` when `a` does not yet exist, F* is supposed to attempt to create the directory, but it fails due to the trailing slash. The problem is that when mkdir raises an ENOENT, we attempt to create parent directories, but we are computing the parent of 'a/b/' to be 'a/b' (since we naively removed the last slash component). So the process is: - Try to mkdir a/b/, get ENOENT - Try to mkdir a/b, get ENOENT - Try to mkdir a, works - Retry mkdir a/b, works - Retry mkdir a/b/, fails since it already exists. This fixes the problem ignoring trailing slashes. Moving to a full, F*-based filename library would be a lot better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling F* as in
when
adoes not yet exist, F* is supposed to attempt to create the directory, but it fails due to the trailing slash. The problem is that when mkdir raises an ENOENT, we attempt to create parent directories, but we are computing the parent of 'a/b/' to be 'a/b' (since we naively removed the last slash component). So the process is:This fixes the problem ignoring trailing slashes. Moving to a full, F*-based filename library would be a lot better.