Extraction: not extracting tactics unless backend is Plugin #3542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Given that Pulse and HACL* are green (which use plugins), I think this should be safe so I'll merge it. Please shout if I broke something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an old wart, even with
--codegen OCamlwe are still extracting all tactics in the file, and only skipping their registration into the compiler as plugins. This is silly, since this function will never be called. This also means we cannot compile the module with a small fstar-lib meant for applications, which we want to do.This patch skips the extraction for anything in Tac, except when
--codegen Pluginwas given.Running a build here: https://github.com/mtzguido/FStar/actions/runs/11245452858