Preparing to use this F* as stage0 #3555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not belong in FStarC.Options, and prevents it from ever raising an error due to circular deps.
Just being safe for now, but would be the right thing if we add some format autodetection.
This makes more sense, albeit with some duplication, so the compiler does not depend on its "own" library.
…ffect.failwith -> failwith)
|
Happy to see this didn't break anything (though of course it shouldn't!). Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some refactoring and making sense of modules. Also, call extraction with --MLish so it translates
FStar_Compiler_Effect.failwithinto OCaml'sfailwith, which allows us to even remove the definition for it. Ideally this would be attribute-based, but this is already a lot better.