tests: rework makefiles #3578
Merged
tests: rework makefiles #3578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was meant to save some CI time, but means the tests run with a partial library, and this seems to be transitively included.
This is part of the new build, but self-contained enough to be merged before that. It unifies most makefiles in tests/ into a single mk/test.mk (mk is a new top-level directory for make infra). It also disconnects examples/ and tests/. The mutually recursive inclusions are hard to work with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the new build, but self-contained enough to be merged
before that. It unifies most makefiles in tests/ into a single
mk/test.mk (mk is a new top-level directory for make infra).
It also disconnects examples/ and tests/. The mutually recursive
inclusions are hard to work with.
One downside is putting ModifiesGen back into the ci-pre target, but it was honestly a hack to not have it there. Most tests expect to run with a fully checked library.