Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3616 #3621

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Fix #3616 #3621

merged 3 commits into from
Dec 4, 2024

Conversation

mtzguido
Copy link
Member

@mtzguido mtzguido commented Dec 4, 2024

Taking the suggestion from @TWal of adding zeta to the steps in reveal_opaque.

Note, this can cause issues when the function being revealed is recursive and not guarded by a pattern match. E.g.

let f () : Dv int = f ()

This will send the normalizer into a loop which will stack overflow. I don't think these are usual occurrences and this is a separate problem of the normalizer itself, so I think adding zeta is not too bad. When the recursion is under a match (almost always) this will block the unfolding and work OK.

@mtzguido
Copy link
Member Author

mtzguido commented Dec 4, 2024

@mtzguido mtzguido merged commit fd93201 into FStarLang:master Dec 4, 2024
3 checks passed
@mtzguido mtzguido deleted the 3616 branch December 4, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant