--ocamlenv: fix for Windows, cannot use exec #3627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OCaml's Unix module exposes an execv family of functions, which "seem" to work correctly on Windows, but have a critical discrepancy: the new process is not really replacing the current one, but instead being executed on the side, and the parent process will *not even wait* for the spawned process. This usually wreaks havoc. This PR replaces our use of execv by Unix.create_process + Unix.waitpid, both of which seem to work correctly on Windows too. See https://lacamb.re/blog/windows_ocaml_execvp.html Thanks @tahina-pro for figuring this out.
|
Running a windows build here https://github.com/FStarLang/FStar/actions/runs/12206833739 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OCaml's Unix module exposes an execv family of functions, which "seem" to work
correctly on Windows, but have a critical discrepancy: the new process
is not really replacing the current one, but instead being executed on
the side, and the parent process will not even wait for the spawned
process. This usually wreaks havoc.
This PR replaces our use of execv by Unix.create_process + Unix.waitpid,
both of which seem to work correctly on Windows too.
See https://lacamb.re/blog/windows_ocaml_execvp.html
Thanks @tahina-pro for figuring this out.