Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for loki #74

Merged
merged 2 commits into from
Jul 13, 2024
Merged

feat: add support for loki #74

merged 2 commits into from
Jul 13, 2024

Conversation

FUSAKLA
Copy link
Owner

@FUSAKLA FUSAKLA commented Jul 12, 2024

/resolves #69

Adds support for validating of loki rules
and adds two new validations for LogQL expressions

  • isValidLoqQLExpression
  • logQlExpressionUesesRangeAggreagationn

Also adds some documentation, e2e tests for loki etc

Signed-off-by: Martin Chodur m.chodur@seznam.cz

Signed-off-by: Martin Chodur <m.chodur@seznam.cz>
Signed-off-by: Martin Chodur <m.chodur@seznam.cz>
@FUSAKLA
Copy link
Owner Author

FUSAKLA commented Jul 12, 2024

PTAL @jmichalek132 if it makes sense to you and possibly what checks would you like to see for loki so I can say if this is the way how to approach it

@jmichalek132
Copy link

jmichalek132 commented Jul 13, 2024

PTAL @jmichalek132 if it makes sense to you and possibly what checks would you like to see for loki so I can say if this is the way how to approach it

This looks good to me, we are just starting to use loki internally within our team, so for now the generic validations + the query being valid and the yaml unmarshalling are the most important ones.
Down the line when we onboard other teams to use it I can imagine an useful validation outside of the generic ones could be for e.g. validating than the remote write config is not specified (I am not 100% sure, but I assume when it is it takes precedence over the configuration to the loki ruler itself which we might not want to allow).

Thank you for doing this :).

@FUSAKLA
Copy link
Owner Author

FUSAKLA commented Jul 13, 2024

Great 🎉

I'l merge it and would love some feedback if you could give it a try.

If merged you should be able to install it using the go install

@FUSAKLA FUSAKLA merged commit 4df80d6 into master Jul 13, 2024
3 checks passed
@jmichalek132
Copy link

Great 🎉

I'l merge it and would love some feedback if you could give it a try.

If merged you should be able to install it using the go install

I will on Monday :).

@jmichalek132
Copy link

Great 🎉
I'l merge it and would love some feedback if you could give it a try.
If merged you should be able to install it using the go install

I will on Monday :).

Tested today, it works nicely ;) looking forward to a release :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider implementing support for loki
2 participants