feat: disallow any unknown fields to prometheus and add new flags to support loki, thanos or mimir #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… flags to support loki, thanos or mimir Signed-off-by: Martin Chodur <m.chodur@seznam.cz>
|
Not sure about the flag naming 🤔 |
Signed-off-by: Martin Chodur <m.chodur@seznam.cz>
Signed-off-by: Martin Chodur <m.chodur@seznam.cz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #76
Till now, any custom fields of mimir, thanos or loki were silently tollerated, but that was not explicit a might lead to some issues.
From now on, only fields known to Prometheus are allowed by default and new flgs are added to explicitly support other systems
--support-loki--support-mimir--support-thanosAlso added tests for unmarshalling
Signed-off-by: Martin Chodur m.chodur@seznam.cz