-
-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IPv6 support for sv_downloadurl (sv_downloadurl_ipv6) #1577
Conversation
I'm not sure whether having two sv_downloadurl cvars is actually needed. In my idea, by having both AAAA and A DNS records on the same domain, the client would be free to choose whether it wants to use IPv6 connection or IPv4 connection. Also, the way svc_resourcelocation parser works, it actually allows multiple locations to be set, by listing all available URLs in |
The same goes for having multiple locations in It's the client's choice whether they want to use IPv6 or IPv4. |
DNS resolving does not work for me Parser of and what about:
Maybe I'm newbie, but I don't understand how to connect IPv6 but with this patch, posted as maybe useful. |
Well, just compiled and can confirm - everything works perfect: connections from IPv4 gives IPv4 in Example of
\o/ |
#1862 now allows the usage of IPv6 for HTTP resources location, by passing AF_UNSPEC to resolver and then passing resolved address family to But the idea is still the same: whatever resolver picks is going to be used here. |
Solution compatible with previous protocol / clients as implements new option
sv_downloadurl_ipv6
Details described in #1559
Client-side already tested - I can provide IPv6 links in
server.cfg
and download resources from there, but stuck on server-side part, as don't know how to check remote connection type and returnsv_downloadurl_ipv6
for IPv6 clients instead ofsv_downloadurl
Here is the subject with example:
#1559 (comment)