Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably, after commit [https://github.com//pull/106] I have noticed a negative impact on RichTextFx - during typing text in editor it starts "minimally" scrolling.
I see, that in mentioned commit there is
Math.round(offset)
inVirtualizedScrollPane
:But farther, when this action goes to
VirtualFlow
class - to method:The incoming
pixels
value is rounded, but value in variablecurrent
is not rounded, and when we computediff
:... there is very often computed value
0.5
(but it should be0
) and VirtualFlow moves visible content by thisdiff
(navigator.scrollCurrentPositionBy(diff)
) instead of// do nothing
My fix here is to apply rounding on
lengthOffsetEstimate
. This solves this issue.