Crop cells only if memorizedRange is bigger than expected range #94
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I added
VirtualFlow.visibleCells()
listener I'm receiving not ending stream of events, but visible cells list is not changing.The problem seemed to only affect lists where the cell is higher than the visible area (Maybe related to #80).
I think the problem may be in package
org.reactfx:reactfx:2.0-M5
:MemorizationListImpl.forget(int from, int to)
https://github.com/TomasMikula/ReactFX/blob/537fffdbb2958a77dfbca08b712bb2192862e960/reactfx/src/main/java/org/reactfx/collection/MemoizationList.java#L176
It publish events (
memoizedItems.fireRemoveRange(memoChangeFrom, memoRemoved)
) even ifmemoRemoved
list is empty.I'm not sure if this behavior in
reactfx
is good or wrong, but I found workaround to apply inFlowless
inCellListManager.cropTo(...)
toforget
items only whenmemorizedRange
is bigger then ourfromItem
-toItem
range.