Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added foldCheck skipping #1007

Merged
merged 1 commit into from
Mar 15, 2021
Merged

Added foldCheck skipping #1007

merged 1 commit into from
Mar 15, 2021

Conversation

Jugen
Copy link
Collaborator

@Jugen Jugen commented Mar 3, 2021

I've experienced CSS errors in production with regards to the new paragraph folding code, even though I don't use folding.

WARNING: Caught 'java.lang.ClassCastException: class java.lang.String cannot be cast to class javafx.scene.paint.Paint (java.lang.String is in module java.base of loader 'bootstrap'; javafx.scene.paint.Paint is in module javafx.graphics@11.0.6 of loader 'platform')' while converting value for '-fx-background-color' from rule '*.text-area' in stylesheet jrt:/javafx.controls/com/sun/javafx/scene/control/skin/caspian/caspian.bss
Oct 26, 2020 1:40:49 PM javafx.scene.CssStyleHelper calculateValue

I've narrowed down these errors to being triggered by the skipOverFoldedParagraphs method, which makes sense because before this PR it was being called whenever the paragraph index changes.

From the exception it's possible that this issue is confined to the Caspian theme only, and may not be triggered by Modena.
Unfortunately I don't know as I've never had this error in development and I don't know under which circumstances this exception occurs in production. So this PR is a safeguard because I haven't been able to determine why the CSS errors occur.

@Jugen Jugen merged commit f4b72cb into master Mar 15, 2021
@Jugen Jugen deleted the add-foldcheck-skip branch March 15, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant