Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented the proposed paragraph style feature (#6) #168

Merged
merged 3 commits into from
Oct 16, 2015

Conversation

MewesK
Copy link
Contributor

@MewesK MewesK commented Aug 20, 2015

This PR is WIP and a more of a basis for discussion. Like you described it adds "PS".

In the second commit is the way I propose to set those paragraph styles. To demonstrate it I added it in kind of lazy way to the RichText demo. At the moment the paragraph style vanishes after a text or style update but otherwise it should be complete.

I'll try to fix that bug over the weekend. But early feedback would be appreciated.

Implemented the proposed paragraph style feature (FXMisc#6)
RichText implementation finished
@MewesK
Copy link
Contributor Author

MewesK commented Aug 21, 2015

The bug should be fixed now. (hopefully)

Let me know what you think.

@TomasMikula
Copy link
Member

Thanks for the PR. Here are some quick comments:

This pull request is based on an outdated version of this repository and as you can see there are merge conflicts. Can you please first merge branch TomasMikula:master into your branch? As you will see, you have duplicated much of the same work as me on the RichText demo.

If you find out that you need or want to do some preparatory refactoring (such as moving StyledTextAreaView into its own source file), please do so in a separate commit and potentially even submit a separate pull request for it first. That will then make it easier to see what was changed in the "feature" pull request. (I now for example cannot see what parts of StyledTextAreaView were modified and what was just copy/paste.)

Paragraph is immutable and I'm convinced it should stay so. The implication is that there can be no paragraphStyle property on Paragraph, just a final field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants