Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the -rtfx prefix for RichTextFX specific underline properties, us… #324

Merged
merged 1 commit into from
Jun 10, 2016

Conversation

afester
Copy link
Collaborator

@afester afester commented Jun 10, 2016

…e the underline width as the toggle to enable/disable the underline

…e the underline width as the toggle to enable/disable the underline
@afester afester mentioned this pull request Jun 10, 2016
@TomasMikula
Copy link
Member

Cool, thanks!

@TomasMikula TomasMikula merged commit 9bb46ac into FXMisc:master Jun 10, 2016
@JordanMartinez
Copy link
Contributor

I've updated the CSS guide to use the updated prefix.

@TomasMikula
Copy link
Member

Great, thanks @JordanMartinez !

@JordanMartinez
Copy link
Contributor

No problem!

Quick question @TomasMikula TextExt also has the CSS property -fx-background-fill. Could you clarify: is this used internally (and thus shouldn't be included in the guide) or another part of the text that can be styled (and thus should be in the guide and also use the -rtfx prefix)?

@TomasMikula
Copy link
Member

Good catch! It is meant to be used by users. So it should be renamed to -rtfx and included in the guide. At that occasion, we might as well rename it to -rtfx-background-color, since the only reason it was called -fill instead of -color was JDK-8133685.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants