Add feature: get character bounds on screen #455
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few questions I have:
selectionShape
be used to get the bounds? Will that switch-out approach cause any issues later on? I didn't want to create a newPath
object each time the method is called so as to reduce memory usage.FORWARD
bias inendPosition = offsetToPosition(to, Bias.FORWARD)
. Is that correct? Or should it beBACKWARD
? I still don't understand how that part of the code works.