Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First iteration to have code compile on both Jdk8 and 9 #618

Closed
wants to merge 2 commits into from

Conversation

afester
Copy link
Collaborator

@afester afester commented Oct 16, 2017

This is work in progress.
Opened for further discussion
Do not merge.

This approach runs through the Java8 and Java9 compiler using the grade build. It uses two separate hierarchies for Java8 and Java9 specific files. The gradle build automatically detects the used JDK and selects the appropriate source folder.

Pending:

  • Integration tests fail with Java9
    • Need to replace testfx-internal-java8 with testfx-internal-java9 - after doing this manually, only 11 tests still fail (108 Runs/10 Skipped/11 Failures)
  • Demos not yet tested
  • Source files are duplicated between Java8 and Java9. Need to pull out the common code.
  • Eclipse integration ("gradle eclipse") does not seem to select the additional source folder yet

Later, this approach could be extended to support the Java9 multi release jar approach for packaging by moving the created class files into the appropriate folders below META-INF.

@JordanMartinez
Copy link
Contributor

This relates to #270 (adding this comment so it shows up there, too).

@afester
Copy link
Collaborator Author

afester commented Oct 23, 2017

Already done with #614

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants