-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added line highlighter enhancement #845
Conversation
This works great, thanks for adding it. There is just one issue though, if the line is empty, if the paragraph has zero length, then the highlight isn't shown. |
Just one other thing, if the line highlight paint is set it is overriding the default text selection paint. In my stylesheet I have:
And am setting the line highlight paint via code, thus:
Any selected text on that line has a red background rather than blue thus masking what text is selected. |
Ok, I've made some changes that hopefully resolve the issues you reported. |
Yes that fixed both issues. Thanks. |
Found another issue with this I'm afraid. The highlight can sometimes be "half" applied. In the screenshot below you can see that the line highlight is only partially rendered. This is on a wrapping line and occurs after I resize (by a splitpane dragger) the left hand component to be larger. The text area contracts but the highlight will often not be fully rendered. Moving the caret to another line renders the highlight properly. |
Thanks, I've fixed this. |
This PR is for RFE #841 adding the following API to GenericStyledArea:
The highlighter can be styled via CSS using selectors from Path, Shape, and Node. For example:
Any added custom Selections can now also be styled via CSS using the selection's name.