Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connectivity data feature bug: some col_names != row_names #162

Closed
xgui3783 opened this issue Mar 2, 2022 · 0 comments
Closed

connectivity data feature bug: some col_names != row_names #162

xgui3783 opened this issue Mar 2, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@xgui3783
Copy link
Member

xgui3783 commented Mar 2, 2022

as of 0.3a16

to reproduce:

from siibra.features.connectivity import (
    PrereleasedStreamlineCountQuery,
)
features = PrereleasedStreamlineCountQuery().features
matrices = [feat.matrix for feat in features]

expected, matrices loads without issues

actual: several cannot be loaded due to

assertion error: expected col_names == row_names

Here is a printout of all datasets that trigger this issue:

XFAIL test/features/test_connectivity.py::test_conn_to_model[conn_feat3]
  reason: Averaged_SC_JuBrain_184Regions_HCP_10M_count_MEAN assertion error: expected col_names == row_names
XFAIL test/features/test_connectivity.py::test_conn_to_model[conn_feat4]
  reason: Averaged_SC_JuBrain_184Regions_eNKI_10M_count_MEAN assertion error: expected col_names == row_names
XFAIL test/features/test_connectivity.py::test_conn_to_model[conn_feat7]
  reason: Averaged_SC_JuBrain_184Regions_HCP_10M_length_MEAN assertion error: expected col_names == row_names
XFAIL test/features/test_connectivity.py::test_conn_to_model[conn_feat8]
  reason: Averaged_SC_JuBrain_184Regions_eNKI_10M_length_MEAN assertion error: expected col_names == row_names
XFAIL test/features/test_connectivity.py::test_conn_to_model[conn_feat11]
  reason: Averaged_FC_JuBrain_184Regions_HCP_REST_FIX_AVER_MEAN assertion error: expected col_names == row_names
XFAIL test/features/test_connectivity.py::test_conn_to_model[conn_feat12]
  reason: Averaged_FC_JuBrain_184Regions_HCP_REST_FIX_CONCAT_MEAN assertion error: expected col_names == row_names
XFAIL test/features/test_connectivity.py::test_conn_to_model[conn_feat13]
  reason: Averaged_FC_JuBrain_184Regions_eNKI_REST_FIX_MEAN assertion error: expected col_names == row_names
@xgui3783 xgui3783 added the bug Something isn't working label Mar 2, 2022
@xgui3783 xgui3783 changed the title connectivity data feature bug: some col_names != row_names [0.4] connectivity data feature bug: some col_names != row_names Jan 23, 2023
@xgui3783 xgui3783 changed the title [0.4] connectivity data feature bug: some col_names != row_names connectivity data feature bug: some col_names != row_names Jan 23, 2023
AhmetNSimsek added a commit that referenced this issue Apr 20, 2023
connectivity assert col_names == row_names (#162)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants