Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get connectivity features' resting-state paradigm from configs #275

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

AhmetNSimsek
Copy link
Collaborator

While the paradigm data is stored in the preconfigs, it was being replaced with the string "Resting State". The paradigm provides important information when it is provided, so this PR allows siibra to take it from the jsons.

@codecov-commenter
Copy link

Codecov Report

Merging #275 (75306e1) into main (5d8f673) will increase coverage by 0.13%.
The diff coverage is 37.38%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #275      +/-   ##
==========================================
+ Coverage   35.75%   35.89%   +0.13%     
==========================================
  Files          59       59              
  Lines        4984     5032      +48     
==========================================
+ Hits         1782     1806      +24     
- Misses       3202     3226      +24     
Impacted Files Coverage Δ
siibra/configuration/factory.py 26.06% <0.00%> (ø)
siibra/core/concept.py 77.21% <ø> (ø)
siibra/core/region.py 40.32% <ø> (ø)
siibra/core/space.py 67.50% <ø> (ø)
siibra/features/basetypes/feature.py 34.90% <0.00%> (-0.34%) ⬇️
siibra/features/basetypes/regional_connectivity.py 21.29% <ø> (ø)
siibra/features/basetypes/tabular.py 30.00% <ø> (ø)
siibra/features/basetypes/volume_of_interest.py 41.93% <0.00%> (-2.19%) ⬇️
siibra/locations/point.py 26.92% <ø> (ø)
siibra/retrieval/datasets.py 48.43% <ø> (ø)
... and 14 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@xgui3783 xgui3783 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AhmetNSimsek AhmetNSimsek merged commit 7c8923f into main Feb 17, 2023
@AhmetNSimsek AhmetNSimsek deleted the fixRestingStateParadigm branch February 17, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants