Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update schema #303

Merged
merged 4 commits into from
Mar 17, 2023
Merged

chore: update schema #303

merged 4 commits into from
Mar 17, 2023

Conversation

xgui3783
Copy link
Member

No description provided.

@AhmetNSimsek
Copy link
Collaborator

LGTM

@xgui3783
Copy link
Member Author

@AhmetNSimsek shouldn't the type be generic like tabular/timeseries rather than specific like tabular/activity_timeseries/bold ?

@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2023

Codecov Report

Merging #303 (578135a) into main (5d8f673) will increase coverage by 0.16%.
The diff coverage is 40.73%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #303      +/-   ##
==========================================
+ Coverage   35.75%   35.92%   +0.16%     
==========================================
  Files          59       59              
  Lines        4984     5175     +191     
==========================================
+ Hits         1782     1859      +77     
- Misses       3202     3316     +114     
Impacted Files Coverage Δ
siibra/core/region.py 40.08% <0.00%> (-0.25%) ⬇️
siibra/core/space.py 67.50% <ø> (ø)
siibra/features/connectivity/__init__.py 100.00% <ø> (+20.00%) ⬆️
siibra/retrieval/cache.py 58.20% <0.00%> (-4.70%) ⬇️
siibra/configuration/factory.py 22.64% <12.50%> (-3.43%) ⬇️
siibra/features/__init__.py 37.50% <16.66%> (-51.39%) ⬇️
siibra/volumes/nifti.py 18.91% <16.66%> (-0.53%) ⬇️
siibra/volumes/sparsemap.py 15.45% <16.66%> (-0.26%) ⬇️
siibra/volumes/parcellationmap.py 37.13% <25.00%> (+1.59%) ⬆️
siibra/features/feature.py 29.16% <29.16%> (ø)
... and 40 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AhmetNSimsek
Copy link
Collaborator

@AhmetNSimsek shouldn't the type be generic like tabular/timeseries rather than specific like tabular/activity_timeseries/bold ?

You have a good point. It stemmed from not knowing the nature of other tabular timeseries data. But if a chance is necessary, it could be changed then.
I'll make a commit to change it.

@AhmetNSimsek
Copy link
Collaborator

features/timseries as config folder is not the best option. Timeseries features will be divided into two: activity and image(fMRI). While activity is tabular image is not. These should be disinguished. Within siibra hierarchy this is easy as you had mentioned: siibra.tabular.timeseries but config should reflect the difference.

@xgui3783
Copy link
Member Author

So timeseries/activity for now?

@xgui3783 xgui3783 merged commit 7ce37ee into main Mar 17, 2023
@xgui3783 xgui3783 deleted the feat_updateSchema branch March 17, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants