-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update schema #303
chore: update schema #303
Conversation
LGTM |
@AhmetNSimsek shouldn't the type be generic like |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #303 +/- ##
==========================================
+ Coverage 35.75% 35.92% +0.16%
==========================================
Files 59 59
Lines 4984 5175 +191
==========================================
+ Hits 1782 1859 +77
- Misses 3202 3316 +114
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
You have a good point. It stemmed from not knowing the nature of other tabular timeseries data. But if a chance is necessary, it could be changed then. |
features/timseries as config folder is not the best option. Timeseries features will be divided into two: activity and image(fMRI). While activity is tabular image is not. These should be disinguished. Within siibra hierarchy this is easy as you had mentioned: |
So |
No description provided.