Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docstring to livequery #337

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Add docstring to livequery #337

merged 1 commit into from
Apr 20, 2023

Conversation

xgui3783
Copy link
Member

chore: typo, simplify list

chore: typo, simplify list
@xgui3783 xgui3783 requested a review from dickscheid April 17, 2023 11:07
@xgui3783 xgui3783 marked this pull request as ready for review April 17, 2023 11:08
@codecov-commenter
Copy link

Codecov Report

Merging #337 (d9731a5) into main (128cff9) will increase coverage by 0.03%.
The diff coverage is 21.05%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #337      +/-   ##
==========================================
+ Coverage   36.07%   36.11%   +0.03%     
==========================================
  Files          60       60              
  Lines        5303     5317      +14     
==========================================
+ Hits         1913     1920       +7     
- Misses       3390     3397       +7     
Impacted Files Coverage Δ
siibra/configuration/factory.py 22.47% <ø> (ø)
siibra/volumes/parcellationmap.py 37.13% <0.00%> (ø)
siibra/features/feature.py 30.25% <22.22%> (+1.08%) ⬆️

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AhmetNSimsek AhmetNSimsek added the maintenance Not a bug or breaking issue. Code maintenance related. label Apr 18, 2023
@AhmetNSimsek AhmetNSimsek changed the title chore: add docstring to livequery Add docstring to livequery Apr 18, 2023
@AhmetNSimsek AhmetNSimsek merged commit ee91ba4 into main Apr 20, 2023
@AhmetNSimsek AhmetNSimsek deleted the chore_docSerializeQueryCtx branch April 20, 2023 10:30
@dickscheid
Copy link
Contributor

much better readable now. Ok for me to merge. We will revisit this after profiling live queries, according to yesterday's discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Not a bug or breaking issue. Code maintenance related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants