Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve map shape and dtype when a map is merged #341

Merged
merged 4 commits into from
Apr 21, 2023

Conversation

AhmetNSimsek
Copy link
Collaborator

Solves #302

After review, the same should be applied to neuroglancer.

@AhmetNSimsek AhmetNSimsek requested a review from dickscheid April 19, 2023 14:08
@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2023

Codecov Report

Merging #341 (3bf2547) into main (3426085) will increase coverage by 0.20%.
The diff coverage is 30.86%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #341      +/-   ##
==========================================
+ Coverage   35.87%   36.07%   +0.20%     
==========================================
  Files          60       60              
  Lines        5315     5316       +1     
==========================================
+ Hits         1907     1918      +11     
+ Misses       3408     3398      -10     
Impacted Files Coverage Δ
siibra/__init__.py 66.66% <ø> (ø)
siibra/configuration/factory.py 22.47% <0.00%> (ø)
siibra/core/atlas.py 84.48% <ø> (ø)
...bra/features/connectivity/regional_connectivity.py 21.29% <0.00%> (+0.38%) ⬆️
...a/features/tabular/regional_timeseries_activity.py 28.75% <ø> (ø)
siibra/retrieval/requests.py 44.40% <0.00%> (ø)
siibra/volumes/neuroglancer.py 21.42% <0.00%> (ø)
siibra/volumes/nifti.py 18.91% <0.00%> (ø)
siibra/configuration/configuration.py 42.35% <11.11%> (-1.03%) ⬇️
siibra/volumes/parcellationmap.py 36.93% <33.33%> (-0.20%) ⬇️
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

siibra/volumes/nifti.py Outdated Show resolved Hide resolved
siibra/volumes/nifti.py Outdated Show resolved Hide resolved
@AhmetNSimsek AhmetNSimsek merged commit d31b0ea into main Apr 21, 2023
@AhmetNSimsek AhmetNSimsek deleted the preserve_map_shape_and_dtype_on_merge branch April 21, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants