Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove overriding assigned point scores #351

Merged
merged 4 commits into from
Apr 21, 2023
Merged

Conversation

AhmetNSimsek
Copy link
Collaborator

@AhmetNSimsek AhmetNSimsek commented Apr 20, 2023

Fixes #338
(Also, improves performance)

@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2023

Codecov Report

Merging #351 (8079571) into main (44a0ca0) will decrease coverage by 10.89%.
The diff coverage is 36.29%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##             main     #351       +/-   ##
===========================================
- Coverage   47.11%   36.22%   -10.89%     
===========================================
  Files         160       60      -100     
  Lines        6843     5333     -1510     
===========================================
- Hits         3224     1932     -1292     
+ Misses       3619     3401      -218     
Impacted Files Coverage Δ
siibra/locations/boundingbox.py 19.88% <19.88%> (ø)
...bra/features/connectivity/regional_connectivity.py 21.29% <21.29%> (ø)
siibra/configuration/factory.py 22.47% <22.47%> (ø)
siibra/features/anchor.py 23.74% <23.74%> (ø)
siibra/livequeries/ebrains.py 25.00% <25.00%> (ø)
siibra/livequeries/allen.py 26.31% <26.31%> (ø)
siibra/locations/point.py 26.92% <26.92%> (ø)
siibra/features/tabular/cell_density_profile.py 27.10% <27.10%> (ø)
...a/features/tabular/receptor_density_fingerprint.py 28.20% <28.20%> (ø)
siibra/features/feature.py 30.25% <28.57%> (-35.36%) ⬇️
... and 36 more

... and 21 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AhmetNSimsek AhmetNSimsek requested a review from xgui3783 April 20, 2023 16:03
test: add assertion to containedness in example
maint: add typing to sparsemap._assign_image
@AhmetNSimsek AhmetNSimsek merged commit 8da0930 into main Apr 21, 2023
@AhmetNSimsek AhmetNSimsek deleted the fixPointAssignment branch April 21, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Region assignment: None in containedness despite point uncertainty
3 participants