Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: getTVInfo #198

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Fix: getTVInfo #198

merged 2 commits into from
Jul 24, 2024

Conversation

FLIKI
Copy link
Contributor

@FLIKI FLIKI commented Jul 21, 2024

A new mechanism for retrieving TV episodes is needed due to changes in the IMDb layout.

A new mechanism for retrieving TV episodes is needed due to changes in the IMDb layout.
@FabianBeiner
Copy link
Owner

Thanks for this fix. Can you please try to stick to the coding style (which is wild, I know, but at least try to use camelCase and stuff like that)? Besides, instead of a hard-coded 'n/A', please use self::$sNotFound. I'll merge it afterward.

@FLIKI
Copy link
Contributor Author

FLIKI commented Jul 24, 2024

I changed the variables and the defaults. There is probably a cleaner way to write the 'set defaults', but this also works.

@FabianBeiner
Copy link
Owner

I changed the variables and the defaults. There is probably a cleaner way to write the 'set defaults', but this also works.

That whole codebase is anything but clean, so this will do it. Thanks! ;)

@FabianBeiner FabianBeiner merged commit 0e3d17e into FabianBeiner:main Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants