-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make Rails 7.0 applicable #5
Conversation
@@ -7,7 +7,7 @@ on: | |||
branches: [master] | |||
|
|||
env: | |||
BUNDLE_VERSION: 1.17.3 | |||
BUNDLE_VERSION: 2.4.21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the five major repositories have been updated to 2.4.21, we will align this one as well.
5 大リポジトリが 2.4.21 になっていたのでこちらも合わせる
@@ -18,7 +18,7 @@ jobs: | |||
- name: Setup Ruby, JRuby and TruffleRuby | |||
uses: ruby/setup-ruby@v1 | |||
with: | |||
ruby-version: 2.6 | |||
ruby-version: 2.7.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since Rails 7 requires Ruby 2.7 or higher, I updated to the latest version of 2.7.
Rails 7 は Ruby 2.7 以上が必要なので 2.7 の最新にした
@@ -1 +1 @@ | |||
2.6.9 | |||
2.7.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
appraise 'railties42' do | ||
gem 'railties', '~> 4.2.0' | ||
end | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the unused Rails versions.
lib/multi_cache/version.rb
Outdated
@@ -1,5 +1,5 @@ | |||
module MultiCache | |||
module Rails | |||
VERSION = '5.2.5' | |||
VERSION = '5.2.6' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the past, various versioning methods were used without any apparent rules, so to keep things simple, I opted for a patch version update
過去に色々なバージョンの切り方をされておりルールがなさそうだったので面倒だからパッチバージョンアップにしておいた
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
と思ったけど engine 側で ~> 5.2.0
となっており、Rails 7 アップデートと共にこの gem も上げたいのでマイナーバージョンを上げる事にした
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
LGTM again |
The git tags were created manually.
The release notes were manually created as well, based on the existing ones https://github.com/Fablic/multi-cache-rails/releases/tag/v5.3.0 |
This updates the gem usable with Rails 7.0 or above.