Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Rails 7.0 applicable #5

Merged
merged 6 commits into from
Jul 8, 2024
Merged

make Rails 7.0 applicable #5

merged 6 commits into from
Jul 8, 2024

Conversation

kanipan
Copy link
Member

@kanipan kanipan commented Jul 2, 2024

This updates the gem usable with Rails 7.0 or above.

@@ -7,7 +7,7 @@ on:
branches: [master]

env:
BUNDLE_VERSION: 1.17.3
BUNDLE_VERSION: 2.4.21
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the five major repositories have been updated to 2.4.21, we will align this one as well.
5 大リポジトリが 2.4.21 になっていたのでこちらも合わせる

@@ -18,7 +18,7 @@ jobs:
- name: Setup Ruby, JRuby and TruffleRuby
uses: ruby/setup-ruby@v1
with:
ruby-version: 2.6
ruby-version: 2.7.8
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Rails 7 requires Ruby 2.7 or higher, I updated to the latest version of 2.7.
Rails 7 は Ruby 2.7 以上が必要なので 2.7 の最新にした

@@ -1 +1 @@
2.6.9
2.7.8
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

appraise 'railties42' do
gem 'railties', '~> 4.2.0'
end

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the unused Rails versions.

@@ -1,5 +1,5 @@
module MultiCache
module Rails
VERSION = '5.2.5'
VERSION = '5.2.6'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the past, various versioning methods were used without any apparent rules, so to keep things simple, I opted for a patch version update
過去に色々なバージョンの切り方をされておりルールがなさそうだったので面倒だからパッチバージョンアップにしておいた

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

と思ったけど engine 側で ~> 5.2.0 となっており、Rails 7 アップデートと共にこの gem も上げたいのでマイナーバージョンを上げる事にした

@kanipan kanipan requested review from icer7 and nagamine-r July 4, 2024 04:47
Copy link

@nagamine-r nagamine-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@icer7 icer7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@icer7 icer7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nagamine-r
Copy link

LGTM again

@kanipan kanipan merged commit 965da51 into master Jul 8, 2024
3 checks passed
@kanipan
Copy link
Member Author

kanipan commented Jul 8, 2024

The git tags were created manually.
タグは手動で作った

$ git checkout master
$ git pull --rebase origin master
$ git tag v5.3.0
$ git push origin v5.3.0

The release notes were manually created as well, based on the existing ones
リリースノートも既存のものを参考に手動で作った

https://github.com/Fablic/multi-cache-rails/releases/tag/v5.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants