Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated steps both in English and Japanese versions #1653

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Updated steps both in English and Japanese versions #1653

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f15a3a1
modifed steps
kodai-t May 30, 2024
89ea84a
Update steps_jp.md
kodai-t May 30, 2024
b37692f
Update steps_jp.md
kodai-t May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion steps_en.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ Create CRUD to manage the tasks. First of all, let's make it with a simple struc
**Note**: Remove the `webdrivers` gem from your Gemfile. If `webdrivers` is present, it will attempt to find Chrome in your application’s container.
As Chrome isn’t installed in the Dockerfile, the spec will fail.

- Before start testing we need to register a new driver with Capybara that is configured to use the Selenium container, add the below codes to
- If you are using Docker, before start testing we need to register a new driver with Capybara that is configured to use the Selenium container, add the below codes to
`spec/rails_helper.rb`
```
Capybara.register_driver :remote_chrome do |app|
Expand Down
2 changes: 1 addition & 1 deletion steps_jp.md
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

そもそも ステップ8: テスト(system spec)を書こう の冒頭が英語なのがおかしいので、申し訳ないんですがついでに日本語に書き換えてもらえますか 🙏

Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ chrome://extensions/ を開いて右上のDeveloper modeをオンにして、RKG
**Note**: Remove the `webdrivers` gem from your Gemfile. If `webdrivers` is present, it will attempt to find Chrome in your application’s container.
As Chrome isn’t installed in the Dockerfile, the spec will fail.

- Before start testing we need to register a new driver with Capybara that is configured to use the Selenium container, add the below codes to
- If you are using Docker, before start testing we need to register a new driver with Capybara that is configured to use the Selenium container, add the below codes to
`spec/rails_helper.rb`
```
Capybara.register_driver :remote_chrome do |app|
Expand Down
Loading