Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opening the rename box for MinecraftVersion and pressing enter without changing the name causes "Name is not unique" error #246

Closed
2xsaiko opened this issue May 19, 2020 · 1 comment · Fixed by #299
Closed

Opening the rename box for MinecraftVersion and pressing enter without changing the name causes "Name is not unique" error #246

2xsaiko opened this issue May 19, 2020 · 1 comment · Fixed by #299
Assignees
@2xsaiko
Labels
bug

Comments

@2xsaiko
Copy link
Collaborator

2xsaiko commented May 19, 2020

Screenshot is from my tabs PR branch (#238), but the same issue occurs in 2b906a2, just the error message is different ("Name is not unique!"). Issue occurs with FabricMC/yarn@bfbea64

This does not occur with any other class as far as I'm aware.

image
@Runemoro Runemoro added the bug label May 20, 2020
@2xsaiko 2xsaiko self-assigned this Jun 19, 2020
@thiakil thiakil mentioned this issue Jul 19, 2020
Merged
@NickAcPT NickAcPT mentioned this issue Oct 1, 2020
Open
2xsaiko added a commit to 2xsaiko/Enigma that referenced this issue Oct 2, 2020
@2xsaiko
Fix resetting name not actually removing it, and renaming a class cau…
ef1c6d7 
…sing name collisions with itself

Closes FabricMC#246.
@2xsaiko
Copy link
Collaborator Author

2xsaiko commented Oct 27, 2020

Reopening because the PR that fixed this was reverted due to not 100% working

@2xsaiko 2xsaiko reopened this Oct 27, 2020
2xsaiko added a commit to 2xsaiko/Enigma that referenced this issue Mar 25, 2021
@2xsaiko
Fix resetting name not actually removing it, and renaming a class cau…
121532a 
…sing name collisions with itself

Closes FabricMC#246.
2xsaiko added a commit to 2xsaiko/Enigma that referenced this issue Jul 5, 2021
@2xsaiko
Fix resetting name not actually removing it, and renaming a class cau…
93a6f36 
…sing name collisions with itself

Closes FabricMC#246.
2xsaiko added a commit to 2xsaiko/Enigma that referenced this issue Jul 5, 2021
@2xsaiko
Fix resetting name not actually removing it, and renaming a class cau…
fc53f65 
…sing name collisions with itself

Closes FabricMC#246.
@2xsaiko 2xsaiko closed this as completed in 8efb624 Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@2xsaiko 2xsaiko

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Validation improvements thiakil/Enigma
2 participants
@Runemoro @2xsaiko