Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub workflow for markdownlint #101

Merged
merged 6 commits into from
Jun 15, 2024
Merged

Add GitHub workflow for markdownlint #101

merged 6 commits into from
Jun 15, 2024

Conversation

its-miroma
Copy link
Member

No description provided.

@its-miroma its-miroma requested review from a team as code owners May 12, 2024 18:55
Copy link

netlify bot commented May 12, 2024

Deploy Preview for nimble-elf-d9d491 ready!

Name Link
🔨 Latest commit 768d001
🔍 Latest deploy log https://app.netlify.com/sites/nimble-elf-d9d491/deploys/666cc957e1e11500087187d8
😎 Deploy Preview https://deploy-preview-101--nimble-elf-d9d491.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@IMB11 IMB11 added improvement A new addition to an already existing page framework Related to the website's framework (Vitepress) labels May 12, 2024
.github/workflows/markdownlint.yml Outdated Show resolved Hide resolved
.github/workflows/markdownlint.yml Outdated Show resolved Hide resolved
.github/workflows/markdownlint.yml Outdated Show resolved Hide resolved
@its-miroma its-miroma requested a review from modmuss50 May 13, 2024 06:57
@IMB11 IMB11 added the stage:ready This is ready to be merged label May 25, 2024
@IMB11
Copy link
Member

IMB11 commented May 25, 2024

LGTM, #99 has been merged.

.github/workflows/markdownlint.yml Outdated Show resolved Hide resolved
.github/workflows/markdownlint.yml Show resolved Hide resolved
Copy link
Member

@IMB11 IMB11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment by modmuss on linting everything.

IMB11
IMB11 previously approved these changes Jun 13, 2024
@IMB11
Copy link
Member

IMB11 commented Jun 13, 2024

This seems good, LGTM.

@IMB11 IMB11 requested a review from modmuss50 June 13, 2024 16:55
@IMB11 IMB11 merged commit fde5197 into FabricMC:main Jun 15, 2024
6 checks passed
@its-miroma its-miroma deleted the action branch June 20, 2024 11:09
JR1811 pushed a commit to JR1811/fabric-docs that referenced this pull request Jul 17, 2024
* Add GitHub workflow for `markdownlint`

* Add `MD054` rule

* Add version numbers

* Simplify logic

- Only exclude `ŧranslated` files
- Only lint with `markdownlint-rule-titlecase`

* Lint all files, not only changed files

* Allow all HTML elements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework Related to the website's framework (Vitepress) improvement A new addition to an already existing page stage:ready This is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants