Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Entities article #238

Merged
merged 4 commits into from
Dec 30, 2024
Merged

Block Entities article #238

merged 4 commits into from
Dec 30, 2024

Conversation

natri0
Copy link
Contributor

@natri0 natri0 commented Dec 30, 2024

Describes how to:

  • register & create a block entity
  • 'bind' it to the block w/ BlockEntityProvider / BlockWithEntity
  • serialize/deserialize & use custom fields in the block entity
  • tick

(Maybe) To do:

  • custom rendering w/ BlockEntityRenderer
  • handled screens
  • networking
  • data components
  • container blocks

Also, idk if the article/code should be copied to 1.20.4 if there's pretty much nothing changed as far as i can tell.

Describes how to:
- register & create a block entity
- 'bind' it to the block w/ BlockEntityProvider / BlockWithEntity
- serialize/deserialize & use custom fields in the block entity
- tick

To do:
- rendering
- handled screens
- networking
- data components

Spotless & Checkstyle checks passed.
@natri0 natri0 requested a review from a team as a code owner December 30, 2024 12:10
Copy link

netlify bot commented Dec 30, 2024

Deploy Preview for nimble-elf-d9d491 ready!

Name Link
🔨 Latest commit 9dd4349
🔍 Latest deploy log https://app.netlify.com/sites/nimble-elf-d9d491/deploys/67729866c567130008dacc77
😎 Deploy Preview https://deploy-preview-238--nimble-elf-d9d491.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@its-miroma its-miroma added new-content A new page or set of pages stage:verification This should be verified labels Dec 30, 2024
@its-miroma its-miroma linked an issue Dec 30, 2024 that may be closed by this pull request
@its-miroma

This comment was marked as outdated.

IMO, they were
- too long (some didn't fit in the table-of-contents)
- too similar (links back to the previous one, you couldn't see which one was "Creating and Registering the Block Entity" and which "Creating and Registering the Block")
@IMB11
Copy link
Member

IMB11 commented Dec 30, 2024

custom rendering w/ BlockEntityRenderer
handled screens
networking
data components
container blocks

These can be subpages, no need to do them in this PR - this is a great start, i'll have a look at it now.

@IMB11
Copy link
Member

IMB11 commented Dec 30, 2024

Also, you don't need to backport changes to previous versions, the older versions are set in stone and are not really meant to be expanded upon.

Copy link
Member

@IMB11 IMB11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good structure, just a few minor changes i'd suggest.

develop/blocks/block-entities.md Outdated Show resolved Hide resolved
develop/blocks/block-entities.md Outdated Show resolved Hide resolved
develop/blocks/block-entities.md Outdated Show resolved Hide resolved
develop/blocks/block-entities.md Outdated Show resolved Hide resolved
develop/blocks/block-entities.md Show resolved Hide resolved
@IMB11 IMB11 added stage:cleanup This should be cleaned up and removed stage:verification This should be verified labels Dec 30, 2024
@IMB11 IMB11 added this to the Update to 1.21.4 milestone Dec 30, 2024
@IMB11 IMB11 added stage:ready This is ready to be merged and removed stage:cleanup This should be cleaned up labels Dec 30, 2024
@IMB11 IMB11 merged commit 4871192 into FabricMC:main Dec 30, 2024
7 checks passed
@IMB11 IMB11 mentioned this pull request Dec 30, 2024
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-content A new page or set of pages stage:ready This is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Developer Guides: Block Entities
3 participants