-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Entities article #238
Conversation
Describes how to: - register & create a block entity - 'bind' it to the block w/ BlockEntityProvider / BlockWithEntity - serialize/deserialize & use custom fields in the block entity - tick To do: - rendering - handled screens - networking - data components Spotless & Checkstyle checks passed.
✅ Deploy Preview for nimble-elf-d9d491 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This comment was marked as outdated.
This comment was marked as outdated.
IMO, they were - too long (some didn't fit in the table-of-contents) - too similar (links back to the previous one, you couldn't see which one was "Creating and Registering the Block Entity" and which "Creating and Registering the Block")
These can be subpages, no need to do them in this PR - this is a great start, i'll have a look at it now. |
Also, you don't need to backport changes to previous versions, the older versions are set in stone and are not really meant to be expanded upon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good structure, just a few minor changes i'd suggest.
Describes how to:
BlockEntityProvider
/BlockWithEntity
(Maybe) To do:
BlockEntityRenderer
Also, idk if the article/code should be copied to 1.20.4 if there's pretty much nothing changed as far as i can tell.