-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include MixinExtras #854
Include MixinExtras #854
Conversation
d0a11b4
to
49cfb72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not related to mixinextras but why is microsoft
chosen as distribution instead of temurin
via client-test?
No strong reason, but the microsoft distribution is the same one used by Mojang and the official Minecraft launcher however. We should prob just use it everywhere, but in practice it doesnt matter. |
I think the only big question left is the mixin extras mod id. And fixing running the mc test project in dev, I think there is a system prop that can be set. |
49cfb72
to
8670c61
Compare
Comments addressed except the test project. I can mock something up for the modid, I'm not sure the |
I think we should find a low risk fix for it if possible. I know @sfPlayer1 has larger plans for the SAT solver stuff and will hopefully fix this while doing that. If there is a hack fix that works for now, that can be replaced later I'd be happy with that. |
513bd6c
to
c346e24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Supersedes #849