Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include MixinExtras #854

Merged
merged 6 commits into from
Nov 28, 2023

Conversation

LlamaLad7
Copy link
Contributor

Supersedes #849

@LlamaLad7 LlamaLad7 force-pushed the feature/ship-mixinextras-again branch from d0a11b4 to 49cfb72 Compare November 13, 2023 15:38
Copy link

@Kichura Kichura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to mixinextras but why is microsoft chosen as distribution instead of temurin via client-test?

@modmuss50
Copy link
Member

Not related to mixinextras but why is microsoft chosen as distribution instead of temurin via client-test?

No strong reason, but the microsoft distribution is the same one used by Mojang and the official Minecraft launcher however. We should prob just use it everywhere, but in practice it doesnt matter.

@modmuss50 modmuss50 changed the title Feature/ship mixinextras again Include MixinExtras Nov 19, 2023
@modmuss50 modmuss50 requested review from sfPlayer1, modmuss50 and a team November 19, 2023 14:16
gradle/installer-json.gradle Outdated Show resolved Hide resolved
gradle/installer-json.gradle Outdated Show resolved Hide resolved
@modmuss50
Copy link
Member

I think the only big question left is the mixin extras mod id. And fixing running the mc test project in dev, I think there is a system prop that can be set.

@LlamaLad7 LlamaLad7 force-pushed the feature/ship-mixinextras-again branch from 49cfb72 to 8670c61 Compare November 20, 2023 16:18
@LlamaLad7
Copy link
Contributor Author

Comments addressed except the test project. I can mock something up for the modid, I'm not sure the provides fix will be very simple.

@modmuss50
Copy link
Member

Comments addressed except the test project. I can mock something up for the modid, I'm not sure the provides fix will be very simple.

I think we should find a low risk fix for it if possible. I know @sfPlayer1 has larger plans for the SAT solver stuff and will hopefully fix this while doing that.

If there is a hack fix that works for now, that can be replaced later I'd be happy with that.

@LlamaLad7 LlamaLad7 requested a review from modmuss50 November 20, 2023 18:49
@LlamaLad7 LlamaLad7 force-pushed the feature/ship-mixinextras-again branch from 513bd6c to c346e24 Compare November 27, 2023 17:59
Copy link
Member

@modmuss50 modmuss50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@modmuss50 modmuss50 merged commit 11ce0e4 into FabricMC:dev/0.15 Nov 28, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants