Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand upon the internal client test framework. #3168

Closed

Conversation

modmuss50
Copy link
Member

All of this code is internal to Fabric API and is not exposed for mods to use. (Yet?)

This PR creates a very primitive API for other modules to impliment their own automated client tests, I started by adding some tests for the issues fixed in: #3164

Things I want to add:

  • A command to run the in world tests without needing to restart the game, should make developing and debugging these tests much easier.
  • Golden tests where part of the UI, or a custom exported image are saved into the github repo, thus any change to the image can fail the CI. In this example we could render the block to ensure that the texture changes.
  • Some documentation/guides to help other Fabric API developers make use of this
  • Maybe: record a video of the tests running in CI, just because its cool to see it click around the UI like a super human.

See the test screenshots on github actions or the following examples:

injected_resources_default
injected_resources_high_contrast
injected_resources_programmer

@modmuss50 modmuss50 added in progress This issue has PR(s) open to resolve it (or a PR that is WIP) test labels Jul 3, 2023
)
);
// Takes a little bit for our block to appear :D
waitForClientTicks(5);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Github actions is even slower, need to find a good way to know when the chunk has been fully re-rendered, it is also needed after changing the resource packs 🤔

@modmuss50 modmuss50 changed the base branch from 1.20.1 to 1.20.2 September 18, 2023 18:13
@modmuss50
Copy link
Member Author

This PR is old, im going to work on this slowly, one bit at a time. Starting with #4057

@modmuss50 modmuss50 closed this Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress This issue has PR(s) open to resolve it (or a PR that is WIP) test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant