-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand upon the internal client test framework. #3168
Closed
modmuss50
wants to merge
12
commits into
FabricMC:1.20.2
from
modmuss50:feature/client_test_improvements
Closed
Expand upon the internal client test framework. #3168
modmuss50
wants to merge
12
commits into
FabricMC:1.20.2
from
modmuss50:feature/client_test_improvements
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modmuss50
added
in progress
This issue has PR(s) open to resolve it (or a PR that is WIP)
test
labels
Jul 3, 2023
modmuss50
commented
Jul 3, 2023
) | ||
); | ||
// Takes a little bit for our block to appear :D | ||
waitForClientTicks(5); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like Github actions is even slower, need to find a good way to know when the chunk has been fully re-rendered, it is also needed after changing the resource packs 🤔
This PR is old, im going to work on this slowly, one bit at a time. Starting with #4057 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of this code is internal to Fabric API and is not exposed for mods to use. (Yet?)
This PR creates a very primitive API for other modules to impliment their own automated client tests, I started by adding some tests for the issues fixed in: #3164
Things I want to add:
See the test screenshots on github actions or the following examples: